Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun TMB calculation - test run #435

Merged
merged 17 commits into from
Aug 24, 2023
Merged

Conversation

AntoniaChroni
Copy link

Purpose/implementation Section

What scientific question is your analysis addressing?

This is a test run for re-running the TMB-calculation module.

The following will need to be addressed later on:

  1. The biospecimen_id_to_bed_map.tsv file was transferred from the data_dir and we renamed any misspelled files related to the ashion_exome....bed files.
  2. Shell and R script files call the input file from input_dir. This must be updated to data_dir when files are named properly in the data/biospecimen_id_to_bed_map.tsv file, and re-run the module.

What was your approach?

What GitHub issue does your pull request address?

This is related to ticket #430 (comment)

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

The following files are updated in the results_dir:

  1. snv-mutation-tmb-all.tsv and
  2. snv-mutation-tmb-coding.tsv

What is your summary of the results?

  • snv-mutation-tmb-all.tsv contains 4150 records (compared to 2766 in the previous file).
  • snv-mutation-tmb-coding.tsv contains 4146 records (compared to 2764 in the previous file).

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reran and everything is the same, thank you for putting this in so quickly!

@jharenza jharenza requested a review from a team as a code owner August 23, 2023 16:18
@jharenza
Copy link
Member

closes #430

@jharenza jharenza merged commit 609c4d9 into dev Aug 24, 2023
26 checks passed
@jharenza jharenza deleted the achroni/tmb-calculation-rerun branch August 24, 2023 17:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants