Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: add DMG, EGFR to methyl mol subtype #451

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Oct 19, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Add DMG, EGFR to methyl mol subtype

What was your approach?

Add DMG, EGFR to methyl mol subtype but maintain the previous molecular subtype results as DMG, H3 K28

What GitHub issue does your pull request address?

#448

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

HGG module output and histologies.tsv

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner October 19, 2023 21:07
Copy link

@AntoniaChroni AntoniaChroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the all bash files on EC2 and it run with no problems. All relative files were generated with integrated changes.

  • plots/HGG_stranded.pdf: it seems there is no grey/ no HGAT_NO_HISTONE_BRAF, is that right?

@jharenza jharenza merged commit 5bfd168 into dev Nov 28, 2023
22 checks passed
@jharenza jharenza deleted the zzgeng/DMG_methyl branch November 28, 2023 19:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants