Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: Add workflow for HGG molecular subtyping #454

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Oct 23, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Add workflow to illustrate the molecular subtyping of HGG

What was your approach?

Add workflow to illustrate the molecular subtyping of HGG

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Workflow image

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

figure

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner October 23, 2023 18:47
@zzgeng zzgeng changed the title add workflow for molecular subtyping Analysis update: Add workflow for molecular subtyping Oct 23, 2023
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the red path dx block, is it the case that all IHG are included in the HGG path dx now such that we do not pull them in separately? Possibly, we should add them to the free text block just as a check. Similarly, with PXA, we might want to have all of those come in via free text as well.

For the PXA, can you add the path free text requirement before the molecular alterations, and then for IHG with no fusion, also add the IHG, To be classified?

Copy link

@AntoniaChroni AntoniaChroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall.

  • You should align the first arrow form histologies to the red box, it falls inside the red box.
  • Same comment about IHG as in the HOPE png
  • First red box doesn't exist in the HOPE png
  • Blue boxes are connected differently than in the HOPE png
  • First red box to fix some syntax/commas:
  1. Brainstem glioma-Diffuse intrinsic pontine glioma,
  2. Astrocytoma, and
  3. infant type hemispheric glioma (maybe capital first letter in Infant unless it doesn't show like that in the pathology diagnosis?) ~ same for the following plus adding and before the last histology on the list.
  4. Anaplastic gliomatosis cerebri (who grade 4), and
  5. Astroblastoma

@jharenza jharenza changed the title Analysis update: Add workflow for molecular subtyping Analysis update: Add workflow for HGG molecular subtyping Nov 25, 2023
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change request - can you add a * to each green box and then in the legend *scores >= 0.80 and add this to every other workflow which is using methyl?

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add here "DMG_EGFR" for methylation.
I just noticed as well that the methylation subtypes are slightly off from the actual subtypes- can you use the exact subtypes in the methylation subclass column so there is no confusion?

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jharenza
Copy link
Member

docs only, no need for GA

@jharenza jharenza merged commit 7102772 into dev Nov 29, 2023
0 of 22 checks passed
@jharenza jharenza deleted the zzgeng/add_plot_to_HGG_readme branch November 29, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants