Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15 download and release notes (1/2) #554

Merged
merged 16 commits into from
Mar 1, 2024
Merged

V15 download and release notes (1/2) #554

merged 16 commits into from
Mar 1, 2024

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Mar 1, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR updates the download script and release notes for v15.

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from a team as a code owner March 1, 2024 03:25
@jharenza jharenza marked this pull request as draft March 1, 2024 03:25
@jharenza jharenza marked this pull request as ready for review March 1, 2024 04:48
Copy link

@komalsrathi komalsrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the download data script, checked the dimensions:

> dim(v15_tcga_counts)
[1] 59411 10411
> dim(v15_tcga_counts)
[1] 59411 10411

> dim(v15_gtex_tpm)
[1] 54998 17382
> dim(v15_gtex_counts)
[1] 54998 17382

Missing genes (e.g. CD99) have been recaptured as well:

> grep("CD99", rownames(v15_gtex_counts), value = T)
[1] "CD99L2" "CD99P1" "CD99"  
> grep("CD99", rownames(v15_tcga_counts), value = T)
[1] "CD99L2" "CD99P1" "CD99"  

Everything looks good. Thank you!!

@jharenza jharenza merged commit 09bf65e into dev Mar 1, 2024
23 checks passed
@jharenza jharenza deleted the v15-download branch March 1, 2024 23:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants