Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update runs to checkout@v4 to use node20 since node16 is deprecated #556

Merged
merged 8 commits into from
Mar 1, 2024

Conversation

jharenza
Copy link
Member

@jharenza jharenza commented Mar 1, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

  1. As in V15 download and release notes (1/2) #554 and V15 subset files (2/2) #555, there is a persistent issue with the CRANIO module in that it appears that disk space is being exhausted. I am attempting some cleanup steps per the comments here.

  2. I am pre-emptively updating to actions v4 which uses node 20 per the warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

What was your approach?

I remove all swap files, all old docker images, cache, unused packages prior to each analysis run.

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from a team as a code owner March 1, 2024 17:50
@jharenza jharenza requested a review from rjcorb March 1, 2024 21:04
@jharenza jharenza merged commit c4993a3 into v15-subset-files Mar 1, 2024
24 checks passed
@jharenza jharenza deleted the v15-ga-update branch March 1, 2024 23:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants