-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement createDirectory in file_system_vm.dart #1048
Comments
There are a few problems here: The path would need to be normalized ( .. and . resolved ) before running this algorithm. Especially consider "../make_a_sibling/../another_sibling/in_here" But yes, we do need this function (recursive create directory), and will probably implement it. |
Removed Area-Frog label. |
Added WontFix label. |
2021-04-07 irina.arkhipets@gmail.com Fixes #535: more nnbd tests for constant evaluation added. 2021-04-07 sgrekhov@unipro.ru Fixes #1068. Remove excessive - in a SharedOptions 2021-04-05 irina.arkhipets@gmail.com Fixes #535: more nnbd tests for constant evaluation added. 2021-04-05 irina.arkhipets@gmail.com Fixes #996: more tests added. 2021-04-05 irina.arkhipets@gmail.com Fixes #996: more tests added. 2021-04-05 irina.arkhipets@gmail.com Fixes #1067: added checks for old and new dart versions. 2021-04-05 irina.arkhipets@gmail.com Fixes #1066: added @Dart=2.12 to the initial version of the test, new test which checks recent dart behavior added. 2021-04-05 irina.arkhipets@gmail.com Fixes #1057: Expected result doe the tests with mailformed types updated. 2021-04-02 sgrekhov@unipro.ru Fixes #1062. Remove unnecessary assignment 2021-04-01 irina.arkhipets@gmail.com Fixes #1057: Expected result doe the tests with mailformed types updated. 2021-04-01 sgrekhov@unipro.ru Expected error code is fixed for Windows 2021-04-01 sgrekhov@unipro.ru Fixes #1060. Expected error message position updated 2021-04-01 sgrekhov@unipro.ru Fixes #1059. Expected error message updated 2021-04-01 sgrekhov@unipro.ru Fixes #1024. Adjust expected results for web platforms 2021-04-01 sgrekhov@unipro.ru #993. More Array tests added 2021-03-31 58489007+franklinyow@users.noreply.github.com Update LICENSE 2021-03-31 sgrekhov@unipro.ru #993. Array tests added 2021-03-31 irina.arkhipets@gmail.com Issue #1053: Missing Issue tag added, test expectation updated. 2021-03-30 irina.arkhipets@gmail.com Fixes #1054: Updated expectations for mailformed raw type variables. 2021-03-30 irina.arkhipets@gmail.com Fixes #1050: Updated expectations for mailformed raw type variables. 2021-03-30 irina.arkhipets@gmail.com Fixes #1050: Got rid of mailformed row type variable usage in i-2-b- tests. 2021-03-29 sgrekhov@unipro.ru Fixes #1043. Remove static warning as an expected result 2021-03-29 irina.arkhipets@gmail.com Fixes #1049: Correct expectation adjusted 2021-03-29 sgrekhov@unipro.ru Fixes #1048. Move tests to correct folder and change the description 2021-03-29 irina.arkhipets@gmail.com Fixes #1046: Test adjusted to work with the generic metadata feature enabled. 2021-03-29 sgrekhov@unipro.ru Fixes #1047. Change expected result to not to fail on JavaScript configurations 2021-03-29 sgrekhov@unipro.ru Fixes #1044. Change expected result to not to fail on JavaScript configurations 2021-03-26 irina.arkhipets@gmail.com Fixes #1029: Missing Issue tag added to the test. 2021-03-26 sgrekhov@unipro.ru Fixes #1042. Add check that produces different results for triple and double shifts 2021-03-26 sgrekhov@unipro.ru Fixes #1042. Fix built-in_types_t11.dart to expect correct results 2021-03-25 sgrekhov@unipro.ru Fixes #1019. Don't use type aliases in legacy libraries 2021-03-25 irina.arkhipets@gmail.com Fixes #1039: Old-style aliases corrected. 2021-03-25 sgrekhov@unipro.ru Fixes #988. Expect static type warning in a right way 2021-03-24 irina.arkhipets@gmail.com Issues #1029: Static expectation corrected. 2021-03-24 irina.arkhipets@gmail.com Issues #1035: Issue tag for the bug 45443 added. 2021-03-24 irina.arkhipets@gmail.com Merge branch 'master' of https://github.com/dart-lang/co19 2021-03-24 sgrekhov@unipro.ru #1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior 2021-03-23 sgrekhov@unipro.ru #1021. Remove expecting errors on web configurations for some negative numbers 2021-03-23 sgrekhov@unipro.ru Fixes #1034. Missed experimental flag added 2021-03-23 sgrekhov@unipro.ru #1033. Perform runtime check on big values for non-JavaScript configurations only 2021-03-23 irina.arkhipets@gmail.com Issues #1029: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 corrected and does not expect a compile error now. Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I5fae01c7b48aba502da04638430f4f6de79ac745 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194241 Reviewed-by: William Hesse <whesse@google.com>
Frog's file system wrapper only supports createDirectory on node, which is what dartdoc uses. A friendly Googler sent this to support it on the VM:
void createDirectory(String path, [bool recursive = false]) {
if (path.length == 0) {
return;
}
if (new Directory(path).exists()) {
return;
}
if (recursive) {
// TODO(): replace with path separator reported from vm/hostOS.
// Needs to be added to vm/runtime/directory.cc & .dart.
final String pathSeparatorPattern = "/";
List<String> parts = path.split(pathSeparatorPattern);
String partialPath = parts[0];
for (int i = 1; i < parts.length; i++) {
partialPath += partialPath + pathSeparatorPattern + parts[i];
new Directory(partialPath).create();
}
} else {
new Directory(path).create();
}
}
Should be easy to drop in, but we really need some tests for this first.
The text was updated successfully, but these errors were encountered: