Warnings when compiling core libraries

[devoncarew]

When compiling a helloworld html application, we get the following warnings from non-user code:

dart://htmlimpl/htmlimpl.dart/generated/src/wrapping/_IDBKeyRangeWrappingImplementation.dart(33:33): Parameter 'bound' is hiding 'METHOD bound' at _IDBKeyRangeWrappingImplementation.dart:IDBKeyRangeWrappingImplementation:18:15
dart://htmlimpl/htmlimpl.dart/generated/src/wrapping/_IDBKeyRangeWrappingImplementation.dart(45:33): Parameter 'bound' is hiding 'METHOD bound' at _IDBKeyRangeWrappingImplementation.dart:IDBKeyRangeWrappingImplementation:18:15
dart://htmlimpl/htmlimpl.dart/generated/src/wrapping/_StorageWrappingImplementation.dart(17:25): Parameter 'key' is hiding 'METHOD key' at _StorageWrappingImplementation.dart:StorageWrappingImplementation:21:10
dart://htmlimpl/htmlimpl.dart/generated/src/wrapping/_StorageWrappingImplementation.dart(25:26): Parameter 'key' is hiding 'METHOD key' at _StorageWrappingImplementation.dart:StorageWrappingImplementation:21:10
dart://htmlimpl/htmlimpl.dart/generated/src/wrapping/_StorageWrappingImplementation.dart(30:23): Parameter 'key' is hiding 'METHOD key' at _StorageWrappingImplementation.dart:StorageWrappingImplementation:21:10
dart://htmlimpl/htmlimpl.dart/src/DocumentFragmentWrappingImplementation.dart(86:9): Local variable 'last' is hiding 'METHOD last' at DocumentFragmentWrappingImplementation.dart:FilteredElementList:110:11
dart://htmlimpl/htmlimpl.dart/src/ElementWrappingImplementation.dart(136:11): Local variable 'last' is hiding 'METHOD last' at ElementWrappingImplementation.dart:_ChildrenElementList:143:11
dart://htmlimpl/htmlimpl.dart/src/NodeWrappingImplementation.dart(136:11): Local variable 'last' is hiding 'METHOD last' at NodeWrappingImplementation.dart:_ChildrenNodeList:143:8

It's a bit confusing for the user since they can't do anything about the errors.

[rakudrama]

We need a way to suppress this warning at the library level to get rid of this problem.

The VM/Frog/Leg/Dartc all need a common mechanism for suppressing warnings so I can suppress a warning once.

Basically, without a suppression mechanism, we are asking machine generated code to pass 'lint'. That places an unreasonable burden on the generator.

While it is possible to change the generator, that is not a good idea.
I don't know what a reasonable mechanical replacement policy is. The replacement name, e.g. 'bound$1' or whatever, will show up as a completion suggestion in the editor, so we should rather stick with the name that comes from the WebKit IDL and is used the W3C or WebKit documentation.

---

Added Area-Compiler, Triaged labels.

[DartBot]

This comment was originally written by mmendez@google.com

---

Section 3.1 on Scoping calls out the warning at least as I read it. I think that section 4 of the spec should define a way to suppress them so we can be consistent.

---

cc @gbracha.
Removed Area-Compiler label.
Added Area-Language label.

[DartBot]

This comment was originally written by mmendez@google.com

---

We can also suppress the warning in this case if a spec change is contentious.

[gbracha]

Changing this to a feature request. It is part of a much larger issue of how to deal with warnings. And yes, a spec change is contentious.

---

Removed Type-Defect label.
Added Type-Enhancement label.

[lukechurch]

I'd request that this issue be made a priority.

It's damaging to user experience to have warnings thrown on a hello world application - esp. as it will immediately train them to ignore warnings. I very much want to avoid that, esp. as warning arguably matter more in Dart than many other languages due to the type system.

---

Removed Priority-Medium label.
Added Priority-High label.

[DartBot]

This comment was originally written by mmendez@google.com

---

Konstantin, could we suppress this warning for the dom library only? Please assign back to gilad once the warning is suppressed.

---

Set owner to @scheglov.

[devoncarew]

We added some code to the editor (http://codereview.chromium.org/9030024/) to ignore warnings from dart: code. This is intended to be a relatively temporary fix until a more permanent solution is found.

[DartBot]

This comment was originally written by mmendez@google.com

---

I think that we should also suppress warnings for the generated dom code in dartc as well until we get some allowance in the spec for formal suppression.

[scheglov]

http://codereview.chromium.org/9149008

DartC will not show warning for library htmlimpl.dart now.

---

Set owner to @gbracha.

[rakudrama]

I get the same warnings in dart:dom

The code is similar to htmlimpl, but a separate library.

  RULE dart_generated_sources_dart_binding_356 out/Release/obj/gen/webcore/bindings/DartDOMWindowWebAudio.cpp
  RULE dart_generated_sources_dart_binding_366 out/Release/obj/gen/webcore/bindings/DartDOMWindowWebSocket.cpp
  ACTION Compiling dart system libraries out/Release/obj.target/dartc/geni/dartc/api/dart/core/com/google/dart/corelib/corelib.dart.api
make: Nothing to be done for DumpRenderTree'. make: Nothing to be done forchrome'.
dart://dom/dom/generated/src/wrapping/_IDBKeyRangeWrappingImplementation.dart:44: Parameter 'bound' is hiding 'METHOD bound' at _IDBKeyRangeWrappingImplementation.dart:_IDBKeyRangeWrappingImplementation:26:15 (sourced from dart://dom/dom/dom.dart)
    43:
    44: IDBKeyRange lowerBound(IDBKey bound, [bool open = null]) {
dart://dom/dom/generated/src/wrapping/_IDBKeyRangeWrappingImplementation.dart:59: Parameter 'bound' is hiding 'METHOD bound' at _IDBKeyRangeWrappingImplementation.dart:_IDBKeyRangeWrappingImplementation:26:15 (sourced from dart://dom/dom/dom.dart)
    58:
    59: IDBKeyRange upperBound(IDBKey bound, [bool open = null]) {
dart://dom/dom/generated/src/wrapping/_InjectedScriptHostWrappingImplementation.dart:59: Parameter 'num' is hiding 'CLASS num' at ../../../../../../core/com/google/dart/corelib/corelib.dart/src/num.dart:num:3:11 (sourced from dart://dom/dom/dom.dart)
    58:
    59: Object inspectedNode(int num) {
dart://dom/dom/generated/src/wrapping/_StorageWrappingImplementation.dart:23: Parameter 'key' is hiding 'METHOD key' at _StorageWrappingImplementation.dart:_StorageWrappingImplementation:28:10 (sourced from dart://dom/dom/dom.dart)
    22:
    23: String getItem(String key) {
dart://dom/dom/generated/src/wrapping/_StorageWrappingImplementation.dart:33: Parameter 'key' is hiding 'METHOD key' at _StorageWrappingImplementation.dart:_StorageWrappingImplementation:28:10 (sourced from dart://dom/dom/dom.dart)
    32:
    33: void removeItem(String key) {
dart://dom/dom/generated/src/wrapping/_StorageWrappingImplementation.dart:39: Parameter 'key' is hiding 'METHOD key' at _StorageWrappingImplementation.dart:_StorageWrappingImplementation:28:10 (sourced from dart://dom/dom/dom.dart)
    38:
    39: void setItem(String key, String data) {

---

Set owner to @scheglov.

[scheglov]

http://code.google.com/p/dart/source/detail?r=3146

OK, dom.dart is now ignored too.

---

Set owner to @gbracha.

[gbracha]

Added Fixed label.