Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click cli main merge #6926

Merged
merged 157 commits into from
Feb 9, 2023
Merged

Click cli main merge #6926

merged 157 commits into from
Feb 9, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Feb 9, 2023

resolves #

Description

Checklist

eve-johns and others added 30 commits October 17, 2022 16:58
@eve-johns @leahwicz
f-string cleanup #6068 (#6082)
a9c8bc0 
* fix f string issue

* removed one space

* Add changelog

* fixed return format

Co-authored-by: Leah Antkiewicz <leah.antkiewicz@fishtownanalytics.com>
@luke-bassett
Updated string formatting on non-f-strings. (#6086)
35f7975 
* Updated string formatting on non-f-strings.

Found all cases of strings separated by white space on a single line and
removed white space separation. EX: "hello " "world" -> "hello world".

* add changelog entry
@VersusFacit
Working solution serialization bug. (#5874)
ff2f1f4 
* Create functors to initialize event types with str-type member attributes. Before this change, the spec of various classes expected base_msg and msg params to be str's. This assumption did not always hold true. post_init hooks ensures the spec is obeyed.
* Add new changelog.
* Add msg type change functor to a few other events that could use it.

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@VersusFacit
Add unit tests for recent stringifier functors added to events librar…
a7670a3 
…y. (#6095)

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@peterallenwebb
CT-1099: Migrate test 071_commented_yaml_regression_3568_tests (#6106)
53ae325
@MichelleArk
Add 'michelleark' to changie's core_team list (#6084)
6c86094
@MichelleArk
convert 027 cycle test (#6094)
17b8266 
* convert 027 cycle test

* remove no-op expect_pass=False

* remove postgres from test names
@iknox-fa
[BUGFIX] Force tox to update pip (fixes psycopg2-binary @ 2.9.5) (
c285601 
#6134)
@VersusFacit
Ct 1167/030 statement tests conversion (#6109)
1916784 
* Convert test to functional set.

* Remove old statement tests from integration test set.

* Nix whitespace

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@emmyoop
switch out to use internal action for triage labels (#6120)
7b73264 
* switch out to use our action

* point to main
@iknox-fa
more ergonomic profile name handling (#6157)
77dfec7
@emmyoop
point to correct workflow (#6161)
fc00239 
* point to correct workflow

* add inputs
@emmyoop
revert to community action (#6163)
8145eed
@emmyoop @gshank @peterallenwebb
Convert messages to struct logs (#6064)
be4a91a 
* Initial structured logging changes

* remove "this" from core/dbt/events/functions.py

* CT-1047: Fix execution_time definitions to use float

* CT-1047: Revert unintended checking of changes to functions.py

* WIP

* first pass to resolve circular deps

* more circular dep resolution

* remove a bunch of duplication

* move message into log line

* update comments

* fix field that wen missing during rebase

* remove double import

* remove some comments and extra code

* fix pre-commit

* rework deprecations

* WIP converting messages

* WIP converting messages

* remove stray comment

* WIP more message conversion

* WIP more message conversion

* tweak the messages

* convert last message

* rename

* remove warn_or_raise as never used

* add fake calls to all new events

* fix some tests

* put back deprecation

* restore deprecation fully

* fix unit test

* fix log levels

* remove some skipped ids

* fix macro log function

* fix how messages are built to match expected outcome

* fix expected test message

* small fixes from reviews

* fix conflict resolution in UI

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>
@MichelleArk
converting 023_exit_codes_tests (#6105)
a427484 
* converting 023_exit_codes_tests

* use packages fixture, clean up test names
@FishtownBuildBot
Add new index.html and changelog yaml files from dbt-docs (#6112)
d23285b
@dependabot @FishtownBuildBot
Bump python from 3.10.7-slim-bullseye to 3.11.0-slim-bullseye in /doc…
8e28f59 
…ker (#6180)

* Bump python from 3.10.7-slim-bullseye to 3.11.0-slim-bullseye in /docker

Bumps python from 3.10.7-slim-bullseye to 3.11.0-slim-bullseye.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add automated changelog yaml from template for bot PR

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
@emmyoop
add python version and upgrade action (#6204)
c3ccbe3
@MichelleArk
add typing to DepsTask.run (#6192)
cfad27f
@racheldaniel
Updates lib to use new profile name functionality (#6202)
d0543c9 
* Updates lib to use new profile name functionality

* Adds changie entry

* Fixes formatting
@gshank
Combine various print result log events with different levels (#6174)
68d06d8 
* Combine various print result log events with different levels

* Changie

* more merge cleanup

* Specify DynamicLevel for event classes that must specify level
@gshank
CT 1443 remove root path (#6172)
6c76137 
* Remove root_path

* Bump manifest schema to 8

* Update tests and compability utility for v8, root_path removal
@ChenyuLInx
properly track hook running (#6059)
930bd35
@stu-k
Convert threading tests to pytest (#6226)
4e78618
@stu-k
Convert color tests to pytest (#6230)
d5e9ce1
@stu-k
Convert postgres index tests (#6228)
f022435
@josephberni
feature/favor-state-node (#5859)
73116fb
@dependabot @FishtownBuildBot
Update colorama requirement from <0.4.6,>=0.3.9 to >=0.3.9,<0.4.7 in …
9f280a8 
…/core (#6144)

* Update colorama requirement in /core

Updates the requirements on [colorama](https://github.com/tartley/colorama) to permit the latest version.
- [Release notes](https://github.com/tartley/colorama/releases)
- [Changelog](https://github.com/tartley/colorama/blob/master/CHANGELOG.rst)
- [Commits](tartley/colorama@0.3.9...0.4.6)

---
updated-dependencies:
- dependency-name: colorama
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add automated changelog yaml from template for bot PR

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
@MichelleArk
converting 044_test_run_operations (#6122)
39c5c42 
* converting 044_test_run_operations
@McKnight-42
[CT-1262] Convert dbt_debug (#6125)
66ac107 
* init pr for dbt_debug test conversion

* removal of old test

* minor test format change

* add new Base class and Test classes

* reformatting test, new method for capsys and error messgae to check, todo fix badproject

* refomatting tests, ready for review

* checking yaml file, and small reformat

* modifying since update wasn't working in ci/cd
VersusFacit and others added 18 commits January 26, 2023 12:23
@VersusFacit
Ct 1629/052 column quoting tests conversion (#6652)
3f96fad 
* Test converted and reformatted for pytest.

* Ax old versions of 052 test

* Nix the 'os' import and black format

* Change names of models to be more PEP like

* cleanup code

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@alexander-smolyakov
[CI/CD] Update release workflow and introduce workflow for nightly re…
82d9b2f 
…leases (#6602)

* Add release workflows

* Update nightly-release.yml

* Set default `test_run` value to `true`

* Update .bumpversion.cfg

* Resolve review comment

- Update workflow docs
- Change workflow name
- Set `test_run` default value to `true`

* Update Slack secret

* PyPI
@nssalian
Adding nssalian to committers list (#6769)
c653330
@nssalian
[CT-1940] Stand-alone Python module for PostgresColumn (#6773)
a8abc49
@alexander-smolyakov
Update release workflow (#6778)
92d1ef8 
- Update AWS secrets
- Rework condition for Slack notification
@aranke
[CT-1841] Convert custom target test to Pytest (#6765)
d2f3cdd
@emmyoop
fix contributor list generation (#6799)
622e5fd
@VersusFacit
Ct 1827/064 column comments tests conversion (#6766)
42b7caa 
* Convert test and make it a bit more pytest-onic

* Ax old integration test.

* Run black on test conversion

* I didn't like how pytest was running the fixture so wrapped it into a closure.

* Merge converted test into persist docs.

* Move persist docs tests to the adapter zone. Prep for adapter tests.

* Fix up test names

* Fix name to be less confusing.

---------

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@VersusFacit
Add clearer directions for custom test suite vars in Makefile. (#6764)
1a6e4a0 
* Add clearer directions for custom test suite vars in Makefile.

* Fix up PR for review

* Fix erroneous whitespace.

* Fix a spelling error.

* Add documentation to discourage makefile edits but provide override tooling.

* Fix quotation marks. Very strange behavior

* Compact code and verify quotations happy inside bash and python.

* Fold comments into Makefile.

---------

Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
@gshank
CT 2000 fix semver prerelease comparisons (#6838)
d9424cc 
* Modify semver.py to not use packaging.version.parse

* Changie
@emmyoop
update regex to match all iterations (#6839)
2245d8d 
* update regex to match all iterations

* convert to num to match all adapters

* add comments, remove extra .

* clarify with more comments

* Update .bumpversion.cfg

Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>

---------

Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
@colin-rogers-dbt
move test_store_test_failures.py to adapter zone (#6816)
b2ea2b8
@nssalian
[CT-1959]: moving simple_seed tests to adapter zone (#6859)
4c63b63 
* Formatting

* Changelog entry

* Rename to BaseSimpleSeedColumnOverride

* Better error handling

* Update test to include the BOM test

* Cleanup and formating

* Unused import remove

* nit line

* Pr comments
@peterallenwebb
CT-1917: Fix a regression in the behavior of the -q/--quiet cli param…
ccb4fa2 
…eter (#6886)
@emmyoop
Dynamically list all .latest branches for scheduled testing (#6682)
df64511 
* first pass at automating latest branches

* checkout repo first

* fetch all history

* reorg

* debugging

* update test id

* swap lines

* incorporate new branch aciton

* tweak vars
@dave-connors-3
add base class for merge exclude tests (#6700)
3ad4037 
* add base class for merge exclude tests

* changie <33

* remove comments

* add comments to sql, remove and clarify contents of resultholder
@emmyoop
1.4 regression: Check if status has node attribute (#6899)
abbece8 
* check for node

* add changelog

* add test for regression
@aranke
Merge main into feature/click-cli
723142c
@aranke aranke requested a review from a team as a code owner February 9, 2023 19:54
@aranke aranke requested a review from a team February 9, 2023 19:54
@aranke aranke requested review from a team and leahwicz as code owners February 9, 2023 19:54
@cla-bot cla-bot bot added the cla:yes label Feb 9, 2023
iknox
iknox approved these changes Feb 9, 2023
View reviewed changes
Copy link

@iknox iknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All these changes were previously reviewed so this is #rubberstamp

iknox-fa
iknox-fa approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, logged in to the wrong GH account.

@aranke aranke merged commit 57aef33 into feature/click-cli Feb 9, 2023
@aranke aranke deleted the click-cli-main-merge branch February 9, 2023 20:21
@aranke aranke mentioned this pull request Feb 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iknox-fa iknox-fa iknox-fa approved these changes

@iknox iknox iknox approved these changes

@leahwicz leahwicz Awaiting requested review from leahwicz

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt was automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.