Skip to content

vets-api/v0.0.1410
Compare
Choose a tag to compare
@va-bot va-bot released this 17 Apr 17:01
· 10858 commits to 4e4d67055e075295edf98750f0f46324bbfb6c52 since this release
vets-api/v0.0.1410
335041e

Release 0.0.1410 ami-0d3118b71dd1eca02

02e5a2d Set ssn to User#ssn if malformed in SubmitForm674Job. (#12410)

In #12379, I set up logging to catch if we were sending malformed SSNs in our vnp_person_create call to BGS. That work was predicated upon the assumption that when BGS returned a failed SQL statement with an SSN of "", BGS was redacted the actual SSN we sent over. After deploying this work, I learned that we were literally sending SSNs equal to the string "" to BGS.

The SSN we send originates from User#ssn, in BGS::DependentService. It is passed to SubmitForm686cJob, which makes a successful request to BGS (i.e. the SSN at this stage is a valid 9-digit SSN). That SSN is then passed to SubmitForm674Job; however, by the time we are sending it to BGS, it has transformed into the string "********". I have no idea why this is happening, even after spending several hours investigating. I'm going to continue that investigation, but in the meantime, in this PR, I'm going to try to "refresh" the ssn by calling User#ssn once again, if the SSN is malformed before we send it to BGS.

5e8df63 Update appeals_api rake tasks for new OAuth scopes (#12368)

  • Update appeals_api rake tasks for new OAuth scopes

  • Make rake task code slightly more readable

411bb76 Task update native doc (#12297)

  • add redis to OSX getting started native doc

  • update numbering for setup doc

Co-authored-by: Verdance Luke verdanceluke@Verdances-MacBook-Pro.local

63cfaf0 Bdex/54161: Migrate eVSS calls to rated disabilities functionality (vets-api /rated_disabilities) (#12234)

  • bdex/54076: start eVSS -> Lighthouse api provider interface

  • bdex/54076: add rated disablity dto

  • bdex/54076: start data transform layer

  • incremental work

  • cleanup

  • revert gemfile.lock

  • revert gemfile.lock again

  • more cleanup

  • more cleanup

  • added super (thanks for asking)

  • abstract class impersonation

  • more cleanup

  • unit tests + in progress work

  • more adds

  • bdex/54076: beef up rated disabilities api provider unit tests

  • bdex/54076: change to symbol for shared_examples name

  • fix linting errors

  • added feature toggle for rated disabilities provider

  • fix swagger_spec tests

  • added bdex to CODEOWNERS

  • modularize!

  • revert modularization

  • added LH veteran_verification endpoint infra

  • added LH veteran_verification endpoint infra 2

  • moved feature toggle to api factory

  • incremental work on LH VV implementation

  • more vv testing

  • more incremental work

  • changed rated_disabilities HTTP method to POST

added transform layer for lighthouse provider

  • added factory method calls to in-progress controller

  • cleanup

  • revert whitespace

  • whitespace removal

  • rubocoping

  • added configs to test.yml

  • more api changes + unit test fixes

  • form_profile_spec test fix

  • changes in passing icn

  • bdex/54161: remove space at the end of json generation

  • bdex/54161: remove unnecessary variable declaration

  • bdex/54161: fix rubocop offenses

  • bdex/54161: fix auth token url path

  • bdex/54161: disable lighthouse api provider for evss tests

  • bdex/54161: fix service unit test

  • bdex/54161: update test description wording

  • bdex/54161: configurable timeout

  • bdex/54161: test creating lh provider when feature is enabled

  • bdex/54161: fix spelling errors

  • bdex/54161: do not raise exception on Lighthouse error - simply log

  • bdex/54161: use Rails.logger for service failure information

  • bdex/54161: trim line length

  • bdex/54161: transform LH "decision" to "SVCCONNCTED" or "NOTSVCCON"

  • bdex/54161: rectify linting

  • bdex/54161: add rated disability description text

  • bdex/54161: reduce method line length

  • bdex/54161: abstract decision_code transform for method line length

  • bdex/54161: turn off lighthouse provider for evss service tests

  • bdex/54161: rename request_body variable to auth_params

  • does this dismiss reviews?

Co-authored-by: lightning aurora.hampton@agile6.com

f70df3d Update appeals insomnia config (#12393)

a57550d Disable Rails console autocomplete in deployed envs (#12411)

926b2c3 [12331] Refactor BGS Services to more clearly show what User model fields are being leveraged (#12332)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

4e4d670 Remove sign-in service stats from initializer (#12415)

Assets 2
Loading