Error when ref is used on a parameter or return type of an UnmanagedCallersOnly method #57043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allersOnly method Fixes dotnet#57025.
|
@dotnet/roslyn-compiler for a couple of reviews. /cc @jkotas. |
AlekseyTs
reviewed
Oct 8, 2021
|
It looks like existing tests are broken by the change. |
|
@dotnet/roslyn-compiler for a second review. |
1 similar comment
|
@dotnet/roslyn-compiler for a second review. |
cston
reviewed
Oct 13, 2021
cston
approved these changes
Oct 13, 2021
cston
approved these changes
Oct 13, 2021
…sonly * upstream/main: (829 commits) Re-enable BuildWithCommandLine test (dotnet#57584) Fix expected formatting in tests Simplify PR feedback Don't crash Use ExpressionBody on local functions in top level statements (dotnet#57571) Less linq Revert Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNavigationBarItemService.vb Add test Simplify WIP Install .NET SDK in PR Validation pipeline Revert to VS2019 for PR Validation Update dependencies from https://github.com/dotnet/roslyn build 20211103.8 Validate the checksum of source on disk (dotnet#57541) Clean up VsCodeWindowManager (dotnet#57582) Update VS editor package version Revert to VS2019 for official build Revert to VS2019 for official build StackFrame Parser/Lexer as EmbeddedLanguage (dotnet#56957) ...
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Nov 17, 2021
…rations * upstream/main: (3387 commits) Fix ValueTracking for index parameters (dotnet#57727) Avoid accessing current assembly identity while reporting an accessibility diagnostics for an inaccessible internal symbol. (dotnet#57783) Include a type for NoneOperations in VB, print the type in tests (dotnet#57664) Don't throw exceptions for file changes after a project is unloaded Check up front for being called to remove more than once Fix C# language name in spec (dotnet#57427) Add test Fix null ref in navbars Ensure that getting the checksum for a project cone is resilient to its project references being missing Check constraints on lifted operator types (dotnet#57050) Adjust tests for Windows 11 changes (dotnet#57678) Add comment Load SVsShellDebugger before calling IVsSolution.CreateSolution Remove extra EnsureEditableDocuments calls (dotnet#57725) Don't show nullable annotation in completion items of static field/property Don't analyze local function bodies as though they are top level code (dotnet#57623) update error code to fix main break (dotnet#57739) Error when ref is used on a parameter or return type of an UnmanagedCallersOnly method (dotnet#57043) Simplify code from review Fix featureflag name for .net 6 host in UI ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57025.