Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 'features/ParamsCollections' into 'main' #72511

Merged
merged 44 commits into from
Mar 12, 2024
Merged

Merge 'features/ParamsCollections' into 'main' #72511

merged 44 commits into from
Mar 12, 2024

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs
Merge main to ParamsCollections (dotnet#71150)
2bedf28
@AlekseyTs
Make trivial Params Collections scenarios working end to end (dotnet#…
569dcb7 
…71136)
@AlekseyTs
Params Collections: Implement language version check. (dotnet#71228)
60a4581
@AlekseyTs
Params Collections: Implement "Better function member" section of the…
88c8859 
… proposal (dotnet#71271)

dotnet/csharplang#7768
@AlekseyTs
IOperation - drop synthesized conversion placed on top of params coll…
07fc1db 
…ections (dotnet#71325)
@AlekseyTs
Add handling of params collections for natural delegate types (dotnet…
0e16ec0 
…#71334)
@AlekseyTs
Params Collections - Adjust binding in presence of dynamic arguments (d…
a91ef66 
…otnet#71421)

Implements changes proposed in dotnet/csharplang#7792.
@AlekseyTs
Params Collections: misc chanages (dotnet#71423)
a9ffbe0 
- Params Collections in attributes
- Params Collections in lambdas
- Params Collections and interpolated string handler
- Order of evaluation:
  - named arguments
  - compound assignment
  - object initializer

Also fixes dotnet#71488.
@AlekseyTs
Merge 'dotnet/main' into ParamsCollections
4fb7084
@AlekseyTs
Temporarily skip some tests to unblock merge from main
99ef47c
@AlekseyTs
Merge 'dotnet/main' into ParamsCollections (dotnet#71545)
0be7dc3
@AlekseyTs
Enable some dynamic collection expression tests which were disabled d…
6bc0d9b 
…uring merge from 'main'. (dotnet#71558)
@AlekseyTs
Add a test for 'Params Collections.' (dotnet#71572)
7f00d15
@AlekseyTs
Params Collections: Add a bunch of PROTOTYPE comments and a couple of…
55b6a79 
… VB tests. (dotnet#71598)
@AlekseyTs
Use ParamCollectionAttribute to mark params collections in metadata (d…
ba5ee92 
…otnet#71747)

Corresponding speclet update is dotnet/csharplang#7850
@AlekseyTs
Merge 'dotnet/main' into ParamsCollections
399026e
@AlekseyTs
Follow up on merge from 'main'
882ccbc
@AlekseyTs
Merge 'dotnet/main' into ParamsCollections(dotnet#71824)
897fd49
@AlekseyTs
Adjust public API based on API review feedback (dotnet#71940)
1c5c7e2 
Closes dotnet#71816.
@AlekseyTs
Align params type validation with the the spec (dotnet#71918)
6cd3f1e 
https://github.com/dotnet/csharplang/blob/main/proposals/params-collections.md#method-parameters
@AlekseyTs
Params parameters are implicitly scoped when their type is a ref stru…
6fcac7d 
…ct. (dotnet#72000)

UnscopedRefAttribute can be used to override that.
https://github.com/dotnet/csharplang/blob/main/proposals/params-collections.md#ref-safety
@AlekseyTs
Merge remote-tracking branch 'dotnet/main' into ParamsCollections_20
18852b8
@AlekseyTs
Update test according to changes in ParamsCollections branch
25414ee
@AlekseyTs
Merge 'dotnet/main' into ParamsCollections (dotnet#72042)
1dbe23e
@AlekseyTs
Break a cycle through attributes (dotnet#72041)
2b8a744
@AlekseyTs
Add more tests and address some of the PROTOTYPE comments (dotnet#72089)
7ddc662
@AlekseyTs
Address more PROTOTYPE comments (dotnet#72113)
ba462cc
@AlekseyTs
Clone some IDE tests for params collections (dotnet#72228)
03fd758 
Related to dotnet#72224.
Related to dotnet#72225.
Related to dotnet#72227.
@AlekseyTs
Add ArgumentKind.ParamCollection (dotnet#72221)
05cf517
@AlekseyTs
Rename BoundNode flag for clarity (dotnet#72235)
8085621
AlekseyTs added 11 commits March 5, 2024 04:49
@AlekseyTs AlekseyTs requested review from a team as code owners March 12, 2024 18:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 12, 2024
@AlekseyTs AlekseyTs requested review from 333fred and RikkiGibson and removed request for a team March 12, 2024 18:27
@AlekseyTs AlekseyTs enabled auto-merge March 12, 2024 18:36
@runfoapp runfoapp bot mentioned this pull request Mar 12, 2024
Open
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @333fred, @dotnet/roslyn-compiler Need a sign-off for a feature merge PR

jcouv
jcouv approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed test change and commit list. LGTM Thanks

@AlekseyTs AlekseyTs merged commit 5fc7ba0 into dotnet:main Mar 12, 2024
30 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 12, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 21, 2024
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@BillWagner BillWagner mentioned this pull request May 7, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred Awaiting requested review from 333fred

@RikkiGibson RikkiGibson Awaiting requested review from RikkiGibson

Assignees
No one assigned
Labels
Area-Compilers Feature - ParamsCollections untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @jcouv @RikkiGibson