-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate missing documentation #28781
Reinstate missing documentation #28781
Conversation
The following settings appear on lines removed in f123a53 and not in the
Of these, the following still seem to be valid settings:
The following do not seem to be valid settings, but are still mentioned in a test:
Lines 104 to 105 in 5904d93
|
The settings `indices.recovery.concurrent_streams` and `indices.recovery.concurrent_small_file_streams` were removed in f5e4cd4. This commit removes their last traces from the codebase. Relates elastic#28781
@Sue-Gallagher @debadair I'm happy to try and resurrect these lost docs, but I'm not sure where in the docs tree they should go, as things seem to have moved around quite a lot since 1.7. Your guidance would be appreciated. |
It looks like the missing settings should be added to https://www.elastic.co/guide/en/elasticsearch/reference/6.2/index-modules.html#index-modules-settings. If you want to open a PR for that, that would be most awesome. |
The documentation for settings index.routing.allocation.enable, index.routing.rebalance.enable and index.gc_deletes was lost in a previous refactoring. This change reinstates it.
I reinstated docs for Setting Setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The documentation for settings index.routing.allocation.enable, index.routing.rebalance.enable and index.gc_deletes was lost in f123a53. This change reinstates it.
The documentation for settings index.routing.allocation.enable, index.routing.rebalance.enable and index.gc_deletes was lost in f123a53. This change reinstates it.
The documentation for settings index.routing.allocation.enable, index.routing.rebalance.enable and index.gc_deletes was lost in f123a53. This change reinstates it.
The documentation for settings index.routing.allocation.enable, index.routing.rebalance.enable and index.gc_deletes was lost in f123a53. This change reinstates it.
The documentation for settings index.routing.allocation.enable, index.routing.rebalance.enable and index.gc_deletes was lost in f123a53. This change reinstates it.
* 6.x: Watcher: Ensure mail message ids are unique per watch action (#30112) SQL: Correct error message (#30138) SQL: Add BinaryMathProcessor to named writeables list (#30127) Tests: Use buildDir as base for generated-resources (#30191) Fix SliceBuilderTests#testRandom failures Fix edge cases in CompositeKeyExtractorTests (#30175) Document time unit limitations for date histograms (#30177) Remove licenses missed by the migration [DOCS] Updates docker installation package details (#30110) Fix TermsSetQueryBuilder.doEquals() method (#29629) [Monitoring] Remove unhelpful Monitoring tests (#30144) [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655) [test] include oss tar in packaging tests (#30155) TEST: Update settings should go through cluster state (#29682) Add additional shards routing info in ShardSearchRequest (#29533) Reinstate missing documentation (#28781) Clarify documentation of scroll_id (#29424) Fixes Eclipse build for sql jdbc project (#30114) Watcher: Fold two smoke test projects into smoke-test-watcher (#30137)
The setting
index.routing.allocation.enable
was documented in v1.7 but lost in the refactoring in f123a53 so has been undocumented since 2.0.It might also be worth checking if any other settings were lost in the same change. I have not done so yet.
/cc @elastic/es-distributed.