Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TermsSetQueryBuilder.doEquals() method #29629

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Fix TermsSetQueryBuilder.doEquals() method #29629

merged 2 commits into from
Apr 26, 2018

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Apr 20, 2018

Closes #29620

@tlrx tlrx added >bug review :Search/Search Search-related issues that do not fall into other categories v7.0.0 labels Apr 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

This was referenced Apr 20, 2018
Closed
Closed
cbuescher
cbuescher reviewed Apr 20, 2018
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it would be a good opportunity to add add an overwrite of AbstractQueryTestCase#mutateInstance so that these kind of bugs get detected. I think it shouldn't be too much work in this case, wdyt?

@tlrx
Copy link
Member Author

tlrx commented Apr 20, 2018

@cbuescher Thanks for the reminder about the test. I added a mutate instance method in the test.

cbuescher
cbuescher approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlrx great, thanks. LGTM

@cbuescher cbuescher self-assigned this Apr 20, 2018
@tlrx tlrx force-pushed the fix-term-set-query-builder branch 2 times, most recently from fc55e8d to ca6684c Compare April 25, 2018 18:42
@tlrx tlrx force-pushed the fix-term-set-query-builder branch from ca6684c to 0338874 Compare April 26, 2018 07:33
@tlrx tlrx merged commit e864b93 into elastic:master Apr 26, 2018
tlrx added a commit that referenced this pull request Apr 26, 2018
@tlrx
Fix TermsSetQueryBuilder.doEquals() method (#29629)
ee89312 
Closes #29620
@tlrx tlrx deleted the fix-term-set-query-builder branch April 26, 2018 15:50
tlrx added a commit that referenced this pull request Apr 26, 2018
@tlrx
Fix TermsSetQueryBuilder.doEquals() method (#29629)
e954938 
Closes #29620
@tlrx tlrx added v6.3.1 and removed v6.3.0 labels Apr 26, 2018
dnhatn added a commit that referenced this pull request Apr 27, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
b7727c6 
* 6.x:
  Watcher: Ensure mail message ids are unique per watch action (#30112)
  SQL: Correct error message (#30138)
  SQL: Add BinaryMathProcessor to named writeables list (#30127)
  Tests: Use buildDir as base for generated-resources (#30191)
  Fix SliceBuilderTests#testRandom failures
  Fix edge cases in CompositeKeyExtractorTests (#30175)
  Document time unit limitations for date histograms (#30177)
  Remove licenses missed by the migration
  [DOCS] Updates docker installation package details (#30110)
  Fix TermsSetQueryBuilder.doEquals() method (#29629)
  [Monitoring] Remove unhelpful Monitoring tests (#30144)
  [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655)
  [test] include oss tar in packaging tests (#30155)
  TEST: Update settings should go through cluster state (#29682)
  Add additional shards routing info in ShardSearchRequest (#29533)
  Reinstate missing documentation (#28781)
  Clarify documentation of scroll_id (#29424)
  Fixes Eclipse build for sql jdbc project (#30114)
  Watcher: Fold two smoke test projects into smoke-test-watcher (#30137)
dnhatn added a commit that referenced this pull request Apr 27, 2018
@dnhatn
Merge branch 'master' into ccr
112b5f1 
* master: (24 commits)
  Watcher: Ensure mail message ids are unique per watch action (#30112)
  REST: Remove GET support for clear cache indices (#29525)
  SQL: Correct error message (#30138)
  Require acknowledgement to start_trial license (#30135)
  Fix a bug in FieldCapabilitiesRequest#equals and hashCode. (#30181)
  SQL: Add BinaryMathProcessor to named writeables list (#30127)
  Tests: Use buildDir as base for generated-resources (#30191)
  Fix SliceBuilderTests#testRandom failures
  Build: Fix deb version to use tilde with prerelease versions (#29000)
  Fix edge cases in CompositeKeyExtractorTests (#30175)
  Document time unit limitations for date histograms (#30177)
  Add support for field capabilities to the high-level REST client. (#29664)
  Remove licenses missed by the migration (#30128)
  [DOCS] Updates docker installation package details (#30110)
  Fix TermsSetQueryBuilder.doEquals() method (#29629)
  [Monitoring] Remove unhelpful Monitoring tests (#30144)
  [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655)
  add copyright/scope configuration for intellij to Contributing Guide (#29688)
  [test] include oss tar in packaging tests (#30155)
  TEST: Update settings should go through cluster state (#29682)
  ...
@bleskes bleskes added v6.3.0 and removed v6.3.1 labels May 1, 2018
@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

@cbuescher cbuescher

Labels
>bug :Search/Search Search-related issues that do not fall into other categories v6.3.0 v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlrx @elasticmachine @cbuescher @colings86 @bleskes