Fix edge cases in CompositeKeyExtractorTests #30175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the test picks random java.util.TimeZone ids in some places. Internally we still need to convert back to joda DateTimeZone by id occassionally (e.g. when serializing to pre 6.3 versions). There are some deprecated "SystemV/*" time zones that Jodas DateTimeZone refuses to convert. This change excludes those rare cases from the set of allowed random time zones. It would be quiet odd for them to appear in practice. Closes elastic#30156
cbuescher
added
>test
|
Pinging @elastic/es-search-aggs |
|
@dakrone could you take a look please since you seem to have moved the class to java.util.TimeZone. |
|
LGTM |
|
@costin the issue mentions this test failing on 6.3 as well. Should the fix also be backported there or did you remove the 6.3 label for a specific reason? |
cbuescher
pushed a commit
that referenced
this pull request
Apr 26, 2018
Currently the test picks random java.util.TimeZone ids in some places. Internally we still need to convert back to joda DateTimeZone by id occassionally (e.g. when serializing to pre 6.3 versions). There are some deprecated "SystemV/*" time zones that Jodas DateTimeZone refuses to convert. This change excludes those rare cases from the set of allowed random time zones. It would be quiet odd for them to appear in practice. Closes #30156
|
@cbuescher it should be ported to 6.3 - I'll take care of it. The label was removed by mistake because the BC was cut, once I'll commit I'll add 6.3.1 to it. |
costin
pushed a commit
that referenced
this pull request
Apr 26, 2018
Currently the test picks random java.util.TimeZone ids in some places. Internally we still need to convert back to joda DateTimeZone by id occassionally (e.g. when serializing to pre 6.3 versions). There are some deprecated "SystemV/*" time zones that Jodas DateTimeZone refuses to convert. This change excludes those rare cases from the set of allowed random time zones. It would be quiet odd for them to appear in practice. Closes #30156
|
Backported to 6.3 through 982f7d7 Thanks again for looking into this! |
dnhatn
added a commit
that referenced
this pull request
Apr 27, 2018
* 6.x: Watcher: Ensure mail message ids are unique per watch action (#30112) SQL: Correct error message (#30138) SQL: Add BinaryMathProcessor to named writeables list (#30127) Tests: Use buildDir as base for generated-resources (#30191) Fix SliceBuilderTests#testRandom failures Fix edge cases in CompositeKeyExtractorTests (#30175) Document time unit limitations for date histograms (#30177) Remove licenses missed by the migration [DOCS] Updates docker installation package details (#30110) Fix TermsSetQueryBuilder.doEquals() method (#29629) [Monitoring] Remove unhelpful Monitoring tests (#30144) [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655) [test] include oss tar in packaging tests (#30155) TEST: Update settings should go through cluster state (#29682) Add additional shards routing info in ShardSearchRequest (#29533) Reinstate missing documentation (#28781) Clarify documentation of scroll_id (#29424) Fixes Eclipse build for sql jdbc project (#30114) Watcher: Fold two smoke test projects into smoke-test-watcher (#30137)
dnhatn
added a commit
that referenced
this pull request
Apr 27, 2018
* master: (24 commits) Watcher: Ensure mail message ids are unique per watch action (#30112) REST: Remove GET support for clear cache indices (#29525) SQL: Correct error message (#30138) Require acknowledgement to start_trial license (#30135) Fix a bug in FieldCapabilitiesRequest#equals and hashCode. (#30181) SQL: Add BinaryMathProcessor to named writeables list (#30127) Tests: Use buildDir as base for generated-resources (#30191) Fix SliceBuilderTests#testRandom failures Build: Fix deb version to use tilde with prerelease versions (#29000) Fix edge cases in CompositeKeyExtractorTests (#30175) Document time unit limitations for date histograms (#30177) Add support for field capabilities to the high-level REST client. (#29664) Remove licenses missed by the migration (#30128) [DOCS] Updates docker installation package details (#30110) Fix TermsSetQueryBuilder.doEquals() method (#29629) [Monitoring] Remove unhelpful Monitoring tests (#30144) [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655) add copyright/scope configuration for intellij to Contributing Guide (#29688) [test] include oss tar in packaging tests (#30155) TEST: Update settings should go through cluster state (#29682) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test picks random java.util.TimeZone ids in some places.
Internally we still need to convert back to joda DateTimeZone by id
occassionally (e.g. when serializing to pre 6.3 versions). There are
some deprecated "SystemV/*" time zones that Jodas DateTimeZone refuses
to convert. This change excludes those rare cases from the set of
allowed random time zones. It would be quiet odd for them to appear in
practice.
Closes #30156