Fixes Eclipse build for sql jdbc project #30114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundled configuration isn't recognised by eclipse so these dependencies are missed when it imports the `x-pack:plugin:sql:jdbc` project. This change makes these dependencies compile dependencies if the build is running for Eclipse.
colings86
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
jpountz
approved these changes
Apr 25, 2018
|
Works for me as well. |
|
run sample packaging tests |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 25, 2018
* master: [Test] Fix docs check for DEB package in packaging tests (elastic#30126) Painless: Docs Clean Up (elastic#29592) Fixes Eclipse build for sql jdbc project (elastic#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (elastic#29612) Remove the suggest metric from stats APIs (elastic#29635) Fix byte size value equals/hash code test (elastic#29643) Upgrade to Gradle 4.7 (elastic#29644)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 25, 2018
* master: [Test] Fix docs check for DEB package in packaging tests (elastic#30126) Painless: Docs Clean Up (elastic#29592) Fixes Eclipse build for sql jdbc project (elastic#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (elastic#29612) Remove the suggest metric from stats APIs (elastic#29635) Fix byte size value equals/hash code test (elastic#29643) Upgrade to Gradle 4.7 (elastic#29644)
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/master: Watcher: Fold two smoke test projects into smoke-test-watcher (#30137) In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) [Test] Fix docs check for DEB package in packaging tests (#30126) Painless: Docs Clean Up (#29592) Fixes Eclipse build for sql jdbc project (#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612)
colings86
added a commit
that referenced
this pull request
Apr 26, 2018
The bundled configuration isn't recognised by eclipse so these dependencies are missed when it imports the `x-pack:plugin:sql:jdbc` project. This change makes these dependencies compile dependencies if the build is running for Eclipse.
colings86
added a commit
that referenced
this pull request
Apr 26, 2018
The bundled configuration isn't recognised by eclipse so these dependencies are missed when it imports the `x-pack:plugin:sql:jdbc` project. This change makes these dependencies compile dependencies if the build is running for Eclipse.
|
Merged to master and backported to 6.x and 6.3 branches |
dnhatn
added a commit
that referenced
this pull request
Apr 27, 2018
* 6.x: Watcher: Ensure mail message ids are unique per watch action (#30112) SQL: Correct error message (#30138) SQL: Add BinaryMathProcessor to named writeables list (#30127) Tests: Use buildDir as base for generated-resources (#30191) Fix SliceBuilderTests#testRandom failures Fix edge cases in CompositeKeyExtractorTests (#30175) Document time unit limitations for date histograms (#30177) Remove licenses missed by the migration [DOCS] Updates docker installation package details (#30110) Fix TermsSetQueryBuilder.doEquals() method (#29629) [Monitoring] Remove unhelpful Monitoring tests (#30144) [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655) [test] include oss tar in packaging tests (#30155) TEST: Update settings should go through cluster state (#29682) Add additional shards routing info in ShardSearchRequest (#29533) Reinstate missing documentation (#28781) Clarify documentation of scroll_id (#29424) Fixes Eclipse build for sql jdbc project (#30114) Watcher: Fold two smoke test projects into smoke-test-watcher (#30137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundled configuration isn't recognised by eclipse so these
dependencies are missed when it imports the
x-pack:plugin:sql:jdbcproject. This change makes these dependencies compile dependencies if
the build is running for Eclipse.