gitignore: Add VSCode and remove Maven #30145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `.vscode` directory to `.gitignore`. This didn't come up when we had x-pack in a different repository than Elasticsearch because I'd open the directory that contained both of them in VSCode. Now that they are merged I tend to just open the Elasticsearch repository which causes VSCode to create this directory that we don't need to commit. Also removes leftover maven files from `.gitignore`.
nik9000
added
>non-issue
review
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
LGTM |
jasontedor
approved these changes
Apr 26, 2018
| *-execution-hints.log | ||
| target/ | ||
| dependency-reduced-pom.xml | ||
| # vscode stuff |
There was a problem hiding this comment.
Does the comment add anything right now?
There was a problem hiding this comment.
It is fairly obvious what the line is for but all the other groups of lines have a comment so I figured I'd play along.
There was a problem hiding this comment.
Okay, I am fine with when in Rome....
nik9000
added a commit
that referenced
this pull request
Apr 26, 2018
Adds the `.vscode` directory to `.gitignore`. This didn't come up when we had x-pack in a different repository than Elasticsearch because I'd open the directory that contained both of them in VSCode. Now that they are merged I tend to just open the Elasticsearch repository which causes VSCode to create this directory that we don't need to commit. Also removes leftover maven files from `.gitignore`.
nik9000
added a commit
that referenced
this pull request
Apr 26, 2018
Adds the `.vscode` directory to `.gitignore`. This didn't come up when we had x-pack in a different repository than Elasticsearch because I'd open the directory that contained both of them in VSCode. Now that they are merged I tend to just open the Elasticsearch repository which causes VSCode to create this directory that we don't need to commit. Also removes leftover maven files from `.gitignore`.
|
Thanks for reviewing @rjernst and @jasontedor! |
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/master: Watcher: Fold two smoke test projects into smoke-test-watcher (#30137) In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) [Test] Fix docs check for DEB package in packaging tests (#30126) Painless: Docs Clean Up (#29592) Fixes Eclipse build for sql jdbc project (#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612)
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/6.x: In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Painless: Docs Clean Up (#29592) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) AwaitsFix for testGradleVersionsMatchVersionUtils [Test] Fix docs check for DEB package in packaging tests (#30126) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612) [DOCS] Removed differencies between text and code (#27993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
.vscodedirectory to.gitignore. This didn't come up whenwe had x-pack in a different repository than Elasticsearch because I'd
open the directory that contained both of them in VSCode. Now that they
are merged I tend to just open the Elasticsearch repository which causes
VSCode to create this directory that we don't need to commit.
Also removes leftover maven files from
.gitignore.