Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct transport compression algorithm in docs #29645

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Correct transport compression algorithm in docs #29645

merged 1 commit into from
Apr 25, 2018

Conversation

jasontedor
Copy link
Member

We use DEFLATE when compressing byte streams on the transport layer yet the docs say we use LZF. This commit correct this.

@jasontedor
Correct transport compression algorithm in docs
c8de9ed 
We use DEFLATE when compressing byte streams on the transport layer yet
the docs say we use LZF. This commit correct this.
@jasontedor
Copy link
Member Author

jasontedor commented Apr 21, 2018 •
edited
Loading

You can trace this from TcpTransport:

elasticsearch/server/src/main/java/org/elasticsearch/transport/TcpTransport.java

Line 1082 in c8de9ed

final CompressibleBytesOutputStream stream = new CompressibleBytesOutputStream(bStream, compressMessage);

and

elasticsearch/server/src/main/java/org/elasticsearch/transport/TcpTransport.java

Line 1170 in c8de9ed

CompressibleBytesOutputStream stream = new CompressibleBytesOutputStream(bStream, options.compress());

To CompressibleBytesOutputStream:

elasticsearch/server/src/main/java/org/elasticsearch/transport/CompressibleBytesOutputStream.java

Line 56 in c8de9ed

this.stream = CompressorFactory.COMPRESSOR.streamOutput(Streams.flushOnCloseStream(bytesStreamOutput));

To CompressorFactory:

elasticsearch/server/src/main/java/org/elasticsearch/common/compress/CompressorFactory.java

Line 35 in c8de9ed

public static final Compressor COMPRESSOR = new DeflateCompressor();

rjernst
rjernst approved these changes Apr 21, 2018
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor
Copy link
Member Author

run the sample packaging tests

@colings86 colings86 added the :Core/Infra/Transport API Transport client API label Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@colings86 colings86 added the >docs General docs changes label Apr 24, 2018
@jasontedor jasontedor merged commit a103533 into elastic:master Apr 25, 2018
jasontedor added a commit that referenced this pull request Apr 25, 2018
@jasontedor
Correct transport compression algorithm in docs (#29645)
b06b9e4 
We use DEFLATE when compressing byte streams on the transport layer yet
the docs say we use LZF. This commit correct this.
jasontedor added a commit that referenced this pull request Apr 25, 2018
@jasontedor
Correct transport compression algorithm in docs (#29645)
72ade04 
We use DEFLATE when compressing byte streams on the transport layer yet
the docs say we use LZF. This commit correct this.
jasontedor added a commit that referenced this pull request Apr 25, 2018
@jasontedor
Correct transport compression algorithm in docs (#29645)
626e3a5 
We use DEFLATE when compressing byte streams on the transport layer yet
the docs say we use LZF. This commit correct this.
@jasontedor jasontedor deleted the correct-transport-compression branch April 25, 2018 19:52
jasontedor added a commit that referenced this pull request Apr 25, 2018
@jasontedor
Correct transport compression algorithm in docs (#29645)
1c1a370 
We use DEFLATE when compressing byte streams on the transport layer yet
the docs say we use LZF. This commit correct this.
martijnvg added a commit that referenced this pull request Apr 26, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
4bcecd3 
* es/master:
  Watcher: Fold two smoke test projects into smoke-test-watcher (#30137)
  In the field capabilities API, deprecate support for providing fields in the request body. (#30157)
  Set JAVA_HOME before forking setup commands (#29647)
  Remove animal sniffer from low-level REST client (#29646)
  Cleanup .gitignore (#30145)
  Do not add noop from local translog to translog again (#29637)
  Build: Assert jar LICENSE and NOTICE files match
  Correct transport compression algorithm in docs (#29645)
  [Test] Fix docs check for DEB package in packaging tests (#30126)
  Painless: Docs Clean Up (#29592)
  Fixes Eclipse build for sql jdbc project (#30114)
  Remove reference to `not_analyzed`.
  [Docs] Add community analysis plugin (#29612)
martijnvg added a commit that referenced this pull request Apr 26, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
950ddc3 
* es/6.x:
  In the field capabilities API, deprecate support for providing fields in the request body. (#30157)
  Set JAVA_HOME before forking setup commands (#29647)
  Remove animal sniffer from low-level REST client (#29646)
  Cleanup .gitignore (#30145)
  Do not add noop from local translog to translog again (#29637)
  Painless: Docs Clean Up (#29592)
  Build: Assert jar LICENSE and NOTICE files match
  Correct transport compression algorithm in docs (#29645)
  AwaitsFix for testGradleVersionsMatchVersionUtils
  [Test] Fix docs check for DEB package in packaging tests (#30126)
  Remove reference to `not_analyzed`.
  [Docs] Add community analysis plugin (#29612)
  [DOCS] Removed differencies between text and code (#27993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Transport API Transport client API >docs General docs changes v5.6.10 v6.2.5 v6.3.0 v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasontedor @elasticmachine @rjernst @colings86