Remove animal sniffer from low-level REST client #29646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The low-level REST client targets JDK 7. To avoid compiling against JDK functionality not available in JDK 7, we use animal sniffer. However, when we switched to using the JDK 9 and now the JDK 10 compiler which has built-in support for targeting previous JDKs, we no longer need to use animal sniffer. This is because the JDK is now packaged with the signatures needed to ensure that when we target JDK 7 at compile-time it is detected that we are only using JDK 7 functionality. This commit removes the use of animal sniffer from the low-level REST client build.
|
Here are the compiler arguments that we use today when building the low-level REST client: The relevant component here is the |
nik9000
approved these changes
Apr 23, 2018
colings86
added
>test
|
Pinging @elastic/es-core-infra |
* master: (7067 commits) Add 6.4.0 version to master (elastic#29684) Add comments inadvertently removed during migrate [ML] Wait for updates to established memory usage Add build time checks for package licenses Build: Fix License attribute to be written in deb control data Build: Use templated copyright file for deb distributions Fix the dashes in license names Only enable modules to have native controllers Fix SQL CLI on Windows Add distribution type to startup scripts Fix classpath for X-Pack scripts on Windows Rename syskeygen Rename users Rename migrate Rename saml-metadata Rename sql-cli Rename croneval Rename setup-passwords Rename certutil Rename certgen ...
|
test this please |
|
run gradle build tests |
|
test this please |
* master: [Test] Fix docs check for DEB package in packaging tests (elastic#30126) Painless: Docs Clean Up (elastic#29592) Fixes Eclipse build for sql jdbc project (elastic#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (elastic#29612) Remove the suggest metric from stats APIs (elastic#29635) Fix byte size value equals/hash code test (elastic#29643) Upgrade to Gradle 4.7 (elastic#29644)
jasontedor
added a commit
that referenced
this pull request
Apr 26, 2018
The low-level REST client targets JDK 7. To avoid compiling against JDK functionality not available in JDK 7, we use animal sniffer. However, when we switched to using the JDK 9 and now the JDK 10 compiler which has built-in support for targeting previous JDKs, we no longer need to use animal sniffer. This is because the JDK is now packaged with the signatures needed to ensure that when we target JDK 7 at compile-time it is detected that we are only using JDK 7 functionality. This commit removes the use of animal sniffer from the low-level REST client build.
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/master: Watcher: Fold two smoke test projects into smoke-test-watcher (#30137) In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) [Test] Fix docs check for DEB package in packaging tests (#30126) Painless: Docs Clean Up (#29592) Fixes Eclipse build for sql jdbc project (#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612)
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/6.x: In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Painless: Docs Clean Up (#29592) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) AwaitsFix for testGradleVersionsMatchVersionUtils [Test] Fix docs check for DEB package in packaging tests (#30126) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612) [DOCS] Removed differencies between text and code (#27993)
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Apr 30, 2018
Animal sniffer is no longer needed, we can remove it for sniffer like we did for the low-level REST client with elastic#29646
javanna
added a commit
that referenced
this pull request
May 1, 2018
Animal sniffer is no longer needed, we can remove it for sniffer like we did for the low-level REST client with #29646
javanna
added a commit
that referenced
this pull request
May 1, 2018
Animal sniffer is no longer needed, we can remove it for sniffer like we did for the low-level REST client with #29646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The low-level REST client targets JDK 7. To avoid compiling against JDK functionality not available in JDK 7, we use animal sniffer. However, when we switched to using the JDK 9 and now the JDK 10 compiler which has built-in support for targeting previous JDKs, we no longer need to use animal sniffer. This is because the JDK is now packaged with the signatures needed to ensure that when we target JDK 7 at compile-time it is detected that we are only using JDK 7 functionality. This commit removes the use of animal sniffer from the low-level REST client build.