-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Correlations Beta #86477
Comments
Pinging @elastic/apm-ui (Team:apm) |
@sqren @nehaduggal Updated the list of changes and additions to the feature. |
@sqren @nehaduggal I made some changes above to separate things from new additions to changes and a specific portion around the fields customization, which I wasn't sure how we imagine we want to implement further. Please when you have time if you can provide some feedback on this. |
Updated the issue description with a decision on the fields customization, which we'll make local storage enabled per user session. This is the most practical and essential saving of the fields we can imagine would be useful for the first iteration. We might reconsider when spaces also become user profile specific, which will enable users per space to define the fields. We might also get other feedback from users once the feature is released, so we should keep an eye out for that. |
We should also take this opportunity to rename files, components, and data type to reflect the current feature name "Correlations" instead of the old feature name "Significant terms" (#89028) |
@ogupte I added a new section "Technical" with some more items. LMK if you have questions about it. |
@ogupte I've added another task to add the "Explore correlations" button to invoke the flyout to the Service overview page as well ^ cc @sqren @nehaduggal |
@ogupte @nehaduggal Added some quick descriptions for each section in the flyouts to describe what use each of them are to the investigation. Let me know if you have any improvements to the copy? I wanted to keep a similar theme to them. |
* [APM] Correlations GA (#86477) * polish and improvements to correlations UI * more improvements and polish * added impact bar * added descriptions * make custom field persistence be unique per service * make custom threshold unique per service in latency correlations * adds telemetry for apm correlations feature. Events: - 'show_correlations_flyout' - 'customize_correlations_fields' - 'select_significant_term' * adds more telemetry for correlations (#90622) * removes the raw score column * replaces experiemental callout with beta badge * replaces threshold number input with percentile option selector * improvements to latency correlations scoring and percentage reporting * removes the 'apm:enableCorrelations' UI setting * - rename useFieldNames.ts -> use_field_names.ts - filter out fields that are not type 'keyword' - feedback improvements * Fixes casing issue for the 'correlations' dir * [APM] Moves correlations button to service details tabslist row (#91080) * [APM] Adds license check for correlations (#90766) * [APM] Adds metrics tracking for correlations views and license prompts (#90622) * Updated the API integration tests to check for new default fields and 15 buckets Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [APM] Correlations GA (elastic#86477) * polish and improvements to correlations UI * more improvements and polish * added impact bar * added descriptions * make custom field persistence be unique per service * make custom threshold unique per service in latency correlations * adds telemetry for apm correlations feature. Events: - 'show_correlations_flyout' - 'customize_correlations_fields' - 'select_significant_term' * adds more telemetry for correlations (elastic#90622) * removes the raw score column * replaces experiemental callout with beta badge * replaces threshold number input with percentile option selector * improvements to latency correlations scoring and percentage reporting * removes the 'apm:enableCorrelations' UI setting * - rename useFieldNames.ts -> use_field_names.ts - filter out fields that are not type 'keyword' - feedback improvements * Fixes casing issue for the 'correlations' dir * [APM] Moves correlations button to service details tabslist row (elastic#91080) * [APM] Adds license check for correlations (elastic#90766) * [APM] Adds metrics tracking for correlations views and license prompts (elastic#90622) * Updated the API integration tests to check for new default fields and 15 buckets Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [APM] Correlations GA (#86477) * polish and improvements to correlations UI * more improvements and polish * added impact bar * added descriptions * make custom field persistence be unique per service * make custom threshold unique per service in latency correlations * adds telemetry for apm correlations feature. Events: - 'show_correlations_flyout' - 'customize_correlations_fields' - 'select_significant_term' * adds more telemetry for correlations (#90622) * removes the raw score column * replaces experiemental callout with beta badge * replaces threshold number input with percentile option selector * improvements to latency correlations scoring and percentage reporting * removes the 'apm:enableCorrelations' UI setting * - rename useFieldNames.ts -> use_field_names.ts - filter out fields that are not type 'keyword' - feedback improvements * Fixes casing issue for the 'correlations' dir * [APM] Moves correlations button to service details tabslist row (#91080) * [APM] Adds license check for correlations (#90766) * [APM] Adds metrics tracking for correlations views and license prompts (#90622) * Updated the API integration tests to check for new default fields and 15 buckets Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* master: (157 commits) [DOCS] Adds machine learning to the security section of alerting (elastic#91501) [Uptime] Ping list step screenshot caption formatting (elastic#91403) [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483) [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464) Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194) [APM] Wrap Elasticsearch client errors (elastic#91125) [APM] Fix optimize-tsconfig script (elastic#91487) [Discover][docs] Add searchFieldsFromSource description (elastic#90980) Adds support for 'ip' data type (elastic#85087) [Detection Rules] Add updates from 7.11.2 rules (elastic#91553) [SECURITY SOLUTION] Eql in timeline (elastic#90816) [APM] Correlations Beta (elastic#86477) (elastic#89952) [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258) [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446) skip flaky suite (elastic#91450) skip flaky suite (elastic#91592) [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870) [ML] Add better UI support for runtime fields Transforms (elastic#90363) [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167) [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260) ...
Summary
Related design issue elastic/apm#302
Design solution
Kapture.2020-12-22.at.20.56.53.mp4
Testing
Technical
labels
service.version
service.node.name
host.ip
labels
user_agent.name
user_agent.os.name
url.original, user fields
Design
xxs
)visTagCloud
(new icon pending)euiColorAccent
as opposed to the existingred
.default
and drop the code font change. Also, add proper unit formatting.Section descriptions copy
Latency
Errors
Throughput
Saving field customization
Update We've decided to go with a local storage approach to keep the customized fields per session for the user. We might reconsider once per-user settings are enabled on spaces (#21640) that will enable even more control per user. Also, we'll keep an eye out for feedback we get from users. I've removed the task around saving fields, as they will be saved automatically in local storage.
View examples
The text was updated successfully, but these errors were encountered: