Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): introduce preset for jest-integration tests on @kbn/test #105144

Merged
merged 8 commits into from
Jul 14, 2021
Merged

chore(NA): introduce preset for jest-integration tests on @kbn/test #105144

merged 8 commits into from
Jul 14, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jul 9, 2021 •
edited
Loading

That PR creates a new and separate preset for the jest integration tests instead of just inherit and override in the global configuration.

@mistic mistic added auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.15.0 v8.0.0 labels Jul 9, 2021
@mistic mistic marked this pull request as ready for review July 9, 2021 22:31
@mistic mistic requested review from a team as code owners July 9, 2021 22:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

spalger
spalger approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to fix the underlying problem of the junit reporter getting the wrong REPO_ROOT and not writing the junit file in the right place (results from failure), though it's still not clear why it works or why the @elastic/kibana-core tests needed to be updated. We should figure out what caused that before merging.

mshustov
mshustov reviewed Jul 12, 2021
View reviewed changes
src/dev/precommit_hook/casing_check_config.js
@@ -40,6 +40,7 @@ export const IGNORE_FILE_GLOBS = [
'vars/*',
'.ci/pipeline-library/**/*',
'packages/kbn-test/jest-preset.js',
'packages/kbn-test/jest_integration/jest-preset.js',
Copy link
Contributor

@mshustov mshustov Jul 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use jest_preset? Is it a limitation of jest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshustov jest doesn't allow us to configurate wether to make or not the workers to follow symlinks (except in places where we can use a custom resolver, so mostly within test code). Therefore we discover that if we keep the reporters config hold inside the @kbn/test package other than overridden outside, we are able to keep the preserve symlink option set in the parent process and correctly discover the output folder for the reports on the CI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he's asking specifically about the use of kebab-case instead of camel_case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thanks @spalger , reading it a second time make that clear. Yeah it is a jest limitation, it will always look for a jest-preset.* file. More info at https://jestjs.io/docs/configuration#preset-string

@mistic
Copy link
Member Author

mistic commented Jul 12, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jul 12, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jul 13, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 977039c into elastic:master Jul 14, 2021
@spalger spalger mentioned this pull request Jul 14, 2021
Closed
@kibanamachine kibanamachine mentioned this pull request Jul 14, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2021
@mistic @mshustov @kibanamachine
chore(NA): introduce preset for jest-integration tests on @kbn/test (e…
b53ec7a 
…lastic#105144)

* chore(NA): introduce preset for jest-integration tests on @kbn/test

* chore(NA): fix lockfile

* chore(NA): fix ci

* fix tests (elastic#14)

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 14, 2021
@kibanamachine @mistic @mshustov
chore(NA): introduce preset for jest-integration tests on @kbn/test (#…
7ef09fc 
…105144) (#105667)

* chore(NA): introduce preset for jest-integration tests on @kbn/test

* chore(NA): fix lockfile

* chore(NA): fix ci

* fix tests (#14)

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 15, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/new…
cec3989 
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (75 commits)
  [Search Sessions] Don’t try to delete errored searches (elastic#105434)
  [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407)
  [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592)
  [ML] Functional tests - re-activate a11y tests (elastic#105198)
  [APM] Typed client-side routing (elastic#104274)
  [Canvas] Expression error (elastic#103048)
  [ML] Fixing job wizard with missing description (elastic#105574)
  [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505)
  Upgrade EUI to v35.0.0 (elastic#105127)
  [Reporting] Clean up types for internal APIs needed for UI (elastic#105508)
  skip flaky suite (elastic#105087)
  [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680)
  [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669)
  [ML] Add api integration test for analytics map endpoint  (elastic#105531)
  Fixes cypress flake across two tests (elastic#105645)
  [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580)
  chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144)
  [Enterprise Search] Added Thumbnails to Search UI (elastic#104199)
  Translate App Search credentials list (elastic#105619)
  [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
brianseeders pushed a commit to brianseeders/kibana that referenced this pull request Sep 22, 2021
@mistic @mshustov
@kibanamachine @brianseeders
chore(NA): introduce preset for jest-integration tests on @kbn/test (e…
a0e9e85 
…lastic#105144)

* chore(NA): introduce preset for jest-integration tests on @kbn/test

* chore(NA): fix lockfile

* chore(NA): fix ci

* fix tests (#14)

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@brianseeders brianseeders mentioned this pull request Sep 22, 2021
Merged
brianseeders added a commit that referenced this pull request Sep 22, 2021
@brianseeders @mistic
@mshustov @kibanamachine
chore(NA): introduce preset for jest-integration tests on @kbn/test (#…
0a5c022 
…105144) (#112769)

* chore(NA): introduce preset for jest-integration tests on @kbn/test

* chore(NA): fix lockfile

* chore(NA): fix ci

* fix tests (#14)

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet left review comments

@spalger spalger spalger approved these changes

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mistic @elasticmachine @kibanamachine @spalger @pgayvallet @mshustov