-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add api integration test for analytics map endpoint #105531
[ML] Add api integration test for analytics map endpoint #105531
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see these tests coming 🎉
Left a few suggestions.
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/apis/ml/data_frame_analytics/get_spaces.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM 🎉 |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…105685) * adds api integration test for analytics map endpoint in spaces * wrap request code in function * check error value and add messaging Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (75 commits) [Search Sessions] Don’t try to delete errored searches (elastic#105434) [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407) [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592) [ML] Functional tests - re-activate a11y tests (elastic#105198) [APM] Typed client-side routing (elastic#104274) [Canvas] Expression error (elastic#103048) [ML] Fixing job wizard with missing description (elastic#105574) [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505) Upgrade EUI to v35.0.0 (elastic#105127) [Reporting] Clean up types for internal APIs needed for UI (elastic#105508) skip flaky suite (elastic#105087) [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680) [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669) [ML] Add api integration test for analytics map endpoint (elastic#105531) Fixes cypress flake across two tests (elastic#105645) [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580) chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144) [Enterprise Search] Added Thumbnails to Search UI (elastic#104199) Translate App Search credentials list (elastic#105619) [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts # x-pack/plugins/reporting/public/management/report_listing.test.tsx
Summary
Related meta issue: #97982
Adds test for
GET /data_frame/analytics/map/{id}
with spacesChecklist
Delete any items that are not applicable to this PR.