Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - re-activate a11y tests #105198

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jul 12, 2021

Summary

This PR re-activates the ML a11y test suite with data loaded.

Closes #103538

@pheyos
Copy link
Member Author

pheyos commented Jul 12, 2021

Checking test stability in flaky test runner jobs:

  • 1708 ... no failure in 50 runs ✔️
  • 1710 ... no failure in 50 runs ✔️
  • 1712 ... no failure in 50 runs ✔️
  • 1714 ... no failure in 50 runs ✔️
  • 1719 ... no failure in 100 runs ✔️
  • 1722 ... no failure in 100 runs ✔️

Summary: no test failure in 400 runs ✔️

@pheyos
Copy link
Member Author

pheyos commented Jul 15, 2021

@elasticmachine merge upstream

@pheyos pheyos added 7.14.0 v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 15, 2021
@pheyos pheyos marked this pull request as ready for review July 15, 2021 10:06
@pheyos pheyos requested a review from a team as a code owner July 15, 2021 10:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos requested a review from peteharverson July 15, 2021 10:07
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 15, 2021
@pheyos pheyos merged commit 79c4126 into elastic:master Jul 15, 2021
@pheyos pheyos deleted the reactivate_a11y_tests branch July 15, 2021 10:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2021
This PR re-activates the ML a11y test suite `with data loaded`.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 15, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (75 commits)
  [Search Sessions] Don’t try to delete errored searches (elastic#105434)
  [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407)
  [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592)
  [ML] Functional tests - re-activate a11y tests (elastic#105198)
  [APM] Typed client-side routing (elastic#104274)
  [Canvas] Expression error (elastic#103048)
  [ML] Fixing job wizard with missing description (elastic#105574)
  [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505)
  Upgrade EUI to v35.0.0 (elastic#105127)
  [Reporting] Clean up types for internal APIs needed for UI (elastic#105508)
  skip flaky suite (elastic#105087)
  [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680)
  [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669)
  [ML] Add api integration test for analytics map endpoint  (elastic#105531)
  Fixes cypress flake across two tests (elastic#105645)
  [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580)
  chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144)
  [Enterprise Search] Added Thumbnails to Search UI (elastic#104199)
  Translate App Search credentials list (elastic#105619)
  [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
kibanamachine added a commit that referenced this pull request Jul 15, 2021
This PR re-activates the ML a11y test suite `with data loaded`.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
@pheyos pheyos added v7.14.0 and removed 7.14.0 labels Jul 15, 2021
pheyos added a commit to pheyos/kibana that referenced this pull request Jul 15, 2021
This PR re-activates the ML a11y test suite `with data loaded`.
pheyos added a commit that referenced this pull request Jul 15, 2021
This PR re-activates the ML a11y test suite `with data loaded`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.14.0 v7.15.0 v8.0.0
Projects
None yet
4 participants