Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Alerts] - Add alerts subfeature UI #105505

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jul 13, 2021

Summary

This PR adds the subfeature UI for alerts to security solution. Note that the ability to customize subfeatures is still a gold feature. How will this map with existing users? The feature and subfeature are tied. So if a user was previously assinged All for security solution - they would get all for alerts, etc.

It still remains behind a feature flag, so to see the change you'll need to have the following in your kibana.dev.yml

xpack.securitySolution.enableExperimental: ['ruleRegistryEnabled']
xpack.ruleRegistry.write.enabled: true

Screen Shot 2021-07-13 at 12 08 19 PM

Otherwise you'll just see:

Screen Shot 2021-07-13 at 1 37 17 PM

Allows for the following combos, some of these combos may not make much sense, however we are not restricting it:
Screen Shot 2021-07-13 at 12 10 43 PM

Checklist

Delete any items that are not applicable to this PR.

@yctercero yctercero requested a review from a team as a code owner July 13, 2021 20:29
@yctercero yctercero self-assigned this Jul 13, 2021
@yctercero yctercero added release_note:enhancement v7.15.0 v8.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team labels Jul 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

What I did:

  • Looked it over for obvious mistakes

What I didn't do:

  • I did not pull it down and run it and test it manually.

@yctercero yctercero enabled auto-merge (squash) July 13, 2021 23:27
@yctercero yctercero added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 13, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit d43551c into elastic:master Jul 15, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2021
###Summary
This PR adds the subfeature UI for alerts to security solution. Note that the ability to customize subfeatures is still a gold feature. How will this map with existing users? The feature and subfeature are tied. So if a user was previously assinged All for security solution - they would get all for alerts, etc.

It still remains behind a feature flag, so to see the change you'll need to have the following in your kibana.dev.yml

xpack.securitySolution.enableExperimental: ['ruleRegistryEnabled']
xpack.ruleRegistry.write.enabled: true
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 15, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (75 commits)
  [Search Sessions] Don’t try to delete errored searches (elastic#105434)
  [Search Sessions] fix saved object can be created even if courier:batchSearches is enabled (elastic#105407)
  [Remote Clusters] Fixed remote clusters details flyout for long strings (elastic#105592)
  [ML] Functional tests - re-activate a11y tests (elastic#105198)
  [APM] Typed client-side routing (elastic#104274)
  [Canvas] Expression error (elastic#103048)
  [ML] Fixing job wizard with missing description (elastic#105574)
  [Security Solution][Alerts] - Add alerts subfeature UI (elastic#105505)
  Upgrade EUI to v35.0.0 (elastic#105127)
  [Reporting] Clean up types for internal APIs needed for UI (elastic#105508)
  skip flaky suite (elastic#105087)
  [Workplace Search] Fix Chrome issues with GitHub sources (elastic#105680)
  [Fleet] Add containerized fleet server instructions to Fleet README (elastic#105669)
  [ML] Add api integration test for analytics map endpoint  (elastic#105531)
  Fixes cypress flake across two tests (elastic#105645)
  [Logs&Metrics UI] add owner properties to plugin manifest (elastic#105580)
  chore(NA): introduce preset for jest-integration tests on @kbn/test (elastic#105144)
  [Enterprise Search] Added Thumbnails to Search UI (elastic#104199)
  Translate App Search credentials list (elastic#105619)
  [APM] APM agent config created prior to Fleet migration is not injected into integration policy (elastic#105504)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/types.ts
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 19, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 20, 2021
kibanamachine added a commit that referenced this pull request Jul 20, 2021
…5703)

###Summary
This PR adds the subfeature UI for alerts to security solution. Note that the ability to customize subfeatures is still a gold feature. How will this map with existing users? The feature and subfeature are tied. So if a user was previously assinged All for security solution - they would get all for alerts, etc.

It still remains behind a feature flag, so to see the change you'll need to have the following in your kibana.dev.yml

xpack.securitySolution.enableExperimental: ['ruleRegistryEnabled']
xpack.ruleRegistry.write.enabled: true

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
@peluja1012 peluja1012 mentioned this pull request Jul 30, 2021
13 tasks
@yctercero yctercero deleted the add_alerts_subfeature branch October 13, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants