Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added styles to make combobox list items wider for alerting flyout #61894

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Added styles to make combobox list items wider for alerting flyout #61894

merged 6 commits into from
Mar 31, 2020

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Mar 30, 2020 •
edited
Loading

Resolve #61020

img1

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 30, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner March 30, 2020 21:10
@YulNaumenko YulNaumenko self-assigned this Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko requested a review from a team as a code owner March 30, 2020 21:28
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into alerting-ui-combo…
1d0d0eb 
…box-for-index-hidden

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@YulNaumenko YulNaumenko requested a review from cchaos March 30, 2020 21:30
cchaos
cchaos reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better implementation just a few suggestions around our SASS conventions.

I'd like to have @andreadelrio do a visual review.

x-pack/plugins/triggers_actions_ui/public/common/expression_items/of.tsx Outdated Show resolved Hide resolved
...ggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.scss Outdated Show resolved Hide resolved
@cchaos cchaos requested a review from andreadelrio March 30, 2020 21:40
@andreadelrio
Copy link
Contributor

I'd like to have @andreadelrio do a visual review.

image

While this fixes the case of having very long names under the Of dropdown, when the names are not that long it kind of feels unnecessarily wide. Not sure what other alternative we'd have though.

andreadelrio
andreadelrio requested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about visuals. We might need to fix of a more robust solution for dynamic width.

x-pack/plugins/triggers_actions_ui/public/common/expression_items/of.scss Outdated Show resolved Hide resolved
andreadelrio
andreadelrio approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mikecote
mikecote approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YulNaumenko YulNaumenko merged commit 81e1dca into elastic:master Mar 31, 2020
@YulNaumenko YulNaumenko mentioned this pull request Mar 31, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 31, 2020
@YulNaumenko
Added styles to make combobox list items wider for alerting flyout (e…
14fe2b8 
…lastic#61894)

* Added styles to make combobox list items wider for alerting flyout

* Fixed width for OF expression popover

* Fixed due to comments

* Fixed due to comments

* Resized
@YulNaumenko YulNaumenko mentioned this pull request Mar 31, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 31, 2020
@YulNaumenko
Added styles to make combobox list items wider for alerting flyout (e…
a1ac45b 
…lastic#61894)

* Added styles to make combobox list items wider for alerting flyout

* Fixed width for OF expression popover

* Fixed due to comments

* Fixed due to comments

* Resized
YulNaumenko added a commit that referenced this pull request Mar 31, 2020
@YulNaumenko
Added styles to make combobox list items wider for alerting flyout (#…
3727778 
…61894) (#62008)

* Added styles to make combobox list items wider for alerting flyout

* Fixed width for OF expression popover

* Fixed due to comments

* Fixed due to comments

* Resized
YulNaumenko added a commit that referenced this pull request Mar 31, 2020
@YulNaumenko
Added styles to make combobox list items wider for alerting flyout (#…
95524bf 
…61894) (#62009)

* Added styles to make combobox list items wider for alerting flyout

* Fixed width for OF expression popover

* Fixed due to comments

* Fixed due to comments

* Resized
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 31, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerting/start-trial
2d80df2 
* upstream/master: (69 commits)
  Adding PagerDuty icon to connectors cards (elastic#60805)
  Fix drag and drop flakiness (elastic#61993)
  Grok debugger migration (elastic#60658)
  Endpoint: Fix resolver SVG position issue (elastic#61886)
  [SIEM] version 7.7 rule import (elastic#61903)
  Added styles to make combobox list items wider for alerting flyout (elastic#61894)
  [UA] Tight worker loop can cause high CPU usage (elastic#60950)
  [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709)
  [ML] Catching unknown index pattern errors (elastic#61935)
  [Discover] Deangularize and euificate sidebar  (elastic#47559)
  Endpoint: Add ts-node dev dependency (elastic#61884)
  Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901)
  [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649)
  Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171)
  [Maps] Explicitly pass fetch function to ems-client (elastic#61846)
  [SIEM][CASE] Fix aria-labels and translations (elastic#61670)
  [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842)
  [EPM] update epm filepath route (elastic#61910)
  APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732)
  [Logs UI] Log stream row rendering (elastic#60773)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 1, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
a0e1dcd 
* master: (64 commits)
  Adding PagerDuty icon to connectors cards (elastic#60805)
  Fix drag and drop flakiness (elastic#61993)
  Grok debugger migration (elastic#60658)
  Endpoint: Fix resolver SVG position issue (elastic#61886)
  [SIEM] version 7.7 rule import (elastic#61903)
  Added styles to make combobox list items wider for alerting flyout (elastic#61894)
  [UA] Tight worker loop can cause high CPU usage (elastic#60950)
  [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709)
  [ML] Catching unknown index pattern errors (elastic#61935)
  [Discover] Deangularize and euificate sidebar  (elastic#47559)
  Endpoint: Add ts-node dev dependency (elastic#61884)
  Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901)
  [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649)
  Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171)
  [Maps] Explicitly pass fetch function to ems-client (elastic#61846)
  [SIEM][CASE] Fix aria-labels and translations (elastic#61670)
  [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842)
  [EPM] update epm filepath route (elastic#61910)
  APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732)
  [Logs UI] Log stream row rendering (elastic#60773)
  ...
@mikecote mikecote added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@andreadelrio andreadelrio andreadelrio approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@YulNaumenko @elasticmachine @andreadelrio @kibanamachine @cchaos @mikecote