WRQ-10629: Removed deprecated APIs #3244

SkylerBaek · 2024-06-11T01:55:17Z

Checklist

I have read and understand the contribution guide
A CHANGELOG entry is included
At least one test case is included for this feature or bug fix
Documentation was added or is not needed
This is an API breaking change

Issue Resolved / Feature Added

As major version upgrade, deprecated APIs are removed.

Resolution

Removed deprecated APIs.

Additional Considerations

Links

WRQ-10629

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

* Removed deprecated components from enact/ui: IconButton, RadioDecorator, Scroller.ScrollerBase, SlotItem, ToggleItem, VirtualList.UiVirtualListBase, VirtualList.VirtualListBase * Removed reference to ui/SlotItem from ui/Slottable. * Updated changelog * Update CHANGELOG.md --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com>

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

codecov · 2024-06-11T01:55:27Z

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.25%. Comparing base (2777e54) to head (2a1dddc).

Files	Patch %	Lines
packages/core/platform/platform.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feature/enact_v5    #3244      +/-   ##
====================================================
- Coverage             82.51%   82.25%   -0.26%     
====================================================
  Files                   157      152       -5     
  Lines                  7245     7084     -161     
  Branches               1917     1864      -53     
====================================================
- Hits                   5978     5827     -151     
+ Misses                  995      986       -9     
+ Partials                272      271       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

juwonjeong · 2024-06-20T07:55:00Z

Please resolve conflicts in CHANGELOG.md

juwonjeong · 2024-06-20T07:55:46Z

I think we should remove some lines in codecov.yml

"packages/ui/Scrollable"
"packages/ui/Scroller/UiScrollerBase.js"
"packages/ui/GridListImageItem"
"packages/ui/VirtualList/VirtualListBase.js"
"packages/ui/VirtualList/UiVirtualListBase.js"

packages/ui/CHANGELOG.md

packages/webos/CHANGELOG.md

packages/ui/CHANGELOG.md

packages/core/platform/platform.js

SkylerBaek · 2024-06-21T02:26:45Z

I think we should remove some lines in codecov.yml

"packages/ui/Scrollable"

"packages/ui/Scroller/UiScrollerBase.js"

"packages/ui/GridListImageItem"

"packages/ui/VirtualList/VirtualListBase.js"

"packages/ui/VirtualList/UiVirtualListBase.js"

Good catch! Thank you!

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

juwonjeong

LGTM

MikyungKim · 2024-07-04T07:05:33Z

Sorry for the late review. Please resolve the merge conflicts.

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

MikyungKim

LGTM

seunghoh · 2024-07-05T07:27:24Z

packages/core/platform/platform.js

@@ -220,27 +74,19 @@ const parseUserAgent = (userAgent) => {
 		deprecate({name: `supporting ${detectedInfo.browserName} version before ${supportedVersions[detectedInfo.browserName]}`, until: '5.0.0'});


@0x64 Why the version is already '5.0.0'? until is also unclear for me.

until makes a message like " Will be removed in ${until}" and the original message was correct. But, it looks not good to notify 'deprecate' along with versions as we will update the base browser versions annually.
For now, it looks better simply removing 'until' option.

seunghoh

webos/platform/platform.js line 26~27 are not needed as legacy version

const platforms = [
	// LG webOS before adapting Chrome
	{regex: /Web0S;.*Safari\/537.41/, version: 1}, // using WebKit 537.41 for WebAppManager, using Chrome 26 for the browser app
	{regex: /Web0S;.*Safari\/538.2/, version: 2},  // using WebKit 538.2  for WebAppManager, using Chrome 34 for the browser app

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

SkylerBaek · 2024-07-08T08:37:16Z

I removed UA for unsupported legacy versions.

Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com>

* WRQ-22937: Updated storybook to version 8 (#3224) * Updated storybook to version 8 * upgraded storybook to 8.1.5 * minor fix for changelog * merged with enact_v5 * Update CHANGELOG.md * code review fixes * revert of commented properties * code review fix * eslint fixes * eslint fixes * removed unneeded storybook ui properties * updated storybook to 8.1.6 and storybook-utils branch to enact_v5 * removed docs configuration in preview.js removed docs information in About story * removed @storybook/addon-docs * added back storybook/addon-docs * WRQ-25915: Added custom site icon for sampler app (#3246) * added custom site icon for storybook * Update packages/sampler/.storybook/manager-head.html * removed manager-head * WRQ-17541: Changed `ui/Marquee.MarqueeDecorator` to use `@enact/i18n` utils for `marqueeDirection` (#3237) * update marqueeDirection to use @enact/i18n API * update CHANGELOG.md * Update MarqueeDecorator.js * update CHANGELOG.md * update packages/ui/CHANGELOG.md * remove unused module and sort modules alphabetically * fix changelog * WRQ-10629: Removed deprecated APIs (#3244) * Removed deprecated APIs from core/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Removed deprecated APIs from webos/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * WRQ-228: Removed Moonstone related modules (#3207) * Removed deprecated components from enact/ui: IconButton, RadioDecorator, Scroller.ScrollerBase, SlotItem, ToggleItem, VirtualList.UiVirtualListBase, VirtualList.VirtualListBase * Removed reference to ui/SlotItem from ui/Slottable. * Updated changelog * Update CHANGELOG.md --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> * Removed ui/Marquee.MarqueeDecorator config className Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined CHANGELOG files Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fixed Sampler not to use a removed component Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated changelogs and missing changes Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated docs Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fix changelogs broken by merging Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined warning message and removed code for unsupported legacy webOS Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Update deprecation message Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com> --------- Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com> * Update change logs for 5.0.0-rc.1 * unpinning ilib peerDependencies * applying storybook-utils 6.0.0-rc.1 * applying storybook-utils 6.0.0-rc.1 in lockfile * Update release version & date * Version value updating * WRQ-29126: Updated storybook to 8.2 and fixed enact/ui interlink script (#3256) * fixed missing depedency, updated storybook to 8.2 and changed package.json dependencies to patch version * updated storybook dependencies to use latest minor version * fixed merge conflicts * fixed interlink script and added ilib dependency for enact/ui * WRQ-28801: Fix `marqueeController` to marquee properly when `marqueeOnFocus` is true and content is changed (#3255) * WRQ-28801: Rollback handleComplete function in useMarqueeController to not decide whether to start by checking contentFits Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Add changelog Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix typo Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * WRQ-30274: Merge `feature/enact_v5` to `develop` branch (#3261) * change travis dist from focal to jammy Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * modify npm-shrinkwrap.json * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Juwon Jeong <juwon.jeong@lge.com> Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com> Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+0x64@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com> Co-authored-by: Jenkins <accounts@enactjs.com> Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>

SkylerBaek and others added 6 commits May 30, 2024 14:13

Removed deprecated APIs from core/platform

fc2576b

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Removed deprecated APIs from webos/platform

80595b7

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Removed ui/Marquee.MarqueeDecorator config className

61e162c

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Refined CHANGELOG files

6e21110

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Merge branch 'feature/enact_v5' into feature/WRQ-10629

cb003da

Fixed Sampler not to use a removed component

33e7077

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

juwonjeong reviewed Jun 20, 2024

View reviewed changes

packages/ui/CHANGELOG.md Show resolved Hide resolved

packages/webos/CHANGELOG.md Outdated Show resolved Hide resolved

packages/ui/CHANGELOG.md Outdated Show resolved Hide resolved

juwonjeong reviewed Jun 20, 2024

View reviewed changes

packages/core/platform/platform.js Outdated Show resolved Hide resolved

Merge branch 'feature/enact_v5' into feature/WRQ-10629

6ada249

SkylerBaek added 2 commits June 21, 2024 13:30

Updated changelogs and missing changes

fa00106

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Updated docs

77f76b7

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

juwonjeong approved these changes Jun 21, 2024

View reviewed changes

SkylerBaek added 2 commits July 5, 2024 14:03

Merge branch 'feature/enact_v5' into feature/WRQ-10629

2c7df26

Fix changelogs broken by merging

3e02bad

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

MikyungKim approved these changes Jul 5, 2024

View reviewed changes

seunghoh reviewed Jul 5, 2024

View reviewed changes

seunghoh reviewed Jul 8, 2024

View reviewed changes

Refined warning message and removed code for unsupported legacy webOS

80548e0

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

Update deprecation message

2a1dddc

Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com>

seunghoh merged commit b9c9f5c into feature/enact_v5 Jul 9, 2024
3 of 5 checks passed

seunghoh deleted the feature/WRQ-10629 branch July 9, 2024 02:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WRQ-10629: Removed deprecated APIs #3244

WRQ-10629: Removed deprecated APIs #3244

SkylerBaek commented Jun 11, 2024

codecov bot commented Jun 11, 2024 •

edited

Loading

juwonjeong commented Jun 20, 2024

juwonjeong commented Jun 20, 2024

SkylerBaek commented Jun 21, 2024

juwonjeong left a comment

MikyungKim commented Jul 4, 2024

MikyungKim left a comment

seunghoh Jul 5, 2024

SkylerBaek Jul 8, 2024

seunghoh left a comment

SkylerBaek commented Jul 8, 2024

		@@ -220,27 +74,19 @@ const parseUserAgent = (userAgent) => {
		deprecate({name: `supporting ${detectedInfo.browserName} version before ${supportedVersions[detectedInfo.browserName]}`, until: '5.0.0'});

WRQ-10629: Removed deprecated APIs #3244

WRQ-10629: Removed deprecated APIs #3244

Conversation

SkylerBaek commented Jun 11, 2024

Checklist

Issue Resolved / Feature Added

Resolution

Additional Considerations

Links

Comments

codecov bot commented Jun 11, 2024 • edited Loading

Codecov Report

juwonjeong commented Jun 20, 2024

juwonjeong commented Jun 20, 2024

SkylerBaek commented Jun 21, 2024

juwonjeong left a comment

Choose a reason for hiding this comment

MikyungKim commented Jul 4, 2024

MikyungKim left a comment

Choose a reason for hiding this comment

seunghoh Jul 5, 2024

Choose a reason for hiding this comment

SkylerBaek Jul 8, 2024

Choose a reason for hiding this comment

seunghoh left a comment

Choose a reason for hiding this comment

SkylerBaek commented Jul 8, 2024

codecov bot commented Jun 11, 2024 •

edited

Loading