-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-30274: Prepare for merging feature/enact_v5
to develop
branch
#3261
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3261 +/- ##
===========================================
- Coverage 82.51% 82.25% -0.26%
===========================================
Files 157 152 -5
Lines 7245 7084 -161
Branches 1919 1864 -55
===========================================
- Hits 5978 5827 -151
+ Misses 995 986 -9
+ Partials 272 271 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill the PR description when you make a PR
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feature/enact_v5
to develop
branchfeature/enact_v5
to develop
branch
* WRQ-22937: Updated storybook to version 8 (#3224) * Updated storybook to version 8 * upgraded storybook to 8.1.5 * minor fix for changelog * merged with enact_v5 * Update CHANGELOG.md * code review fixes * revert of commented properties * code review fix * eslint fixes * eslint fixes * removed unneeded storybook ui properties * updated storybook to 8.1.6 and storybook-utils branch to enact_v5 * removed docs configuration in preview.js removed docs information in About story * removed @storybook/addon-docs * added back storybook/addon-docs * WRQ-25915: Added custom site icon for sampler app (#3246) * added custom site icon for storybook * Update packages/sampler/.storybook/manager-head.html * removed manager-head * WRQ-17541: Changed `ui/Marquee.MarqueeDecorator` to use `@enact/i18n` utils for `marqueeDirection` (#3237) * update marqueeDirection to use @enact/i18n API * update CHANGELOG.md * Update MarqueeDecorator.js * update CHANGELOG.md * update packages/ui/CHANGELOG.md * remove unused module and sort modules alphabetically * fix changelog * WRQ-10629: Removed deprecated APIs (#3244) * Removed deprecated APIs from core/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Removed deprecated APIs from webos/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * WRQ-228: Removed Moonstone related modules (#3207) * Removed deprecated components from enact/ui: IconButton, RadioDecorator, Scroller.ScrollerBase, SlotItem, ToggleItem, VirtualList.UiVirtualListBase, VirtualList.VirtualListBase * Removed reference to ui/SlotItem from ui/Slottable. * Updated changelog * Update CHANGELOG.md --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> * Removed ui/Marquee.MarqueeDecorator config className Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined CHANGELOG files Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fixed Sampler not to use a removed component Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated changelogs and missing changes Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated docs Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fix changelogs broken by merging Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined warning message and removed code for unsupported legacy webOS Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Update deprecation message Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com> --------- Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com> * Update change logs for 5.0.0-rc.1 * unpinning ilib peerDependencies * applying storybook-utils 6.0.0-rc.1 * applying storybook-utils 6.0.0-rc.1 in lockfile * Update release version & date * Version value updating * WRQ-29126: Updated storybook to 8.2 and fixed enact/ui interlink script (#3256) * fixed missing depedency, updated storybook to 8.2 and changed package.json dependencies to patch version * updated storybook dependencies to use latest minor version * fixed merge conflicts * fixed interlink script and added ilib dependency for enact/ui * WRQ-28801: Fix `marqueeController` to marquee properly when `marqueeOnFocus` is true and content is changed (#3255) * WRQ-28801: Rollback handleComplete function in useMarqueeController to not decide whether to start by checking contentFits Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Add changelog Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix typo Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * WRQ-30274: Merge `feature/enact_v5` to `develop` branch (#3261) * change travis dist from focal to jammy Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * modify npm-shrinkwrap.json * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Juwon Jeong <juwon.jeong@lge.com> Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com> Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+0x64@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com> Co-authored-by: Jenkins <accounts@enactjs.com> Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>
Checklist
Issue Resolved / Feature Added
We will merge
feature/enact_v5
branch todevelop
to release next major alpha version of enact.Resolution
feature/enact_v5
branch todevelop
npm-shrinkwrap.json
in samplerfocal
tojammy
Additional Considerations
Links
WRQ-30274
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)