WRQ-28801: Fix marqueeController to marquee properly when marqueeOnFocus is true and content is changed
#3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o not decide whether to start by checking contentFits Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/enact_v5 #3255 +/- ##
=================================================
Coverage 82.25% 82.25%
=================================================
Files 152 152
Lines 7084 7084
Branches 1864 1864
=================================================
Hits 5827 5827
Misses 986 986
Partials 271 271 ☔ View full report in Codecov by Sentry. |
SkylerBaek
approved these changes
Jul 15, 2024
MikyungKim
changed the title
marqueeController to marquee properly when marqueeOnFocus is true and content is changed
SkylerBaek
added a commit
that referenced
this pull request
Jul 25, 2024
* WRQ-22937: Updated storybook to version 8 (#3224) * Updated storybook to version 8 * upgraded storybook to 8.1.5 * minor fix for changelog * merged with enact_v5 * Update CHANGELOG.md * code review fixes * revert of commented properties * code review fix * eslint fixes * eslint fixes * removed unneeded storybook ui properties * updated storybook to 8.1.6 and storybook-utils branch to enact_v5 * removed docs configuration in preview.js removed docs information in About story * removed @storybook/addon-docs * added back storybook/addon-docs * WRQ-25915: Added custom site icon for sampler app (#3246) * added custom site icon for storybook * Update packages/sampler/.storybook/manager-head.html * removed manager-head * WRQ-17541: Changed `ui/Marquee.MarqueeDecorator` to use `@enact/i18n` utils for `marqueeDirection` (#3237) * update marqueeDirection to use @enact/i18n API * update CHANGELOG.md * Update MarqueeDecorator.js * update CHANGELOG.md * update packages/ui/CHANGELOG.md * remove unused module and sort modules alphabetically * fix changelog * WRQ-10629: Removed deprecated APIs (#3244) * Removed deprecated APIs from core/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Removed deprecated APIs from webos/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * WRQ-228: Removed Moonstone related modules (#3207) * Removed deprecated components from enact/ui: IconButton, RadioDecorator, Scroller.ScrollerBase, SlotItem, ToggleItem, VirtualList.UiVirtualListBase, VirtualList.VirtualListBase * Removed reference to ui/SlotItem from ui/Slottable. * Updated changelog * Update CHANGELOG.md --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> * Removed ui/Marquee.MarqueeDecorator config className Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined CHANGELOG files Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fixed Sampler not to use a removed component Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated changelogs and missing changes Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated docs Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fix changelogs broken by merging Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined warning message and removed code for unsupported legacy webOS Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Update deprecation message Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com> --------- Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com> * Update change logs for 5.0.0-rc.1 * unpinning ilib peerDependencies * applying storybook-utils 6.0.0-rc.1 * applying storybook-utils 6.0.0-rc.1 in lockfile * Update release version & date * Version value updating * WRQ-29126: Updated storybook to 8.2 and fixed enact/ui interlink script (#3256) * fixed missing depedency, updated storybook to 8.2 and changed package.json dependencies to patch version * updated storybook dependencies to use latest minor version * fixed merge conflicts * fixed interlink script and added ilib dependency for enact/ui * WRQ-28801: Fix `marqueeController` to marquee properly when `marqueeOnFocus` is true and content is changed (#3255) * WRQ-28801: Rollback handleComplete function in useMarqueeController to not decide whether to start by checking contentFits Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Add changelog Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix typo Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * WRQ-30274: Merge `feature/enact_v5` to `develop` branch (#3261) * change travis dist from focal to jammy Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * modify npm-shrinkwrap.json * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Juwon Jeong <juwon.jeong@lge.com> Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com> Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+0x64@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com> Co-authored-by: Jenkins <accounts@enactjs.com> Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Checklist
Issue Resolved / Feature Added
In #3247, I fixed the issue to start animation properly by marqueeController when content changed.
As mentioned in the Additional Considerations section, I've added an additional patch to that PR that fixes handleComplete in useMarqueeController because the MarqueeDecorator.start function appears to keep getting called without needing it when marqueeOn is set to render and is in sync mode. .
However we found that this patch cause some regression when marqueeOnFocus is set to true in marqueeController. So we rollback this additional patch in useMarqueeController.
Resolution
Rollback the patch in useMarqueeController.handleComplete.
Additional Considerations
Links
WRQ-28801
#3247
Comments