-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-30274: Merge feature/enact_v5
to develop
branch
#3263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated storybook to version 8 * upgraded storybook to 8.1.5 * minor fix for changelog * merged with enact_v5 * Update CHANGELOG.md * code review fixes * revert of commented properties * code review fix * eslint fixes * eslint fixes * removed unneeded storybook ui properties * updated storybook to 8.1.6 and storybook-utils branch to enact_v5 * removed docs configuration in preview.js removed docs information in About story * removed @storybook/addon-docs * added back storybook/addon-docs
* added custom site icon for storybook * Update packages/sampler/.storybook/manager-head.html * removed manager-head
… utils for `marqueeDirection` (#3237) * update marqueeDirection to use @enact/i18n API * update CHANGELOG.md * Update MarqueeDecorator.js * update CHANGELOG.md * update packages/ui/CHANGELOG.md * remove unused module and sort modules alphabetically
* Removed deprecated APIs from core/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Removed deprecated APIs from webos/platform Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * WRQ-228: Removed Moonstone related modules (#3207) * Removed deprecated components from enact/ui: IconButton, RadioDecorator, Scroller.ScrollerBase, SlotItem, ToggleItem, VirtualList.UiVirtualListBase, VirtualList.VirtualListBase * Removed reference to ui/SlotItem from ui/Slottable. * Updated changelog * Update CHANGELOG.md --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> * Removed ui/Marquee.MarqueeDecorator config className Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined CHANGELOG files Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fixed Sampler not to use a removed component Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated changelogs and missing changes Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Updated docs Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fix changelogs broken by merging Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Refined warning message and removed code for unsupported legacy webOS Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Update deprecation message Enact-DCO-1.0-Signed-off-by: Seungho Park <seunghoh.park@lge.com> --------- Co-authored-by: Seungcheon Baek <5037955+SeungcheonBaek@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Seungho Park <seunghoh.park@lge.com>
…pt (#3256) * fixed missing depedency, updated storybook to 8.2 and changed package.json dependencies to patch version * updated storybook dependencies to use latest minor version * fixed merge conflicts * fixed interlink script and added ilib dependency for enact/ui
…nFocus` is true and content is changed (#3255) * WRQ-28801: Rollback handleComplete function in useMarqueeController to not decide whether to start by checking contentFits Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Add changelog Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix typo Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
* change travis dist from focal to jammy Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * modify npm-shrinkwrap.json * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * add changelog Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3263 +/- ##
===========================================
- Coverage 82.51% 82.25% -0.26%
===========================================
Files 157 152 -5
Lines 7245 7084 -161
Branches 1919 1864 -55
===========================================
- Hits 5978 5827 -151
+ Misses 995 986 -9
+ Partials 272 271 -1 ☔ View full report in Codecov by Sentry. |
SkylerBaek
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
We will merge
feature/enact_v5
branch todevelop
to release next major alpha version of enact.Resolution
feature/enact_v5
branch todevelop
npm-shrinkwrap.json
in samplerfocal
tojammy
Additional Considerations
This PR is basically the same with #3261.
Links
WRQ-30274
Comments
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)