[WIP] Move Workbench from Pyface #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…development world.
…rspective is changed.
…bs immediately after current tab instead of end of tab bar.
…me instances under (a possibly buggy) PySide where qApp is None. Guard a PyQt4-specific workaround.
* master: BUG: Use QApplication.instance() instead of qApp because there are some instances under (a possibly buggy) PySide where qApp is None. Guard a PyQt4-specific workaround. BUG: Fix line_uncomment() to expect a Python unicode string instead of a QString. BUG: Revert previous commit: still seems correct, but a tasks app shows several regressions (preferences not saved, Windows shutdown errors) and will need more time to adapt.
BUG: Add encoding attribute to PythonWidget.
BF: Reset tab title to foreground color when it receives focus
BF: Handle view being closed through close button
BUG: Schema ordering when absolute and relative positions are specified
Correct typo.
FIX: Workbench editor destruction in PySide.
…ealing with traitsui.
Remove old-style signals and slots
Qt single choice dialog
Replace module-level use of unittest.SkipTest with a class decorator.
Fix size and position handling for dialog classes
Fix nosetests-specific spelling of setUpClass.
Update gui test assistant
More TraitsUI cleanup
Setup.py improvements
Allow plugin toolkits
Fix badge in README
BUG: Restore ad hoc signals in SplitTabWidget.
Travis CI for Python 3.6
MAINT: Update EndEdit signature.
Add visible and enabled traits to base Widget interface
|
@corranwebster What's the status of this PR? |
|
This is out of date, and we will probably make workbench a stand-alone package. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See enthought/pyface#249 and #71.
This is currently just taking the code from Pyface, renaming directories, and updating imports. An attempt has been made to keep the commit history of the code.
The plan would be to merge this soon into apptools master, and then following the next apptools release have dependent projects switch their imports to point to apptools rather than Pyface. In the longer term (currently scheduled for Pyface 7.0.0), Workbench would be removed completely from Pyface.
To do: