Build and push both 20.04 and 22.04 images #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeberhard
approved these changes
Sep 22, 2022
eeberhard
added a commit
that referenced
this pull request
Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows and clarifies the license requirements of the library and its dependencies. Fixes and improvements: - Build and push both 20.04 and 22.04 images (#314, #315, #316) - Don't build pinocchio tests in development image (#317) - Simplify and consolidate Dockerfiles and scripts (#319) - Better license management (#320)
eeberhard
added a commit
that referenced
this pull request
Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows and clarifies the license requirements of the library and its dependencies. Fixes and improvements: - Build and push both 20.04 and 22.04 images (#314, #315, #316) - Don't build pinocchio tests in development image (#317) - Simplify and consolidate Dockerfiles and scripts (#319) - Better license management (#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CI slightly, such that it builds and pushes two images, one from ubuntu 20.04 and one from ubuntu 22.04.
The changes have been tested on my fork (except the ARM build which takes too long). I propose to get this in asap such that we can build the two images manually from develop branch and then we can do the other necessary changes in the whole docker and CI pipeline subsequently.
Internally, this won't break anything because control libraries also builds and passes the tests if the latest image which is currently a 20.04 image will be a 22.04 image. That's why I think we can get this in and build the images asap. It will only break something in the galactic build of our ROS images but those are kinda broken anyway atm...