Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and push both 20.04 and 22.04 images #315

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Sep 23, 2022

Ok sorry, the only change that I didn't test was wrong...

@domire8 domire8 requested a review from eeberhard September 23, 2022 05:44
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I didn't notice that in #314, it was hard to spot from the diff - did you auto-format it or something? Anyway nothing wrong with quick fix

@domire8
Copy link
Contributor Author

domire8 commented Sep 23, 2022

Sorry that I didn't notice that in #314, it was hard to spot from the diff - did you auto-format it or something? Anyway nothing wrong with quick fix

No that was just my brain...

@domire8 domire8 merged commit 7abfad9 into develop Sep 23, 2022
@domire8 domire8 deleted the fix/22-and-20-image branch September 23, 2022 09:05
eeberhard added a commit that referenced this pull request Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows
and clarifies the license requirements of the library and its dependencies.

Fixes and improvements:

- Build and push both 20.04 and 22.04 images (#314, #315, #316)
- Don't build pinocchio tests in development image (#317)
- Simplify and consolidate Dockerfiles and scripts (#319)
- Better license management (#320)
eeberhard added a commit that referenced this pull request Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows
and clarifies the license requirements of the library and its dependencies.

Fixes and improvements:

- Build and push both 20.04 and 22.04 images (#314, #315, #316)
- Don't build pinocchio tests in development image (#317)
- Simplify and consolidate Dockerfiles and scripts (#319)
- Better license management (#320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants