Don't build pinocchio tests in development image #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can also create an issue or similar to not forget that we have to think about this again before releases to main. |
eeberhard
previously approved these changes
Sep 27, 2022
There was a problem hiding this comment.
This is definitely an acceptable fix, and given that we don't change the workflow, Pinocchio version or dockerfile sequence often, we can trust with some confidence that the source installation will be fine even without tests. It would be good to eventually re-introduce them, mainly if there are any untracked changes in base image or package versions from e.g. apt-get install. I agree opening an issue for it would be appropriate. If the linked build-push action passes as expected then this is good to go in my opinion.
eeberhard
approved these changes
Sep 28, 2022
eeberhard
added a commit
that referenced
this pull request
Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows and clarifies the license requirements of the library and its dependencies. Fixes and improvements: - Build and push both 20.04 and 22.04 images (#314, #315, #316) - Don't build pinocchio tests in development image (#317) - Simplify and consolidate Dockerfiles and scripts (#319) - Better license management (#320)
eeberhard
added a commit
that referenced
this pull request
Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows and clarifies the license requirements of the library and its dependencies. Fixes and improvements: - Build and push both 20.04 and 22.04 images (#314, #315, #316) - Don't build pinocchio tests in development image (#317) - Simplify and consolidate Dockerfiles and scripts (#319) - Better license management (#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the build time of the development image, I propose (until we found a better solution) to disable the build of the pinocchio tests.
Additionally, I updated the number of jobs to use for make commands to #CPUs - 1.
These changes are currently running here