Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image name in base Dockerfile #316

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Fix image name in base Dockerfile #316

merged 3 commits into from
Sep 23, 2022

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Sep 23, 2022

Ok I was really not on my best when I copied that back to this repo.....

(I'm also not trying to increase my PR numbers, this is just sloppy work)

@domire8 domire8 requested a review from eeberhard September 23, 2022 10:26
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reviews are also sloppy because I haven't spent a lot of time on them but I know you want to fix this promptly. It's ok, that's why we have the develop branch!

@domire8 domire8 merged commit b3da95c into develop Sep 23, 2022
@domire8 domire8 deleted the fix/22-and-20-image branch September 23, 2022 10:40
eeberhard added a commit that referenced this pull request Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows
and clarifies the license requirements of the library and its dependencies.

Fixes and improvements:

- Build and push both 20.04 and 22.04 images (#314, #315, #316)
- Don't build pinocchio tests in development image (#317)
- Simplify and consolidate Dockerfiles and scripts (#319)
- Better license management (#320)
eeberhard added a commit that referenced this pull request Oct 28, 2022
Version 6.3.0 contains behind-the-scenes structural improvements to Dockerfiles and GitHub workflows
and clarifies the license requirements of the library and its dependencies.

Fixes and improvements:

- Build and push both 20.04 and 22.04 images (#314, #315, #316)
- Don't build pinocchio tests in development image (#317)
- Simplify and consolidate Dockerfiles and scripts (#319)
- Better license management (#320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants