Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grade namespace conflicts on building an APK release #20300

Closed
wants to merge 267 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Feb 14, 2018

  1. Bundle download progress on Android

    Summary:
    Android equivalent of facebook#15066
    
    Tested that download progress shows up properly when reloading the app.
    
    [ANDROID] [FEATURE] [DevSupport] - Show bundle download progress on Android
    Closes facebook#17809
    
    Differential Revision: D6982823
    
    Pulled By: hramos
    
    fbshipit-source-id: da01e42b8ebb1c603f4407f6bafd68e0b6b3ecba
    janicduplessis authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    d06e143 View commit details
    Browse the repository at this point in the history
  2. add BULLET and BULLET_SP

    Reviewed By: TheSavior
    
    Differential Revision: D6983446
    
    fbshipit-source-id: c8ce4b1c7836654910db84c9cd4b6d0bcec8ae27
    sahrens authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    4761d5a View commit details
    Browse the repository at this point in the history
  3. allow installing extra JS binding via the bridge

    Reviewed By: mdvacca
    
    Differential Revision: D6957397
    
    fbshipit-source-id: 172905861fbb1c9ed45149e33b406c28ad616cd7
    fkgozali authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    e165d0d View commit details
    Browse the repository at this point in the history
  4. Add JS binding for FabricUIManager - iOS

    Reviewed By: sebmarkbage
    
    Differential Revision: D6934518
    
    fbshipit-source-id: 1f626f79a74fb199925644e8b16238aa17d40e1f
    fkgozali authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    1aeb925 View commit details
    Browse the repository at this point in the history
  5. iOS: allow getting an instance of a js-bound module via the bridge

    Reviewed By: sebmarkbage
    
    Differential Revision: D6982785
    
    fbshipit-source-id: 7bbcc5416e1d1a3a577328349a7c18af5c0f8577
    fkgozali authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    5f48bd8 View commit details
    Browse the repository at this point in the history
  6. Fixed a bug with positioning of nested views inside <Text>

    Summary:
    Fixing of recent regression in layout system.
    Conseptually, a superview should define frames of child views.
    
    Reviewed By: mmmulani
    
    Differential Revision: D6980128
    
    fbshipit-source-id: e267e966fd46af28db1d3d40939110040b74e33f
    shergin authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    7d20de4 View commit details
    Browse the repository at this point in the history
  7. Verify that the component passed to createAnimatedComponent is not fu…

    …nctional
    
    Summary:
    Stateless functional components don't support refs and we need that for the component to work, it used to crash with this error message: `undefined is not an object (evaluating 'this._component.getScrollableNode')`. This makes it clear what the issue is.
    
    Fixes some of the errors in facebook#10635, not sure if it fixes all the cases described in the issue though.
    
    **Test plan**
    Tested that passing a component with createClass or extends Component works but passing a function causes an error.
    
    [GENERAL] [ENHANCEMENT] [Animated] - Verify that the component passed to createAnimatedComponent is not functional
    Closes facebook#15019
    
    Differential Revision: D6988096
    
    Pulled By: sahrens
    
    fbshipit-source-id: ec0ffa763245e786f44b4a1d56c0738876c25782
    janicduplessis authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    10b642a View commit details
    Browse the repository at this point in the history
  8. Pass port when running on device (fix facebook#17973)

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Building for iOS device `react-native run-ios --device [id]` fails since port is not passed. This is a blocker for us and prevents us from updating to latest React Native stable.
    
    I've tested this in our app and also in fresh app using RN master and verified that it works.
    
    None.
    
    [CLI] [BUGFIX] [local-cli/runIOS/runIOS.js] - Pass metro port when running on device
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#17983
    
    Differential Revision: D6988299
    
    Pulled By: hramos
    
    fbshipit-source-id: 5169706600f87f13b9c9c105eb7d6db7a40194f1
    jozan authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    f8fee0a View commit details
    Browse the repository at this point in the history
  9. Fix enableBabelRCLookup option in new CLI + global cache script

    Reviewed By: BYK
    
    Differential Revision: D6977885
    
    fbshipit-source-id: 50245e046c7639f9fb4022a9cc5974d50831524c
    rafeca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    96ec2dc View commit details
    Browse the repository at this point in the history
  10. Pass cacheVersion param via the new API

    Reviewed By: BYK
    
    Differential Revision: D6980337
    
    fbshipit-source-id: 72c01136b6720390ffec8593f0375c8756dc1d4a
    rafeca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    828cd78 View commit details
    Browse the repository at this point in the history
  11. Support resumes without overriding the back handler

    Differential Revision: D6982515
    
    fbshipit-source-id: 5483f6c677c6653e51f6311386f31f5be6ed0e00
    ayc1 authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    c281f7a View commit details
    Browse the repository at this point in the history
  12. Expose methods of persistent yoga for Java

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D6918605
    
    fbshipit-source-id: e424c78680c04e21154ebe21405671c4e90f6529
    mdvacca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    ecc08ad View commit details
    Browse the repository at this point in the history
  13. Allow installing JS binding via the RN Android bridge

    Reviewed By: fkgozali
    
    Differential Revision: D6979072
    
    fbshipit-source-id: 8b4ac3769496a6a6fe3dd9ee2aac64b66604c413
    mdvacca authored and facebook-github-bot committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    db391a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Make Java YogaNode cloneable

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D6935971
    
    fbshipit-source-id: a2008f1eb849b5074585b48699b7de56d5ac90d4
    mdvacca authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    51def5e View commit details
    Browse the repository at this point in the history
  2. Upgrade Jest to 22.3.0

    Reviewed By: BYK
    
    Differential Revision: D6978514
    
    fbshipit-source-id: 3c6be52d38fedbe849dee6319bb2e4d7a97297c9
    Miguel Jimenez Esun authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    991b7ab View commit details
    Browse the repository at this point in the history
  3. Extract polyfillGlobal from InitializeCore

    Reviewed By: jeanlauliac
    
    Differential Revision: D6987657
    
    fbshipit-source-id: 8762732de671418520376a98bdd724bbb24e4e36
    fromcelticpark authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f7f5dc6 View commit details
    Browse the repository at this point in the history
  4. Fix main size calculation from the aspect ratio

    Summary:
    When the following conditions are met, the main size become smaller by the margins in the main axis.
    * The aspect ratio is defined
    * The main size is not defined
    * The cross size is defined
    * The main margin is defined
    
    This is because the main margin size is not included when calculating the main size from the aspect ratio.
    Closes facebook/yoga#715
    
    Reviewed By: emilsjolander
    
    Differential Revision: D6998988
    
    Pulled By: priteshrnandgaonkar
    
    fbshipit-source-id: f6f69c47ece17bd7c5e41517b96032bf0c149356
    Yuichi ONO authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    f751c34 View commit details
    Browse the repository at this point in the history
  5. Fold .eslintrc's into the root eslintrc

    Reviewed By: TheSavior
    
    Differential Revision: D6997050
    
    fbshipit-source-id: 81e45d24343cca8336adb0de43bd766899ff03b6
    zertosh authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    59401f8 View commit details
    Browse the repository at this point in the history
  6. Create JNI wrapper for Fabric

    Reviewed By: fkgozali
    
    Differential Revision: D6989838
    
    fbshipit-source-id: f092901cacc0c3eb89b08c6ac0384c4d5f6e6cfe
    mdvacca authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    c82b9f7 View commit details
    Browse the repository at this point in the history
  7. Extend installFabric method to access UIFabricModule from C++

    Reviewed By: sebmarkbage
    
    Differential Revision: D7001974
    
    fbshipit-source-id: a49c6e634ac710805fb37a50a61c2cf2e248b8a7
    mdvacca authored and facebook-github-bot committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ad4f54f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Demo illustrated base-line metric exposure

    Summary:
    A demo illustrated `base-line` metric exposure to layout system was added to RNTester.
    And currently it shows that we don't support it at all.
    
    https://cl.ly/1F0B0D430U3e
    
    Reviewed By: sahrens
    
    Differential Revision: D6957056
    
    fbshipit-source-id: 28776300fc8e11950ac5ba1a5416f68d31d4e9fb
    shergin authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    7630a61 View commit details
    Browse the repository at this point in the history
  2. base-line metric exposure for <Text>

    Summary:
    Now <Text> exposes base-line metric to Yoga.
    
    Before:
    https://cl.ly/1F0B0D430U3e
    
    After:
    https://cl.ly/0G1Q29450O0y
    
    Reviewed By: yungsters
    
    Differential Revision: D6957055
    
    fbshipit-source-id: 04c1df693915e294b54e3c33e0aea21611dcc232
    shergin authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    51b3529 View commit details
    Browse the repository at this point in the history
  3. base-line metric exposure for <TextInput>

    Summary:
    Now <TextInput> (both bersions) exposes base-line metric to Yoga.
    Before:
    https://cl.ly/0G1Q29450O0y
    After:
    https://cl.ly/2X103V3O0322
    
    Reviewed By: yungsters
    
    Differential Revision: D6957054
    
    fbshipit-source-id: d76d96f56720d710a4230c53beafdb0b2521e8a9
    shergin authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    0dbe183 View commit details
    Browse the repository at this point in the history
  4. Use only native robolectric_test rules.

    Reviewed By: adamjernst
    
    Differential Revision: D6997829
    
    fbshipit-source-id: 5f8d41a6126f02c9fb9d0fb90d89df28eeea9653
    ttsugriy authored and facebook-github-bot committed Feb 16, 2018
    2 Configuration menu
    Copy the full SHA
    574c70e View commit details
    Browse the repository at this point in the history
  5. Support for animated tracking in native driver

    Summary:
    This PR adds support for Animated tracking to Animated Native Driver implementation on Android and iOS.
    
    Animated tracking allows for animation to be started with a "dynamic" end value. Instead of passing a fixed number as end value we can pass a reference to another Animated.Value. Then when that value changes, the animation will be reconfigured to drive the animation to the new destination point. What is important is that animation will keep its state in the process of updating "toValue". That is if it is a spring animation and the end value changes while the previous animation still hasn't settled the new animation will start from the current position and will inherit current velocity. This makes end value transitions very smooth.
    
    Animated tracking is available in JS implementation of Animated library but not in the native implementation. Therefore until now, it wasn't possible to utilize native driver when using animated tracking. Offloading animation from JS thread turns out to be crucial for gesture driven animations. This PR is a step forward towards feature parity between JS and native implementations of Animated.
    
    Here is a link to example video that shows how tracking can be used to implement chat heads effect: https://twitter.com/kzzzf/status/958362032650244101
    
    In addition this PR fixes an issue with frames animation driver on Android that because of rounding issues was taking one extra frame to start. Because of that change I had to update a number of Android unit tests that were relying on that behavior and running that one additional animation step prior to performing checks.
    
    As a part of this PR I'm adding three unit tests for each of the platforms that verifies most important aspects of this implementation. Please refer to the code and look at the test cases top level comments to learn what they do.
    
    I'm also adding a section to "Native Animated Example" screen in RNTester app that provides a test case for tracking. In the example we have blue square that fallows the red line drawn on screen. Line uses Animated.Value for it's position while square is connected via tracking spring animation to that value. So it is ought to follow the line. When user taps in the area surrounding the button new position for the red line is selected at random and the value updates. Then we can watch blue screen animate to that position.
    
    You can also refer to this video that I use to demonstrate how tracking can be linked with native gesture events using react-native-gesture-handler lib: https://twitter.com/kzzzf/status/958362032650244101
    
    [GENERAL][FEATURE][Native Animated] - Added support for animated tracking to native driver. Now you can use `useNativeDriver` flag with animations that track other Animated.Values
    Closes facebook#17896
    
    Differential Revision: D6974170
    
    Pulled By: hramos
    
    fbshipit-source-id: 50e918b36ee10f80c1deb866c955661d4cc2619b
    kmagiera authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b48f7e5 View commit details
    Browse the repository at this point in the history
  6. Dirty text shadow nodes on UIManager queue after multiplier changes

    Summary: Letting them fire on whatever queue we get the notification from throws an assert.
    
    Reviewed By: shergin
    
    Differential Revision: D7002789
    
    fbshipit-source-id: 669474af1a07f0df6784b69b54afe0152c1ba3c4
    Mehdi Mulani authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    cff522d View commit details
    Browse the repository at this point in the history
  7. Disable font scaling when an explicit font handler is set

    Reviewed By: sahrens
    
    Differential Revision: D7003464
    
    fbshipit-source-id: f36ff344c50a9c63af6c852138041c1c918259c8
    Mehdi Mulani authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    f96dfb9 View commit details
    Browse the repository at this point in the history
  8. Extend the FabricUIManagerModule class to integrate with JSI/JSC in A…

    …ndroid
    
    Reviewed By: sebmarkbage
    
    Differential Revision: D7005419
    
    fbshipit-source-id: 6e65be5a922ddb29fde965f5df779cc92a996ecf
    mdvacca authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    1f7a48f View commit details
    Browse the repository at this point in the history
  9. Bump buck to v2018.02.16.01

    Summary:
    This should fix our current Android test failures.
    Closes facebook#18002
    
    Differential Revision: D7014218
    
    Pulled By: hramos
    
    fbshipit-source-id: 2933baf9fd05f3ad33306c3ca7b62da8af568db0
    hramos authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    617362b View commit details
    Browse the repository at this point in the history
  10. Exclude jsbundle files from VCS

    Summary:
    jsbundle files can be generated, and are quite large and therefore, I think should be excluded from being committed to the repo.
    
    [ GENERAL ][ MINOR ][local-cli/templates/_gitignore] - Included a new entry to ignore jsbundle files
    Closes facebook#17888
    
    Differential Revision: D6977064
    
    Pulled By: hramos
    
    fbshipit-source-id: 9c7803004f3f4ec59cba3017213f68fba8225dbf
    aneophyte authored and facebook-github-bot committed Feb 16, 2018
    1 Configuration menu
    Copy the full SHA
    2123108 View commit details
    Browse the repository at this point in the history
  11. tvOS: TV nav event emitter should check for bridge

    Summary:
    When running with the packager in the tvOS simulator, reloading from the packager hits an assert in `RCTEventEmitter`, causing a crash.  The solution is for `RCTTVNavigationEventEmitter` to check for the existence of the bridge before attempting to send an event.
    
    Manual testing.
    
    [IOS] [BUGFIX] [RCTTVNavigationEventEmitter.m] - Fix crash when reloading in tvOS
    Closes facebook#17797
    
    Differential Revision: D7014975
    
    Pulled By: hramos
    
    fbshipit-source-id: 0bf766e87267ca8592ff0cc0b3cb4621a8e8f9b5
    douglowder authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    3a3d884 View commit details
    Browse the repository at this point in the history
  12. Change irrelevant Products path in ./local-cli/runIOS/runIOS.js

    Summary:
    facebook#7308
    and many of the same
    
    Seems like xcode cli tool isn't create ./build directory any more but place Products
    right inside ./Build (may check while creating single view ios application
    in XCode)
    
    * edit hardcoded path to {appName}.app
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Command `$ react-native run-ios` is often lead to `Entry, ":CFBundleIdentifier", Does Not Exist`
    I find out how to fix it in current version of RN and Xcode cli tools
    
    Just try to do `$ react native init {appName}` and then `$ react native run-ios` if everything fine it means my approach is right :)
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#17963
    
    Differential Revision: D7014984
    
    Pulled By: hramos
    
    fbshipit-source-id: da62f130e6ebf7d3acd09d36525838d5c9684e75
    blackneck authored and facebook-github-bot committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    5447ca6 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. Better Android Gradle Plugin 3.x integration

    Summary:
    Better integration with the Android Gradle-based build process, especially the changes introduced by the [Android Gradle Plugin 3.x and AAPT2](https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html).
    
    Fixes facebook#16906, the `android.enableAapt2=false` workaround is no longer required.
    
    Bases the task generation process on the actual application variants present in the project. The current manual process of iterating build types and product flavors could break down when more than one dimension type is present (see https://developer.android.com/studio/build/build-variants.html#flavor-dimensions).
    
    This also exposes a very basic set of properties in the build tasks, so that other tasks can more reliably access them:
    
    ```groovy
    android.applicationVariants.all { variant ->
        // This is the generated task itself:
        def reactBundleTask = variant.bundleJsAndAssets
        // These are the outputs by type:
        def resFileCollection = reactBundleTask.generatedResFolders
        def assetsFileCollection = reactBundleTask.generatedAssetsFolders
    }
    ```
    
    I've tested various combinations of product flavors and build types ([Build Variants](https://developer.android.com/studio/build/build-variants.html)) to make sure this is consistent. This is a port of what we're currently deploying to our CI process.
    
    [ ANDROID ] [ BUGFIX ] [ react.gradle ] - Support Android Gradle Plugin 3.x and AAPT2
    [ ANDROID ] [ FEATURE ] [ react.gradle ] - Expose the bundling task and its outputs via ext properties
    Closes facebook#17967
    
    Differential Revision: D7017148
    
    Pulled By: hramos
    
    fbshipit-source-id: e52b3365e5807430b9caced51349abf72332a587
    CFKevinRef authored and facebook-github-bot committed Feb 17, 2018
    5 Configuration menu
    Copy the full SHA
    d16ff3b View commit details
    Browse the repository at this point in the history
  2. Fix pinch crash in touch-responsive views.

    Summary:
    Fork and rebase of gillessed's PR facebook#13166 which has gotten stale.
    
    From original PR:
    
    Motivation (required)
    
    Multiple react native developer (including myself) have run into a crash with the react-native-photo-view library (and possibly others). The common solution to this problem lies in the underlying java code, and thus requires a change in the react native source.
    
    The stack trace I am getting is the same as listed here alwx/react-native-photo-view#15.
    
    There was a PR to fix this (facebook#12085) but it was closed. In response to the comments there, in my PR, I do log the exceptions. I don't think we can get any closer to the exception because in the next level of the stack trace, we are in the android sdk code.
    
    Looking at some stack overflow pages and the android bug tracker, it seems that this is the common solution to this bug, and does not cause any impact any functionality.
    
    https://code.google.com/p/android/issues/list?can=1&q=pointerindex+out+of+range&colspec=ID+Status+Priority+Owner+Summary+Stars+Reporter+Opened&cells=tiles
    
    Test Plan (required)
    
    I have manually tested this by compiling react native android from source and have confirmed the exception still gets hit and logged, but does not cause the app to terminate.
    Closes facebook#17167
    
    Differential Revision: D7014296
    
    Pulled By: hramos
    
    fbshipit-source-id: 06b4a31062a591b726d2021e877d16f49881dcfd
    tobycox authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    67c3ad4 View commit details
    Browse the repository at this point in the history
  3. Update license headers for MIT license

    Summary:
    Includes React Native and its dependencies Fresco, Metro, and Yoga. Excludes samples/examples/docs.
    
    find: ^(?:( *)|( *(?:[\*~#]|::))( )? *)?Copyright (?:\(c\) )?(\d{4})\b.+Facebook[\s\S]+?BSD[\s\S]+?(?:this source tree|the same directory)\.$
    replace: $1$2$3Copyright (c) $4-present, Facebook, Inc.\n$2\n$1$2$3This source code is licensed under the MIT license found in the\n$1$2$3LICENSE file in the root directory of this source tree.
    
    Reviewed By: TheSavior, yungsters
    
    Differential Revision: D7007050
    
    fbshipit-source-id: 37dd6bf0ffec0923bfc99c260bb330683f35553e
    sophiebits authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    1490ab1 View commit details
    Browse the repository at this point in the history
  4. Update to MIT license

    Summary: Manual changes.
    
    Reviewed By: TheSavior, yungsters
    
    Differential Revision: D7012152
    
    fbshipit-source-id: de7459be3db13c687868b45059856f125c4f2eb1
    sophiebits authored and facebook-github-bot committed Feb 17, 2018
    24 Configuration menu
    Copy the full SHA
    26684cf View commit details
    Browse the repository at this point in the history
  5. @allow-large-files Upgrade xplat/js to Flow v0.66

    Reviewed By: gabelevi
    
    Differential Revision: D7016717
    
    fbshipit-source-id: 2bd2fd67074ba5d405ecd63a1aeb37354f8634c9
    Caleb Meredith authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    da3424c View commit details
    Browse the repository at this point in the history
  6. Fix facebook#17610, Add fixtures to metro blacklist

    Summary:
    Include a default blacklist into the build settings to prevent
    processing of incorrect fixture files by Metro.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Fix facebook#17610 issue, preventing metro from processing fixture files
    
    1. Have a working demo
    2. Install https://github.com/oblador/react-native-vector-icons
    3. Use in a component
    4. Start the app
    5. The app starts successfully and display the icons
    
    [ GENERAL  ]  [ BUGFIX ]  [local-cli/util/Config.js] - Add default file blacklist
    Closes facebook#17672
    
    Differential Revision: D7014627
    
    Pulled By: hramos
    
    fbshipit-source-id: 20974e6fdd0977eeeb1048c29c9d621c803c26e9
    t4deu authored and facebook-github-bot committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    54dc11a View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. fix Flow typing for OSS

    Summary:
    Add ignores for these requires, some of them mistakenly removed by facebook@da3424c.
    
    ```
    yarn flow
    ```
    
    CircleCI should be green again.
    Closes facebook#18021
    
    Differential Revision: D7025304
    
    Pulled By: jeanlauliac
    
    fbshipit-source-id: 731232093ae3ab39b3eff6fb2004ff4e7090d5ae
    Jean Lauliac authored and facebook-github-bot committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    4454fdc View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. RN: Remove React Stack Systrace Logic

    Reviewed By: sophiebits
    
    Differential Revision: D7027263
    
    fbshipit-source-id: f4eb3fab402eda337f464e4ebb0771202a9b93f2
    yungsters authored and facebook-github-bot committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    973ef97 View commit details
    Browse the repository at this point in the history
  2. Move YGStyle to seperate file and add constructors

    Reviewed By: emilsjolander
    
    Differential Revision: D7016575
    
    fbshipit-source-id: eb28df0ffb4cc813b23edaff80d7d4ebc56ce6af
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 20, 2018
    1 Configuration menu
    Copy the full SHA
    b9991d3 View commit details
    Browse the repository at this point in the history
  3. Add constructor in YGLayout

    Reviewed By: emilsjolander
    
    Differential Revision: D7019653
    
    fbshipit-source-id: 5a2655626db0915fcebe7d4517e2d0b2e2484460
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    c75ce81 View commit details
    Browse the repository at this point in the history
  4. Added default constructor for YGCachedMeasurement

    Reviewed By: emilsjolander
    
    Differential Revision: D7020337
    
    fbshipit-source-id: e084e234bf6a2ae22e53e739959683abca169b88
    priteshrnandgaonkar authored and facebook-github-bot committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    22cf815 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2018

  1. Replaced unstable_AsyncComponent with unstable_AsyncMode

    Reviewed By: gaearon
    
    Differential Revision: D7025510
    
    fbshipit-source-id: 1aff984ce7479e5fdff71259d0f552193a6cdcea
    Brian Vaughn authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    9dd7608 View commit details
    Browse the repository at this point in the history
  2. Introduce cloning mechanism for React Shadow Node

    Reviewed By: achen1
    
    Differential Revision: D7018869
    
    fbshipit-source-id: beca45b1df9602ebbc9172091b24a2bf44e103f4
    mdvacca authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    ad06403 View commit details
    Browse the repository at this point in the history
  3. RN: Remove Animated -> ScrollView -> Animated Cycle

    Reviewed By: sahrens
    
    Differential Revision: D7027223
    
    fbshipit-source-id: 59924fada0f29a5e2ce1ae9a3694a94cfb26367c
    yungsters authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    8c036ce View commit details
    Browse the repository at this point in the history
  4. RCTSurface: Optional sync ShadowView/View registing

    Summary:
    See the comment in code.
    If we on the main thread on registering time, we can/will break sequentiality of registering and mounting processes doing registration asynchronously.
    We need this to make sync mouting eventually possible.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7014176
    
    fbshipit-source-id: 110ad5e5d86e3422eac15c3b1bdb29ae04acd7e6
    shergin authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    b90c1cf View commit details
    Browse the repository at this point in the history
  5. Enforcing sequential ordering of creating view and applying props in …

    …UIManager
    
    Summary: See the comment in code.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7014177
    
    fbshipit-source-id: c58db856d7701a285564470eb1f024b5012dd451
    shergin authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    60c0000 View commit details
    Browse the repository at this point in the history
  6. New UIManager API allowing intercept/delay mounting process

    Summary: In some embedding/interop cases (RN inside, something else outside), the interop layer has to have the ability to control (intercept, delay, perform synchronously with another stuff) mounting process. This API allows doing that.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7014179
    
    fbshipit-source-id: 04036095f7e60a5ff7e69025ff6066fea92eb361
    shergin authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    402ae2f View commit details
    Browse the repository at this point in the history
  7. RCTSurface: Support for synchronous waiting for mounting stage

    Summary:
    So, all initial operations can now be done synchronously (and on the main thread).
    To do so, instancitate `RCTSurface` object and call `synchronouslyWaitForStage:timeout:` method like that:
    
    RCTSurface *surface = [[RCTSurface alloc] initWithBridge:... moduleName:... initialProperties:...];
    BOOL success = [surface synchronouslyWaitForStage:RCTSurfaceStageSurfaceDidInitialMounting timeout:timeout];
    
    or
    
    RCTSurfaceHostingView *surfaceHostingView = [[RCTSurfaceHostingView alloc] initWithBridge:... moduleName:... initialProperties:...];
    BOOL success = [surfaceHostingView.surface synchronouslyWaitForStage:RCTSurfaceStageSurfaceDidInitialMounting timeout:timeout];
    
    Reviewed By: fkgozali
    
    Differential Revision: D7014178
    
    fbshipit-source-id: c3c13904a3587ff2a222fa71623c40c8f30bc8af
    shergin authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    b7fbeb2 View commit details
    Browse the repository at this point in the history
  8. Remove unused reference in Text.js

    Summary:
    Previously, the Platform module was used to detect when RCTVirtualText should be used. Recently, this has changed to detecting the availability of a native virtual text component on the UIManager. The import for the Platform module can be deleted.
    
    I was cleaning up source code copied in react-native-windows and noticed this reference is no longer used in Text.js.
    
    Run jest tests.
    
    N/A
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#18039
    
    Differential Revision: D7042473
    
    Pulled By: hramos
    
    fbshipit-source-id: d318cfdfd2d052bd1662ac469dd51633f6d59d17
    rozele authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    47addd8 View commit details
    Browse the repository at this point in the history
  9. Implement FabricUIManagerModule in Android

    Reviewed By: achen1
    
    Differential Revision: D7031902
    
    fbshipit-source-id: a8d9d505f981ac4268760efa32f4cbc7955aec32
    mdvacca authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    4371d1e View commit details
    Browse the repository at this point in the history
  10. Mock static methods of TouchableNativeFeedback on iOS

    Reviewed By: TheSavior
    
    Differential Revision: D7016679
    
    fbshipit-source-id: bd04244eaf876e3ffab4f0c64792769a9ea40abd
    frantic authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    7dd12a2 View commit details
    Browse the repository at this point in the history
  11. FabricUIManagerModuleTest setup and testCloneNode

    Reviewed By: mdvacca
    
    Differential Revision: D7037558
    
    fbshipit-source-id: a62617c7e16102cf7d12ecde48a95feec264fa51
    ayc1 authored and facebook-github-bot committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    190e6be View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Uses Yargs instead of Command

    Summary: This diff allows Metro to throw an error when a configuration file cannot be found, by using a new strict: true option.
    
    Reviewed By: rafeca
    
    Differential Revision: D6998613
    
    fbshipit-source-id: b704633be18d5c007f1a022fa811d0a74c636fc9
    Maël Nison authored and facebook-github-bot committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    13ee1b5 View commit details
    Browse the repository at this point in the history
  2. Upgrade Jest to 22.4.0 to pull fixes for jest-haste-map

    Reviewed By: mjesun
    
    Differential Revision: D7041111
    
    fbshipit-source-id: 6dbd0cbf7b62a54d0b5f16bbf2fa81332542f14e
    Burak Yigit Kaya authored and facebook-github-bot committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    47e57ef View commit details
    Browse the repository at this point in the history
  3. Fix ESLint warnings using 'yarn lint --fix'

    Summary:
    Hi! I would like to contribute to React Native, and I am just starting out. I forked the repo and found that it has quite a lot of ESLint warnings – many of which were automatically fixable. This PR is simply the result of running `yarn lint --fix` from the root folder.
    
    Most changes are removing trailing spaces from comments.
    
    Haven't really done any manual testing, since I haven't done any code changes manually. `yarn test` runs fine, `yarn flow` runs fine, `yarn prettier` is satisfied.
    
    N/A
    
    [INTERNAL][MINOR][] - Fix ESLint warnings
    Closes facebook#18047
    
    Differential Revision: D7054948
    
    Pulled By: hramos
    
    fbshipit-source-id: d53e692698d1687de5821c3fb5cdb76a5e03b71e
    draperunner authored and facebook-github-bot committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    edb6ca7 View commit details
    Browse the repository at this point in the history
  4. More tests for FabricUIManagerModule

    Reviewed By: mdvacca
    
    Differential Revision: D7045459
    
    fbshipit-source-id: f96758cf04b41836f73b29e62d43a122d955c67a
    ayc1 authored and facebook-github-bot committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    cf0193f View commit details
    Browse the repository at this point in the history
  5. Fix IllegalStateException in looped timing native animation

    Summary:
    This PR fixes regression introduced in facebook#17896 with IllegalStateException being thrown in FrameBasedAnimationDriver.
    
    After investigating it seemed that the root cause was the code responsible for looping animations that was setting next frame time by adding the frame interval to the current time. In some circumstances the next frame would run earlier than that and as a result the calculated frame index was negative.
    
    Here is the stacktrace as reported by axemclion https://github.com/facebook/react-native/pull/17896/files#r170007224
    ```
    Caused by: java.lang.IllegalStateException: Calculated frame index should never be lower than 0
    	at com.facebook.react.animated.FrameBasedAnimationDriver.runAnimationStep(FrameBasedAnimationDriver.java:60)
    	at com.facebook.react.animated.NativeAnimatedNodesManager.runUpdates(NativeAnimatedNodesManager.java:444)
    	at com.facebook.react.animated.NativeAnimatedModule$1.doFrameGuarded(NativeAnimatedModule.java:100)
    	at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
    ```
    
    Run native animated tests suite. Run RNTester and scroll to the loop animation and see it working correctly
    
    [ANDROID][BUGFIX][Animated] - Fix exception thrown by timing animation when looping
    Closes facebook#18061
    
    Differential Revision: D7059335
    
    Pulled By: hramos
    
    fbshipit-source-id: b08dfd1398d028eeeabeb11863743666379da374
    kmagiera authored and facebook-github-bot committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    ef9d1fb View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Fix for facebook#17348, Scrollable failing due to uglify-es

    Summary:
    Fixes facebook#17348 - Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'this._subscribableSubscriptions.forEach')
    
    Same existing tests applies, just added extra checks.
    
    This patch fixes the issue facebook#17348
    
     [ANDROID] [BUGFIX] [Subscribable] - Fix for facebook#17348
     [IOS] [BUGFIX] [Subscribable] - Fix for facebook#17348
    Closes facebook#17463
    
    Reviewed By: sahrens
    
    Differential Revision: D7062101
    
    Pulled By: TheSavior
    
    fbshipit-source-id: 1306f4695ffc8748f674de70740ded09e1e390f7
    iMagdy authored and facebook-github-bot committed Feb 23, 2018
    1 Configuration menu
    Copy the full SHA
    b57a78c View commit details
    Browse the repository at this point in the history
  2. Register ReactRootView into FabricUIManagerModule

    Reviewed By: achen1
    
    Differential Revision: D7043902
    
    fbshipit-source-id: fecef5a019dadd3d2802baa20dd8a3711e566ed3
    mdvacca authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    d352c93 View commit details
    Browse the repository at this point in the history
  3. DevSupportManager: tag RELOAD marker with metro host

    Summary: Adds the configured metro host to `ReactMarker.logMarker(ReactMarkerConstants.RELOAD)`. This may be used for diagnostics in marker listeners
    
    Reviewed By: bnham
    
    Differential Revision: D7041086
    
    fbshipit-source-id: 0b0777b1cd4c74b29b9245e925cf7851b24985fa
    davidaurelio authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    e214bb3 View commit details
    Browse the repository at this point in the history
  4. Upgrade Jest to 22.4.2

    Reviewed By: mjesun
    
    Differential Revision: D7060484
    
    fbshipit-source-id: 91cc7b6d66a2bb99242c144e011eef4393f87e9e
    Burak Yigit Kaya authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    a29906a View commit details
    Browse the repository at this point in the history
  5. Release Metro 0.27.0

    Reviewed By: davidaurelio
    
    Differential Revision: D7067140
    
    fbshipit-source-id: a2ae64a8049e5ef883c08f4abbe108401427b0aa
    Burak Yigit Kaya authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    8d74af4 View commit details
    Browse the repository at this point in the history
  6. react-native: prefer custom source extensions over default extensions

    Reviewed By: mjesun
    
    Differential Revision: D7066617
    
    fbshipit-source-id: cdde7451cb817d62d6705071752fce0686cf04dc
    Jean Lauliac authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    33a893e View commit details
    Browse the repository at this point in the history
  7. BundleDownloader/DevServerHelper: Close http responses

    Reviewed By: amnn
    
    Differential Revision: D7067204
    
    fbshipit-source-id: 9b3dde374280b8d7bdc028a14e9218f37cfc87f2
    davidaurelio authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    87f98bc View commit details
    Browse the repository at this point in the history
  8. Fix Bug with Date Picker IOS

    Reviewed By: sahrens
    
    Differential Revision: D7052609
    
    fbshipit-source-id: 740fffa9ad55ccd21347626f9c5dc180fcc4094d
    Reem Helou authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    446ce49 View commit details
    Browse the repository at this point in the history
  9. Remove Platform check from WebSocket module

    Summary:
    WebSocket uses the Platform module to check how many arguments for the `close` method should be used. In react-native-windows, we have the same number of arguments for `close` as Android, so we're prevented from using this module as-is because of the platform check (see https://github.com/Microsoft/react-native-windows/blob/master/Libraries/WebSocket/WebSocket.windows.js#L136).
    
    By switching to an argument count check, this module becomes more useful cross-platform. If you'd like to keep the platform check, I'm also open to inverting the conditional, e.g., `if (Platform.OS !== 'ios')`.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    I'd like to minimize the amount of code I need to copy over to react-native-windows for platform-specific overrides.
    
    Run jest tests.
    
    N/A
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [GENERAL][MINOR][ENHANCEMENT][Libraries/WebSocket/WebSocket.js] - Better enable cross-platform support of WebSocket.js
    Closes facebook#18056
    
    Differential Revision: D7070380
    
    Pulled By: TheSavior
    
    fbshipit-source-id: 9bfd47654d0bf6f0e07fc799853a206721467525
    rozele authored and facebook-github-bot committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    b9be289 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. JSC bindings for FabricUIManager - Android

    Reviewed By: fkgozali
    
    Differential Revision: D7054214
    
    fbshipit-source-id: 6275a8a3e2a87dfd851a09392f09658538083483
    sebmarkbage authored and facebook-github-bot committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    25b0c37 View commit details
    Browse the repository at this point in the history
  2. update FabricUIManager to call the right JS object

    Reviewed By: sebmarkbage
    
    Differential Revision: D7037275
    
    fbshipit-source-id: 6a1d13227910d0cdb99dde4b6c98ed7a20ef9911
    fkgozali authored and facebook-github-bot committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    486ac9d View commit details
    Browse the repository at this point in the history
  3. Implement Cloning for ART Views

    Reviewed By: achen1
    
    Differential Revision: D7058410
    
    fbshipit-source-id: 394330654be1ab70853f78580c2543e04a3efb7c
    mdvacca authored and facebook-github-bot committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    1b63da7 View commit details
    Browse the repository at this point in the history
  4. Update ReactAndroid build script to support gradle 2.3.0

    Summary:
    We updated to Gradle 2.3.0 and our app's build failed. Our app doesn't provide "repositoryUrl" which is intended to be an optional gradle property. However, Gradle 2.3.0 blows up on findProperty('repositoryUrl') when "repositoryUrl" isn't provided:
    
    ````
    * What went wrong:
    A problem occurred configuring project ':ContextMenuAndroid'.
    > Could not resolve all dependencies for configuration ':ContextMenuAndroid:_debugPublish'.
       > A problem occurred configuring project ':ReactAndroid'.
          > Could not get unknown property 'repositoryUrl' for project ':ReactAndroid' of type org.gradle.api.Project.
    ````
    
    To fix this, we now use "project.hasProperty('repositoryUrl')" to safely detect the presence of the optional "repositoryUrl" property.
    
    Since I cannot check it with your build environment, I've created a small demo to show that "project.hasProperty" properly detects the presence of the gradle property "repositoryUrl". I edited "getRepositoryUrl" to throw an exception if "repositoryUrl" is set:
    
    ````
    def getRepositoryUrl() {
        if (project.hasProperty('repositoryUrl')) throw new GradleException(property('repositoryUrl'))
    
        return project.hasProperty('repositoryUrl') ? property('repositoryUrl') : 'https://oss.sonatype.org/service/local/staging/deploy/maven2/'
    }
    ````
    Then I ran gradle with "repositoryUrl" set like this (passing the property):
    ````
    ./gradlew -PrepositoryUrl=blah assembleDebug
    ````
    
    As expected, it detected that "repositoryUrl" was set and threw an exception:
    ````
    * What went wrong:
    A problem occurred configuring project ':ContextMenuAndroid'.
    > Could not resolve all dependencies for configuration ':ContextMenuAndroid:_debugPublish'.
       > A problem occurred configuring project ':ReactAndroid'.
          > blah
    ````
    
    The same issue has been reported before - facebook#14811, facebook#14810
    
    Minor changes in the Android build script
    Closes facebook#18075
    
    Differential Revision: D7077788
    
    Pulled By: hramos
    
    fbshipit-source-id: ecfbab29d0632e7eecb3c6a247df39bc7616653e
    Sasha Nikiforov authored and facebook-github-bot committed Feb 24, 2018
    1 Configuration menu
    Copy the full SHA
    d8bb990 View commit details
    Browse the repository at this point in the history
  5. added C++ setup for FabricUIManager

    Reviewed By: shergin
    
    Differential Revision: D7077312
    
    fbshipit-source-id: e284c151438eb4d1f67a8386580ab54e3dce7c17
    fkgozali authored and facebook-github-bot committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    0ee0317 View commit details
    Browse the repository at this point in the history
  6. Fix onLayout prop for TextInput on Android

    Summary:
    When the `autogrow` prop was removed from `TextInput` on Android, the `_onLayout` helper method was removed. This helper method implemented the hook required to make `autogrow` work, then dispatched the `onLayout` event to the handler in `this.props`. This change points passes the `onLayout` handler from `this.props` directly to the inner component.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    I was updating copied code in react-native-windows and noticed this bug.
    
    Run jest tests.
    
    N/A
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
     [ANDROID][MINOR][BUGFIX] [TextInput] - Fix `onLayout` prop for TextInput on Android
    Closes facebook#18040
    
    Differential Revision: D7078736
    
    Pulled By: hramos
    
    fbshipit-source-id: 798530729d7f0ee1ebb59f698af4d4b6ff43928b
    rozele authored and facebook-github-bot committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    8a073c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. Fixed problem in Text measurent on iOS

    Summary: See the comment it code.
    
    Reviewed By: mmmulani
    
    Differential Revision: D7074168
    
    fbshipit-source-id: e6eda9a47552142ccb0ba8e7bd9a103b0cb4f9f9
    shergin authored and facebook-github-bot committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    a534672 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Use sync fs.mkdir

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    This ensures that errors are actually noticed in case it is not
    possible to create the directory. This will also throw an error when used with the upcoming Node.js 10.x because there is no callback.
    
    Refs: nodejs/node#18668
    
    [CLI][MINOR][local-cli/library/library.js] - Use sync fs.mkdir for error handling
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#18084
    
    Differential Revision: D7083122
    
    Pulled By: shergin
    
    fbshipit-source-id: a13b64e57860e1ab2c15e0c008211dc0dca3b2d2
    BridgeAR authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    d2817f4 View commit details
    Browse the repository at this point in the history
  2. Add missing mock for AppState (removeEventListener)

    Summary:
    I am testing with Jest a component that use [AppState.removeEventListener](https://facebook.github.io/react-native/docs/appstate.html#removeeventlistener) and I am currently facing a fatal error saying that `AppState.removeEventListener` is `undefined`.
    
    Create a component that uses `AppState`, e.g.
    
    ```jsx
    import React, { Component } from 'react';
    import { AppState } from 'react-native';
    
    class TestComponent extends Component {
      componentDidMount() {
        AppState.addEventListener('change', this.stateChangeListener);
      }
      componentWillUnmount() {
        AppState.removeEventListener('change', this.stateChangeListener);
      }
    }
    ```
    
    It should pass test using Jest (snapshots)
    
    It's the continuation of facebook#11199. This PR finish the mock for the native module `AppState`.
    
    [ GENERAL  ]   [ BUGFIX      ]   [AppState] Add missing mock for Jest for `removeEventListener` method.
    Closes facebook#17908
    
    Differential Revision: D7083144
    
    Pulled By: shergin
    
    fbshipit-source-id: eafa07f064f971c3d657f2ffc9c00766c0925bac
    MoOx authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    59c7b2c View commit details
    Browse the repository at this point in the history
  3. Fix: Added scroll Bounds check in scrollToOffset method in RCTScrollV…

    …iew on iOS
    
    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    The scrollToOffset method of RCTScrollView for iOS does not include bound check for the scroll offset provided to the method. This can cause the whole view to scroll out of screen if the offset provided is greater than the bounds of the View.
    The same does not happen on Android, where the scroll halts once the last item of the scrollView is in the viewport.
    I have added bounds check so the offset resets to the MaxOffset which makes sure the view does not scroll out of the viewport.
    
    The issue can be observed in the following snack:
    https://snack.expo.io/H1363Uo8f
    
    ![ezgif com-optimize 1](https://user-images.githubusercontent.com/16662518/36068270-2437ae88-0ef7-11e8-96dd-819b4ae0fd67.gif)
    
    To test my changes I ran the code provided in the snack above with the react-native dependency pointing to my branch. As can be see in the video attached below, the scroll halts once it hits the end of the ScrollView even if the scroll offset provided is higher than the bounds of the ScrollView. It also does not scroll up for negative scroll offset.
    
    ![ezgif com-optimize](https://user-images.githubusercontent.com/16662518/36068130-9ae4f918-0ef3-11e8-8728-af7b2888bdb8.gif)
    
    [IOS] [BUGFIX] [ScrollView] - Added bounds check to prevent ScrollView from scrolling to an offset which is out of bounds of the ScrollView for iOS.
    Closes facebook#17927
    
    Differential Revision: D7014466
    
    Pulled By: shergin
    
    fbshipit-source-id: a817738d08e1057a4c70f43373132f88fa1461c4
    siddhantsoni authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    16c9e5b View commit details
    Browse the repository at this point in the history
  4. RN: Use $ReadOnly in CoreEventTypes

    Reviewed By: sahrens
    
    Differential Revision: D7082715
    
    fbshipit-source-id: d2f7e280d02bbd8e7dcba2d38b719fa4f82ecb8b
    yungsters authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    a817c64 View commit details
    Browse the repository at this point in the history
  5. RN: Flow Type for PressEvent

    Reviewed By: sahrens
    
    Differential Revision: D7082716
    
    fbshipit-source-id: 13e1730b0b2380ae6be63e2b36bb40b9a44a99f4
    yungsters authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    80c1839 View commit details
    Browse the repository at this point in the history
  6. Allow passing custom configs through the CLI ("js1 run")

    Reviewed By: jeanlauliac
    
    Differential Revision: D7081913
    
    fbshipit-source-id: f5952599c840f2c65213bd2928b21f0c1d84f510
    Miguel Jimenez Esun authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    dabe8e0 View commit details
    Browse the repository at this point in the history
  7. Implement cloning for all ReactShadowNodes

    Reviewed By: achen1
    
    Differential Revision: D7063509
    
    fbshipit-source-id: 90df8a3d2e6f2a4efa13f5eb0337b191b690bf8f
    mdvacca authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    62efff8 View commit details
    Browse the repository at this point in the history
  8. Bump metro@0.28.0

    Reviewed By: davidaurelio
    
    Differential Revision: D7085296
    
    fbshipit-source-id: 76032af022d37a28976b33176f9a573e39861a39
    rafeca authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    bd30336 View commit details
    Browse the repository at this point in the history
  9. Change React Native application layout check

    Reviewed By: shergin
    
    Differential Revision: D7076910
    
    fbshipit-source-id: dc6df2dee886bbdf139d6e50192d621efad6d57e
    ikenwoo authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    3eee96a View commit details
    Browse the repository at this point in the history
  10. Mark ObjC methods that are called from React Native as dynamic.

    Reviewed By: mmmulani
    
    Differential Revision: D7087100
    
    fbshipit-source-id: 18e5726e5b48e7b71fcaab19f6fe73be0cad6233
    mren2 authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    ebbd437 View commit details
    Browse the repository at this point in the history
  11. Add testOnly_pressed to TouchableHighlight

    Reviewed By: yungsters
    
    Differential Revision: D7043098
    
    fbshipit-source-id: 1df06df6820d81b37dc9a167a7931ed20df44f0f
    sahrens authored and facebook-github-bot committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    3756d41 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Explicitly handle null props in bindings

    Reviewed By: fkgozali, mdvacca
    
    Differential Revision: D7080813
    
    fbshipit-source-id: 7c9706df719a39e11a3d99c2de38af992b62dabf
    sebmarkbage authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    84ad5d3 View commit details
    Browse the repository at this point in the history
  2. Clean up unused modules

    Reviewed By: fkgozali
    
    Differential Revision: D7092777
    
    fbshipit-source-id: 619a78911f2857f1183597143aec86957f277f9e
    sebmarkbage authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    07334cb View commit details
    Browse the repository at this point in the history
  3. Catch exception and report it when making a network request with inva…

    …lid URL on Android
    
    Summary:
    Currently if you invoke `fetch()` with an invalid URL ("aaa" for
    example) you cannot catch the error in javascript since it's not
    reported. Instead the entire app crashes.
    
    Fixes facebook#7436 and facebook#18087
    
    Hopefully.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Fix using fetch on Android with user generated input.
    
    Added relevant unit test
    
    `./scripts/run-android-local-unit-tests.sh` all pass
    
    [ANDROID] [BUGFIX] [fetch] - Allow "unexpected url" exception to be caught on Android when using fetch
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#18103
    
    Differential Revision: D7097110
    
    Pulled By: hramos
    
    fbshipit-source-id: 69144e8a0f7404d9bcc7c71a94650de36a48c84a
    jcurtis authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    da84eba View commit details
    Browse the repository at this point in the history
  4. iOS: adjusted JSI binding for C++ FabricUIManager

    Reviewed By: sebmarkbage, shergin
    
    Differential Revision: D7078631
    
    fbshipit-source-id: 6df21e52d3941372a9845fdcf2aed777de7cb359
    fkgozali authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    52acbbd View commit details
    Browse the repository at this point in the history
  5. iOS - expose C++ FabricUIManager to the bridge via a wrapper class

    Reviewed By: shergin
    
    Differential Revision: D7093253
    
    fbshipit-source-id: 7317144ad2cb5b8903227c779798e1576f8de2c2
    fkgozali authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    28c694f View commit details
    Browse the repository at this point in the history
  6. npmignore: ignore tests and fixtures

    Summary:
    This try to address facebook#17672 and facebook/metro#139. We should probably not include these folders in the released version of React Native, as they are used only for testing—am I incorrect?
    
    cc MoOx, t4deu.
    
    I ran:
    
    ```
    npm pack
    tar -t -f react-native-1000.0.0.tgz | less
    ```
    
    Then verified that `__fixture__` was not part of the package.
    
    facebook#17672
    
    [GENERAL] [BUGFIX] [.npmignore] - Do not publish test-specific files
    Closes facebook#18019
    
    Differential Revision: D7098211
    
    Pulled By: jeanlauliac
    
    fbshipit-source-id: 0748ad8c064450bd2a9f4d6f49675a7f74fb300f
    Jean Lauliac authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    a759a44 View commit details
    Browse the repository at this point in the history
  7. Fix crashes onKeyPress Android

    Summary:
    There appear to be two different types of crashes related to the recent addition of `onKeyPress` on Android introduce in `0.53`. This PR addresses the cause of both of them.
    
    Firstly, it seems possible to get an `indexOutOfBoundsException` with some 3rd-party keyboards as observed in facebook#17974 & facebook#17922. I have simplified the backspace determining logic slightly, and also put in an explicit check for zero case so it is not possible to get an indexOutOfBoundsException & it should make sense in the context of the onKeyPress logic.
    
    Secondly, it appears that `EditText#onCreateInputConnection` can return null. In this case, if we set `null` to be the target of our subclass of `ReactEditTextInputConnectionWrapper`, we will see the crashes as seen [here](facebook#17974 (comment)), whereby any of methods executed in the `InputConnection` interface can result in a crash. It's hard to reason about the state when `null` is returned from `onCreateInputConnection`, however I would might reason that any soft keyboard input cannot update the `EditText` with a `null` `input connection`, as there is no way of interfacing with the `EditText`. I'm am not sure, if there is a later point where we might return/set this input connection at a later point? As without the `InputConnection` onKeyPress will not work. But for now, this will fix this crash at least.
    
    I have not managed to reproduce these crashes myself yet, but users have confirmed that the `indexOutOfBounds` exception is fixed with the 'zero' case and has been confirmed on the respective issues facebook#17974 (comment).
    
    For the `null` inputConnection target case, I have verified that explicitly setting the target as null in the constructor of `onCreateInputConnection` results in the same stack trace as the one linked. Here is also a [reference](https://github.com/stripe/stripe-android/pull/392/files#diff-6cc1685c98457d07fd4e2dd83f54d5bb) to the same issue closed with the same fix for another project on github.
    
    It is also important to verify that the behavior of `onKeyPress` still functions the same after this change, which can be verified by running the RNTesterProject and the `KeyboardEvents` section in `InputText`.
    The cases to check that I think are important to check are:
    - Cursor at beginning of input & backspace
    - Return key & return key at beginning of input
    - Select text then press delete
    - Selection then press a key
    - Space key
    - Different keyboard types
    
    This should not be a breaking change.
    
     [ANDROID] [BUGFIX] [TextInput] - Fixes crashes with TextInput introduced in 0.53.
    Closes facebook#18114
    
    Differential Revision: D7099570
    
    Pulled By: hramos
    
    fbshipit-source-id: 75b2dc468c1ed398a33eb00487c6aa14ae04e5c2
    joshjhargreaves authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    b60a727 View commit details
    Browse the repository at this point in the history
  8. Update danger token

    Summary: Closes facebook#18111
    
    Differential Revision: D7099636
    
    Pulled By: hramos
    
    fbshipit-source-id: fc95ba83c34e0061c13fb831ea3496d7e8f3793a
    hramos authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    c87d03a View commit details
    Browse the repository at this point in the history
  9. Support Input Accessory View (iOS Only) [1/N]

    Reviewed By: mmmulani
    
    Differential Revision: D6886573
    
    fbshipit-source-id: 71e1f812b1cc1698e4380211a6cedd59011b5495
    Peter Argany authored and facebook-github-bot committed Feb 27, 2018
    1 Configuration menu
    Copy the full SHA
    38197c8 View commit details
    Browse the repository at this point in the history
  10. Timeout Android instrumentation steps

    Summary:
    Sporadically, the instrumentation tests step will timeout while waiting for the apk to install on the emulator. By adding a 5 minute timeout, the command will be retried in these cases, where hopefully the install will go through.
    
    Test Plan
    
    Tested on Circle.
    Closes facebook#18127
    
    Differential Revision: D7101890
    
    Pulled By: hramos
    
    fbshipit-source-id: 4dcc77153d794e9747df58ea40c011bc316b6c83
    hramos authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    1346bf8 View commit details
    Browse the repository at this point in the history
  11. onPress animation with magnification

    Summary:
    Related to: facebook#15454
    
    Motivation: Improve tvOS feeling for TouchableHighlight
    
    ![changewithaniamtion](https://user-images.githubusercontent.com/7658664/29193477-b99b4a10-7e25-11e7-8b31-e0e4ca9d7720.gif)
    
    - When you select the button he is focus and the underlay is show
    - When you press the button, there is an animation, but after the animation, the focus is on the button and the underlay is show
    
    Play with tvParallaxProperties on tvOS, test with and without patch just to see the actual behaviour
    ```
    			<TouchableHighlight
    						tvParallaxProperties={{
    							enabled: true,
    							shiftDistanceX: 0,
    							shiftDistanceY: 0,
    							tiltAngle: 0,
    							magnification: 1.1,
                                                            pressMagnification: 1.0,
    							pressDuration: 0.3,
    						}}
    						underlayColor="black"
    						onShowUnderlay={() => (console.log("onShowUnderlay")}
    						onHideUnderlay={() =>  (console.log("onHideUnderlay")}
    						onPress={() =>  (console.log("onPress")}
    					>
    						<Image
    							style={styles.image}
    							source={ uri: 'https://www.facebook.com/images/fb_icon_325x325.png' }
    						/>
    					</TouchableHighlight>
    ```
    Closes facebook#15455
    
    Differential Revision: D6887437
    
    Pulled By: hramos
    
    fbshipit-source-id: e18b695068bc99643ba4006fb3f39215b38a74c1
    JulienKode authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    6c353fd View commit details
    Browse the repository at this point in the history
  12. Add possibility to add custom plugin prefix

    Summary: The problem with a fixed prefix is that babel 7 uses a scoped packages and every (standard) plugin is now part of that scope so the prefix is no longer `babel-plugin-` but instead `babel/plugin-`. There are more changes. This one will at least fix most of them.
    
    Reviewed By: davidaurelio
    
    Differential Revision: D7085102
    
    fbshipit-source-id: b927998c611b71b3265e1cb3f6df537b14f9cb25
    Peter van der Zee authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    2dc559d View commit details
    Browse the repository at this point in the history
  13. Xcode 9 supports running multiple simulators

    Summary:
    Since Xcode 9 you can run multiple simultaneously. And since I believe React Native advocates using the latest version of Xcode, we can safely remove this constraint.
    
    Updated the unit tests. Furthermore it can be found in the [Xcode release notes](https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/WhatsNewXcode/xcode_9/xcode_9.html#//apple_ref/doc/uid/TP40004626-CH8-SW12) that multiple simulators are now supported.
    
    This can be tested with the CLI by running `react-native run-ios` twice, but with a different `--simulator` flag, e.g.;
    
        react-native run-ios --simulator "iPhone SE"
        react-native run-ios --simulator "iPhone X"
    
    [IOS] [ENHANCEMENT] [local-cli/runIOS/findMatchingSimulator.js] - Allow running multiple simulators
    Closes facebook#17284
    
    Differential Revision: D7102790
    
    Pulled By: hramos
    
    fbshipit-source-id: 750e7039201e28a1feda2bec1e78144fd9deff98
    koenpunt authored and facebook-github-bot committed Feb 27, 2018
    6 Configuration menu
    Copy the full SHA
    2ad3407 View commit details
    Browse the repository at this point in the history
  14. Fix facebook#8615: NetInfo.isConnected for iOS

    Summary:
    This is fixing facebook#8615. The problem was that, on initialization, the `_connectionType` variable was still set to its default value of `RCTConnectionTypeUnknown`. The exposed API method did nothing to determine this unless a subscription had be established and then the method would simply return the last reported value. Instead, the exposed oneshot API call now actually checks the connection status through the same methods as the subscription and updates RCTNetInfo’s values before returning.
    
    In order to avoid reporting events without a subscription, a flag is set and unset on calls to start/stopObserving.
    
    - start app
    - observe the (in)correct reporting of the manual status
    - change network status to offline
    - press refresh
    - observe the manual fetch
    - start subscription
    - change network status to online
    - press refresh to show that the manual refresh works (only now working for current RN version)
    - change network status to offline
    - stop subscription
    - change network status to online
    - press refresh to show manual refresh does(n't) work without subscription
    - start subscription to show it updates to current
    
    Current Behavior: https://drive.google.com/file/d/1Ods6HORgp_vfm1mQVjGwhtH1D7issxjo/view?usp=sharing
    Fixed Behavior: https://drive.google.com/file/d/11H1UOF33LeMGvXEOoapU62ARDSb7qoYv/view?usp=sharing
    
    [IOS] [BUGFIX] [Libraries\Network\RCTNetInfo.m] - Fixed facebook#8615, `iOS: NetInfo.isConnected returns always false`, by decoupling the fetch from the status of the subscription.
    Closes facebook#17397
    
    Differential Revision: D7102771
    
    Pulled By: hramos
    
    fbshipit-source-id: ea11eb0b1a7ca641fc43da2fe172cf7b2597de4a
    alburdette619 authored and facebook-github-bot committed Feb 27, 2018
    1 Configuration menu
    Copy the full SHA
    dbafc29 View commit details
    Browse the repository at this point in the history
  15. Implement letterSpacing on Android >= 5.0

    Summary:
    `letterSpacing` is completely missing from RN Android at the moment.
    
    I've reviewed the `letterSpacing` implementations in facebook#13199, facebook#13877 and facebook#16801 (that all seem to have stalled) and managed to put together an improved one based on facebook#13199, updated to merge cleanly post facebook@6114f86, that resolves the [issues](facebook#13199 (comment)) I've identified with that code.
    
    I believe this is the closest PR yet to a correct implementation of this feature, with a few caveats:
    
    - As with the other PRs, this only works on Android >= 5.0 (silently falling back to no letter spacing on older versions). Is this acceptable for a RN feature, in general? Would a dev mode warning be desirable?
    - The other PRs seem to have explored the space of potential solutions to the layout issue ([Android renders space _around_ glyphs](https://issuetracker.google.com/issues/37079859), iOS to the _right_ of each one) and come up empty, so I've opted to merely document the difference.
    - I have neither updated nor tested the "Flat" UI implementation - everything compiles but I've taken [this comment](facebook#12770 (comment)) to mean there's no point in trying to wade through it on my own right now; I'm happy to tackle it if given some pointers.
    - The implementation in `ReactEditText` is only there to handle the placeholder text, as `ReactBaseTextShadowNode` already affects the input control's contents correctly.
      - I'm not sure whether `<TextInput>` is meant to respect `allowFontScaling`; I've taken my cue here from `ReactTextInputManager.setFontSize()`, and used the same units (SP) to interpret the value in `ReactEditText.setLetterSpacingPt()`.
      - I'm not sure whether `<TextInput>` is even meant to support `letterSpacing` - it doesn't actually work on iOS. I'm not going to be able to handle the Objective-C side of this, not as part of this PR at least.
    - I have not added unit tests to `ReactTextTest` - is this desirable? I see that some other props such as `lineHeight` aren't covered there (unless I'm not looking in the right place).
    - Overall, I'm new to this codebase, so it's likely I've missed something not mentioned here.
    
    Note comment re: unit tests above; RNTester screenshots follow.
    
    | iOS (existing functionality, amended test) | Android (new functionality & test) |
    | - | - |
    | <img src=https://user-images.githubusercontent.com/2246565/34458459-c8d59498-edcb-11e7-8c8f-e7426f723886.png width=300> | <img src=https://user-images.githubusercontent.com/2246565/34458473-2a1ca368-edcc-11e7-9ce6-30c6d3a48660.png width=300> |
    
    | iOS _(not implemented, test not in this branch)_ | Android (new functionality & test) |
    | - | - |
    | <img src=https://user-images.githubusercontent.com/2246565/34458481-6c60a36e-edcc-11e7-9af5-9734dd722ced.png width=300> | <img src=https://user-images.githubusercontent.com/2246565/34458486-8b3cdcf8-edcc-11e7-974b-25c6085fa674.png width=300> |
    
    | iOS _(not implemented, test not in this branch)_ | Android (new functionality & test) |
    | - | - |
    | <img src=https://user-images.githubusercontent.com/2246565/34458492-d69a77be-edcc-11e7-896f-21212621dbee.png width=300> | <img src=https://user-images.githubusercontent.com/2246565/34458490-b3a1139e-edcc-11e7-88c8-79d4430d1514.png width=300> |
    
    facebook/react-native-website#105 - this docs PR is edited slightly from what's in `TextStylePropTypes` here; happy to align either one to the other after a review.
    
    [ANDROID] [FEATURE] [Text] - Implemented letterSpacing
    Closes facebook#17398
    
    Reviewed By: mdvacca
    
    Differential Revision: D6837718
    
    Pulled By: hramos
    
    fbshipit-source-id: 5c9d49e9cf4af6457b636416ce5fe15315aab72c
    motiz88 authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    5898817 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Increase n days before issue considered stale

    Summary:
    This repository has Probot's [Stale workflow](https://github.com/probot/stale) enabled. It is configured via the `.github/stale.yml` file.
    
    In this PR, we increase number of days before an issue becomes stale to ~six months, and increase days until the same issue is closed after inactivity to ~2 months.
    
    It also limits the stale bot to issues only.
    Closes facebook#18108
    
    Differential Revision: D7105801
    
    Pulled By: hramos
    
    fbshipit-source-id: 23efd41f88c03cb6c0be3820a3b3ac67b3e4a6fe
    hramos authored and facebook-github-bot committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    247f32f View commit details
    Browse the repository at this point in the history
  2. Add option to hide context menu for TextInput facebook#17335

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    There is currently no way to disable to context menu that automatically appears over a TextInput. This is especially troublesome if you would like to disable the user from pasting text into certain fields. This PR adds a `contextMenuHidden` property to TextInput that will hide it.
    
    I'm not sure if testing is necessary here. I would be happy to investigate further on how this would be tested, if deemed necessary!
    
    facebook/react-native-website#95
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [FEATURE][TextInput] - Added `contextMenuHidden` property
    Closes facebook#18125
    
    Differential Revision: D7101888
    
    Pulled By: hramos
    
    fbshipit-source-id: fe36603a3fbdcefbd644251a7ea894ac7e23e5b8
    amhinson authored and facebook-github-bot committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    2dd2529 View commit details
    Browse the repository at this point in the history
  3. Fixed TVOS test failure caused by input accessory view change

    Reviewed By: mmmulani
    
    Differential Revision: D7103353
    
    fbshipit-source-id: 7a1575eff0296017521fc8ca6fe384301849a73e
    Peter Argany authored and facebook-github-bot committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    6d9fe45 View commit details
    Browse the repository at this point in the history
  4. Added InputAccessoryView demo to RNTester [2/N]

    Summary:
    This is an example showing how to use an InputAccessoryView to build an iMessage-like sticky text input
    
    https://youtu.be/89PGsSqtmQU
    
    Reviewed By: sahrens
    
    Differential Revision: D7048456
    
    fbshipit-source-id: 90314a85f3662c2b21aababe2dd46ea5e406604a
    Peter Argany authored and facebook-github-bot committed Feb 28, 2018
    1 Configuration menu
    Copy the full SHA
    84ef7bc View commit details
    Browse the repository at this point in the history
  5. Refactor cloneWithNewChildren method

    Reviewed By: achen1
    
    Differential Revision: D7064266
    
    fbshipit-source-id: 71ef5651893359a257c39a5943812853f8d0dbcd
    mdvacca authored and facebook-github-bot committed Feb 28, 2018
    1 Configuration menu
    Copy the full SHA
    ddcd609 View commit details
    Browse the repository at this point in the history
  6. Add header_namespace to handle cross-platform uses

    Differential Revision: D7101683
    
    fbshipit-source-id: 2a95cd1447d4cc5d796556e3281d08136cd130ff
    mzlee authored and facebook-github-bot committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    35583e5 View commit details
    Browse the repository at this point in the history
  7. Use complete type with unique_ptr

    Reviewed By: fromcelticpark
    
    Differential Revision: D7114324
    
    fbshipit-source-id: c9305c478ebe31ea35b590b861919fd42f56662d
    smeenai authored and facebook-github-bot committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0d03fdd View commit details
    Browse the repository at this point in the history
  8. Use #include instead of #import

    Reviewed By: compnerd
    
    Differential Revision: D7114385
    
    fbshipit-source-id: a443770910714aab1af3f3ac5e932f6aaf1afe99
    smeenai authored and facebook-github-bot committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0bc80e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. Simplify issue template

    Summary:
    Reduce the amount of text people have to read through when opening a new issue.
    Closes facebook#18140
    
    Differential Revision: D7117467
    
    Pulled By: hramos
    
    fbshipit-source-id: 4e976adc44a283ab6d5729e5dd2eaa095871c009
    hramos authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    dd187a2 View commit details
    Browse the repository at this point in the history
  2. Do not mention people, suggest labels

    Summary:
    GitHub notifications have been made noisier with these automatic mentions. We can rely on the automatic reviewer tags instead.
    
    Also: suggest labels that may be used, based on release notes (the danger bot cannot add labels itself).
    Closes facebook#18138
    
    Differential Revision: D7114654
    
    Pulled By: hramos
    
    fbshipit-source-id: 0d85879f937921543935d090c792ea09f53cb84a
    hramos authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    4c82ce4 View commit details
    Browse the repository at this point in the history
  3. React sync for revisions a634e53...ab4280b

    Reviewed By: bvaughn
    
    Differential Revision: D7077686
    
    fbshipit-source-id: de39027bef1f9d48802202555a5c765999d7bfe7
    hramos authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    1605786 View commit details
    Browse the repository at this point in the history
  4. workaround android-only js module resolution issue

    Summary: for some reason metro was not able to find js module with just .android.js variant. To workaround some build issue, added an empty .ios.js variant
    
    Reviewed By: mdvacca
    
    Differential Revision: D7115360
    
    fbshipit-source-id: 40b95cf2efc4d3d599f39b88813469b6d78e7b48
    fkgozali authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c20e0f9 View commit details
    Browse the repository at this point in the history
  5. iOS: pass fabric flag down to RCTRootView/RCTSurface for proper unmou…

    …nting
    
    Reviewed By: shergin
    
    Differential Revision: D7119220
    
    fbshipit-source-id: 7a822036e29e0d92f53a164acba2ab75e883b5c4
    fkgozali authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    006b77f View commit details
    Browse the repository at this point in the history
  6. Make two separate yoga targets for QE

    Reviewed By: emilsjolander
    
    Differential Revision: D7059278
    
    fbshipit-source-id: dd11b018edc8ea930d5eba09c6c01e349bb8b63c
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    af9d647 View commit details
    Browse the repository at this point in the history
  7. Change NaN with large number

    Reviewed By: emilsjolander
    
    Differential Revision: D6969537
    
    fbshipit-source-id: bdc09eaf703e0d313ca65c25a4fb44c99203d9bf
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    d174ab8 View commit details
    Browse the repository at this point in the history
  8. Remove optional parameter from server and enforce empty list everywhere

    Reviewed By: jeanlauliac
    
    Differential Revision: D6999448
    
    fbshipit-source-id: 39a6b9333e3c3ec05bae5423fcc84ad17e1fdc06
    Miguel Jimenez Esun authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    8a7f68e View commit details
    Browse the repository at this point in the history
  9. Check PATENTS does not creep into files

    Summary:
    Some files have crept into the repo with the old license header. These are usually from PRs that were opened prior to the re-licensing of the project.
    
    Let the script run, prior to fixing the errant files. The script outputs the following:
    
    ```
    PATENTS crept into some new files?
     --- /dev/fd/63	2018-03-01 01:42:48.250153746 +0000
    +++ /dev/fd/62	2018-03-01 01:42:48.250153746 +0000
    @@ -1 +1,9 @@
    +Libraries/NativeAnimation/Nodes/RCTTrackingAnimatedNode.h
    +Libraries/NativeAnimation/Nodes/RCTTrackingAnimatedNode.m
    +ReactAndroid/src/main/java/com/facebook/react/animated/TrackingAnimatedNode.java
    +ReactAndroid/src/main/java/com/facebook/react/views/text/CustomLetterSpacingSpan.java
    +ReactCommon/yoga/yoga/YGLayout.cpp
    +ReactCommon/yoga/yoga/YGLayout.h
    +ReactCommon/yoga/yoga/YGStyle.cpp
    +ReactCommon/yoga/yoga/YGStyle.h
     scripts/circleci/check_license.sh
    Exited with code 1
    ```
    
    Fix the headers in these files and run the script again. No output, exit code 0.
    Closes facebook#18143
    
    Reviewed By: sophiebits
    
    Differential Revision: D7119356
    
    Pulled By: hramos
    
    fbshipit-source-id: d238e4d4a3ae320a2c8e625c2fa29690057a4814
    hramos authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    b181b77 View commit details
    Browse the repository at this point in the history
  10. Create UIManager interface and extract common classes in uimanager/co…

    …mmon
    
    Reviewed By: achen1
    
    Differential Revision: D7102674
    
    fbshipit-source-id: e14b6782ad102ec1c3d37988df4bbd4190511f09
    mdvacca authored and facebook-github-bot committed Mar 1, 2018
    2 Configuration menu
    Copy the full SHA
    6b45fb2 View commit details
    Browse the repository at this point in the history
  11. Adding configuration of Fabric inside ReactRootView.

    Reviewed By: achen1
    
    Differential Revision: D7102701
    
    fbshipit-source-id: f655327372c42ad86042011a3af3ee693d14014a
    mdvacca authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    b5b0ee8 View commit details
    Browse the repository at this point in the history
  12. Adding simple View rendering support using FabricUIManager.

    Reviewed By: achen1
    
    Differential Revision: D7102725
    
    fbshipit-source-id: d2878d036843ba01201c4df617680269b5f59039
    mdvacca authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c0c388c View commit details
    Browse the repository at this point in the history
  13. Fix unmount of ReactRootView for Fabric surfaces

    Reviewed By: fkgozali
    
    Differential Revision: D7114865
    
    fbshipit-source-id: f0a1c47c983e610fe0dba3051ed8aa350ac052cc
    mdvacca authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    9b3861c View commit details
    Browse the repository at this point in the history
  14. Log java error messages from FabricUIManagerModule

    Reviewed By: mdvacca
    
    Differential Revision: D7126177
    
    fbshipit-source-id: bafa6e2b3dabf39d2ca0d9a8830b877fc5ae97ec
    ayc1 authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    3f85dc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Add extra information to error message reported when a ReactRawText i…

    …s included as a child of a non Text component
    
    Reviewed By: achen1
    
    Differential Revision: D7120188
    
    fbshipit-source-id: 553a26d04a62dceb86d791bcdcb3a5e16a12f64b
    mdvacca authored and facebook-github-bot committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    22990c3 View commit details
    Browse the repository at this point in the history
  2. Added an Assertion that addRoot is called before completeRoot

    Reviewed By: mdvacca
    
    Differential Revision: D7127321
    
    fbshipit-source-id: a8215fda0d854471bed9aa5476141dfffc4dc11c
    ayc1 authored and facebook-github-bot committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    6404529 View commit details
    Browse the repository at this point in the history
  3. Fix appendChild

    Reviewed By: mdvacca
    
    Differential Revision: D7128443
    
    fbshipit-source-id: 4eedea4df2b636eb9589cbe5e84c5c6a8aa33539
    ayc1 authored and facebook-github-bot committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    78b3065 View commit details
    Browse the repository at this point in the history
  4. Avoid var specific hoisting rules

    Reviewed By: sahrens
    
    Differential Revision: D7116184
    
    fbshipit-source-id: 4fd1654028e52f5aafad348546b889f1737c7399
    elicwhite authored and facebook-github-bot committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7216079 View commit details
    Browse the repository at this point in the history
  5. Make the chrome debugger handle dynamic delta ids

    Differential Revision: D7112419
    
    fbshipit-source-id: 1d80c0c13144dd19bbcd5535383befc6567cacf7
    rafeca authored and facebook-github-bot committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    7be3d1c View commit details
    Browse the repository at this point in the history
  6. Expose React Native version as a symbol rather than macro

    Summary:
    Add RCTGetReactNativeVersion() to expose version in native code. Right now, version is exposed internally to RN using a MACRO constant. This exposes a symbol (function) that can be called to retrieve the React Native version in iOS.
    
    Also exposed RCTVersion.h as a public header in the React project so it is available to developers.
    
    The motivation behind this is for https://github.com/wix/detox —we need to know what RN version the user has, if any, so we can properly handle support and abstract differences.
    
    Ran bump-oss-version.js to ensure the template is applied properly. Also compiled the project to make sure nothing is broken.
    
     [IOS] [ENHANCEMENT] [RCTVersion.h] - Expose version as a compile-time symbol for native queries
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#18136
    
    Differential Revision: D7141076
    
    Pulled By: hramos
    
    fbshipit-source-id: 18a92b8c60d7b43fa0ed22597ea46a35cff73c56
    LeoNatan authored and facebook-github-bot committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    30469ed View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Mark targets as explicitly Android

    Reviewed By: mmmulani
    
    Differential Revision: D7141568
    
    fbshipit-source-id: 6c8679790309e72ca220443ecf693087f82ece85
    mzlee authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    5d3efa7 View commit details
    Browse the repository at this point in the history
  2. Refactor FabricUIManagerModule -> FabricUIManager

    Reviewed By: fkgozali
    
    Differential Revision: D7125829
    
    fbshipit-source-id: 46f9722a20e0bbf7f99a0cc36067035b009d73d8
    mdvacca authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    0d148ad View commit details
    Browse the repository at this point in the history
  3. Wrap global variables in extern C

    Reviewed By: compnerd
    
    Differential Revision: D7144899
    
    fbshipit-source-id: d40bda0e9225734398e35adc582b8932c0280b24
    smeenai authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    ffcd067 View commit details
    Browse the repository at this point in the history
  4. iOS: Introduced RCTSurfaceHostingProxyRootView for migration to RCTSu…

    …rfaceHostingView
    
    Summary:
    To help with migration from direct usages of RCTRootView to RCTSurfaceHostingView, RCTSurfaceHostingProxyRootView is added, which is simply a custom impl of RCTSurfaceHostingView, but will all RCTRootView APIs preserved. This makes it easy to do a drop-in replacement in native callsites:
    
    ```
    // before:
    RCTRootView *rootView = [[RCTRootView alloc] init...];
    
    // after:
    RCTRootView *rootView = (RCTRootView *)[[RCTSurfaceHostingProxyRootView alloc] init...];
    ```
    
    Reviewed By: shergin
    
    Differential Revision: D7141696
    
    fbshipit-source-id: db8c447749eaa896efaa37774a9babef132128eb
    fkgozali authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    34b8876 View commit details
    Browse the repository at this point in the history
  5. Truncate filter label if it's too long to fit

    Differential Revision: D7144192
    
    fbshipit-source-id: 4001930b194421682fa9bdc9b097434910f339b6
    SnowCoderAlex authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    f734357 View commit details
    Browse the repository at this point in the history
  6. Converting Libraries/Components to not use var

    Reviewed By: sahrens
    
    Differential Revision: D7117137
    
    fbshipit-source-id: a55a04928a0073a17e0709e851aa8b11678042ba
    elicwhite authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    3152e93 View commit details
    Browse the repository at this point in the history
  7. Tightening type for flattenStyle

    Reviewed By: yungsters
    
    Differential Revision: D7131703
    
    fbshipit-source-id: d8e37fcd0c743057e04760b1e50f8d879bd2826a
    elicwhite authored and facebook-github-bot committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    70a3ece View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Reënable iOS and tvOS tests

    Summary:
    Although the test suites have a handful of failing tests, the jobs themselves do not fail.
    
    Let's get these tests back into the fold so that we may track our progress getting these back to a good state.
    
    cc dlowder-salesforce
    
    Run tests on Circle, and confirm everything is green: https://circleci.com/workflow-run/4dd1a84b-502d-4ad6-aa41-64c768392a6b
    
    If you go into the test iOS and test tvOS jobs, you will see that we are collecting test results at the top. These results show the failing individual tests.
    Closes facebook#18171
    
    Differential Revision: D7151558
    
    Pulled By: hramos
    
    fbshipit-source-id: f105ec8bc97e80ed1b8358cde3f13a1ad3b271c2
    hramos authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    498cf7e View commit details
    Browse the repository at this point in the history
  2. Fix Viewpager on Android when using native navigation.

    Summary:
    See the "broken" video attached to really understand the problem easily.
    
    On Android after navigating to any other screen using wix navigation library, the native viewpager would lose the settling page behaviour which is quite annoying for the users.
    
    This is caused by the onAttachedToWindow that resets mFirstLayout to true inside ViewPager. By request another layout pass, everything works as expected.
    
    Working video is the application with patched RN.
    
    [broken.mp4](https://github.com/facebook/react-native/files/1128028/broken.mp4.zip)
    [working.mp4](https://github.com/facebook/react-native/files/1128032/working.mp4.zip)
    Closes facebook#14867
    
    Differential Revision: D7154981
    
    Pulled By: hramos
    
    fbshipit-source-id: 2b3570800a5320ed2c12c488748d9e1358936c84
    ruiaraujo authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    a1295e1 View commit details
    Browse the repository at this point in the history
  3. Move fb_xplat_cxx.bzl to xplat/build_defs

    Reviewed By: mzlee, ttsugriy
    
    Differential Revision: D7152463
    
    fbshipit-source-id: ad7ca85f225343a043e2f606c6b3bbf74f42bbcd
    Jonathan Kim authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    f389ad8 View commit details
    Browse the repository at this point in the history
  4. Remove log in JSDevSupportModule

    Reviewed By: fkgozali
    
    Differential Revision: D7138115
    
    fbshipit-source-id: f9cdda250b60a305195e01a11d0907f658d0a9d1
    mdvacca authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8769057 View commit details
    Browse the repository at this point in the history
  5. Revert "Better Android Gradle Plugin 3.x integration"

    Summary:
    This reverts commit d16ff3b.
    
    Currently breaks with the gradle version used by RN, I think there has been some work to update that to a more recent one but for now I think we should just revert it.
    
    It errors with:
    
    ```
    Could not find method registerGeneratedResFolders() for arguments [file collection] on object of type com.android.build.gradle.internal.api.ApplicationVariantImpl.
    ```
    
    Tested that RN tester now builds when using the right react.gradle (facebook#18188)
    
    [ ANDROID ] [ BUGFIX ] [ react.gradle ] - REVERT "Support Android Gradle Plugin 3.x and AAPT2"
    [ ANDROID ] [ FEATURE ] [ react.gradle ] - REVERT "Expose the bundling task and its outputs via ext properties"
    Closes facebook#18189
    
    Differential Revision: D7155176
    
    Pulled By: hramos
    
    fbshipit-source-id: 87b7b80b39cd345eebac4631efe6697971a1dbdf
    janicduplessis authored and facebook-github-bot committed Mar 5, 2018
    1 Configuration menu
    Copy the full SHA
    3f8a04b View commit details
    Browse the repository at this point in the history
  6. Use react.gradle from repo root instead of copy in RNTester

    Summary:
    RNTester used a copy of the main react.gradle file instead of the real one. Recent changes to the real file caused builds to fail with older gradle versions but was not caught by CI because it wasn't using that file for RNTester. That copy of react.gradle is just a leftover from when projects included a copy instead of importing the one in RN directly.
    
    Note: CI WILL fail with this PR, if we have trouble landing this I can add the revert in this commit too but wanted to keep it as 2 separate commits.
    
    Tested that building RNTester actually fails now that it uses react.gradle with recent changes, then tested that is builds properly when reverting d16ff3b.
    
    [INTERNAL] [MINOR] [RNTester] - Use react.gradle from repo root instead of copy in RNTester
    Closes facebook#18188
    
    Differential Revision: D7155179
    
    Pulled By: hramos
    
    fbshipit-source-id: 15b461a63b841bf807e7d11ba3ead005ca5e33b0
    janicduplessis authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    9f239d7 View commit details
    Browse the repository at this point in the history
  7. Refactor BridgeListener into JSIModulesProvider

    Reviewed By: achen1
    
    Differential Revision: D7140944
    
    fbshipit-source-id: 092ea8569af5b5f90e005d6dc2c1819c1c9cf58f
    mdvacca authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    4466b6f View commit details
    Browse the repository at this point in the history
  8. Update VirtualizedList to not throw with double constructor

    Summary: constructor shouldn't have side effects.
    
    Reviewed By: sahrens
    
    Differential Revision: D7146018
    
    fbshipit-source-id: 0ca311e48d6bad81988ed48605c8134068c482da
    sophiebits authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    19b9851 View commit details
    Browse the repository at this point in the history
  9. Update node-notifier (has mem leak fix)

    Summary:
    Noticed that we're on a version of node-notifier that has a leak mentioned [here](mikaelbr/node-notifier#183) and fixed in the newest version.
    
    Automated tests
    
     [INTERNAL] [BUGFIX] [package.json] - Update node-notifier dependency
    Closes facebook#18033
    
    Differential Revision: D7102637
    
    Pulled By: hramos
    
    fbshipit-source-id: 850f3d826c1d880a6281d95e4d5af68e9af89927
    rickhanlonii authored and facebook-github-bot committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    860fcd4 View commit details
    Browse the repository at this point in the history
  10. Remove callFunctionSync experimental APIs

    Reviewed By: michalgr
    
    Differential Revision: D6124038
    
    fbshipit-source-id: 219afe30783da92cf10f800dc35e64823b61cf4b
    Dan Zimmerman authored and facebook-github-bot committed Mar 5, 2018
    1 Configuration menu
    Copy the full SHA
    19a4a7d View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Update opacity when disabled prop is changed

    Summary:
    fixes facebook#17105
    
    If you render
    
    ```
        <TouchableOpacity
            disabled={true}
            style={{opacity: 0.5}}
        >
            ...
        </TouchableOpacity>
    ```
    
    and then
    
    ```
        <TouchableOpacity
            disabled={false}
            style={{opacity: 1}}
        >
            ...
        </TouchableOpacity>
    ```
    
    The content of `TouchableOpacity` will still have opacity = 0.5 because real
    opacity is controlled by animated property which should be properly updated
    when `disabled` prop changes.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Usually when a button or other UI component is built with `TouchableOpacity` you may want to change it's opacity if state of component is changed (enabled/disabled). Opacity provided in props is overridden with internally-managed animated value. Add extra check when component is updated to trigger opacity animation upon change of `disabled` flag.
    
    You can use code from facebook#17105.
    
    (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
    
    [GENERAL][BUGFIX][TouchableOpacity] - trigger animation on `opacity` upon change in `disabled` prop.
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#17106
    
    Differential Revision: D7158549
    
    Pulled By: hramos
    
    fbshipit-source-id: 209cc433b829b129810e8a884964c8853ca3fe8f
    maxkomarychev authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    9366ce4 View commit details
    Browse the repository at this point in the history
  2. iOS: branch out Fabric handling into a separate RCTSurface-compatible…

    … class.
    
    Reviewed By: mmmulani
    
    Differential Revision: D7158824
    
    fbshipit-source-id: 80eb61835181fa3f522b788e2861470cba88890a
    fkgozali authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b4ce427 View commit details
    Browse the repository at this point in the history
  3. Remove polymorphic types from StyleSheetTypes

    Summary:
    These types were polymorphic so that stricter types could be passed in for dimension or color. For example, color could be a union of allowed colors. However, since `rgb(0,0,0)` is a valid color, these would have to be allowed opaque types and every creator or caller of these colors would have to use a function.
    
    This would require a massive change to every RN product in the world for negligable gain because StyleSheet values are validated at dev at runtime and cause redboxes for invalid uses.
    
    Since we don't plan to adopt these widely, lets clean up the complexity of these types.
    
    Reviewed By: sahrens
    
    Differential Revision: D7158920
    
    fbshipit-source-id: c58ae402c8248b0863c217c27153191a49c6b980
    elicwhite authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b98bf1e View commit details
    Browse the repository at this point in the history
  4. Using ReadOnly and Exact types for StyleSheet

    Summary: There are a few more things that need to be tightened up but they cause *tons* of errors in FBSource and require more investigation before we can change them.
    
    Reviewed By: sahrens
    
    Differential Revision: D7160522
    
    fbshipit-source-id: 17167efd80fd6c3bac5a055d2ab58b3b251c1b8b
    elicwhite authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b6c7e55 View commit details
    Browse the repository at this point in the history
  5. Fix lint in StyleSheet.compose

    Reviewed By: TheSavior, yungsters
    
    Differential Revision: D7106910
    
    fbshipit-source-id: e150c6622bb1af9830eef06757897d42002f5676
    sahrens authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    52c7957 View commit details
    Browse the repository at this point in the history
  6. Fix subtle bugs in cloning and FabricUIManager

    Reviewed By: achen1
    
    Differential Revision: D7164980
    
    fbshipit-source-id: 86e9f3f11b67c8947b177aac23f99808083c3121
    mdvacca authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    ac929ef View commit details
    Browse the repository at this point in the history
  7. Generalize JavaOnlyMap's getMap

    Reviewed By: mdvacca
    
    Differential Revision: D7165678
    
    fbshipit-source-id: 3dd88b24c89af369c9d5f3cc57c96f29c4f10d47
    ayc1 authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    e839c91 View commit details
    Browse the repository at this point in the history
  8. Adding tests to cover regressions when upgrading to babel 7

    Reviewed By: mjesun
    
    Differential Revision: D7123659
    
    fbshipit-source-id: f344786dfe5e4c6c0d81992504ba93688edeb5db
    Peter van der Zee authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    6eef7de View commit details
    Browse the repository at this point in the history
  9. Add support to FabricUIManger to handle Throwable

    Reviewed By: achen1
    
    Differential Revision: D7168684
    
    fbshipit-source-id: c655730b5bf5e181974096c2b940f6457be8a40d
    mdvacca authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    d2f0574 View commit details
    Browse the repository at this point in the history
  10. Add support for Android TV devices

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    * To be on par with Apple TV support, this makes it possible to run React Native apps on Android TV devices (See also: https://react-native.canny.io/feature-requests/p/android-tv-support)
    * These changes also make it possible to navigate through the app using D-PAD buttons that are present on some mobile devices
    * Since these changes affect, among others, `ReactRootView.java` and `Touchable.js` code and are closely related to Apple TV implementation, it makes sense for them to be included in the core
    
     - React native apps can be launched on Android TV devices and properly render their content
     - Navigation is possible using left, right, top, bottom arrows from the remote (or D-PAD)
     - Touchable components can handle D-PAD center button press events and correctly fire their `onPress` handlers
     - Touchable components will receive `onPressIn` and `onPressOut` events and can react to focus/blur changes appropriately (just like on Apple TV)
     - `Platform` constants allow to check if the react-native app is running on TV (`Platform.isTV`)
     - `ScrollView`s behave correctly (same as native implementation) when switching to view outside bounds – that is, the container would scroll such that the newly focused element is fully visible
     - Native "clicking" sounds are played when moving between focusable elements
     - Play/Pause click event is send to `TVEventHandler`
     - Rewind and FastForward events are send to `TVEventHandler`
     - Back button behaves as a normal Android back button
     - Diagonal buttons work correctly on Android TV, e.g. if there is no button directly to the right from the focused one, but there is one to the right but a bit higher/lower it will grab focus
     - Dev menu can be accessed by long pressing fast forward button
    
    A demo showing RNTester app running on Android TV device (Amazon Fire TV Stick) can be found here:
    [![RNAndroidTVDemo](http://img.youtube.com/vi/EzIQErHhY20/0.jpg)](http://www.youtube.com/watch?v=EzIQErHhY20)
    
    - `TextInput` will not work on Android TV devices. There's an issue with native `ReactEditText` implementation that prevents it from receiving focus. This makes it impossible to navigate to `TextInput`.
    This will be fixed next, but will be included in a separate Pull Request
    - ~Overlay permissions cannot be granted on Android TV devices running Android version >= 6.0
    This is because the overlay permission can only be granted by firing an Intent to open settings page (`ACTION_MANAGE_OVERLAY_PERMISSION`). Since this page does not exist on TV devices the permission cannot be requested. This will make the app crash when trying to open dev menu (⌘+M) or displaying a redbox error.
    Note: This does not affect devices running Android version < 6.0 (for example Amazon Fire TV Stick)~
    This is now fixed by: facebook#16596
    
    * Launch the RNTester app on Android TV device.
      * Ensure it launches without a crash
      * Ensure basic navigation is possible
      * Ensure Touchable components can receive select events
    * Ensure the changes do not break current Android and iOS mobile devices functionality.
    * Ensure the changes do not break current Apple TV functionality.
    
    [RNAndroidTVDemo video](http://img.youtube.com/vi/EzIQErHhY20/0.jpg)
    
    * Added `ReactAndroidTVViewManager` that handles TV `KeyEvent`s and dispatches events to JS - This is the core that enables basic navigation functionality on Android TV devices
    * Following the above change we copy `TVEventHandler.ios.js` into `TVEventHandler.android.js` to enable JS to pick up those native navigation events and dispatch them further to subscribed views. (Note: We do not have a native `TVNavigationEventEmitter` implementation on Android, thus this file is slightly modified, e.g. it does pass `null` to `NativeEventEmitter` constructor)
    * Added `uiMode` to `AndroidInfoModule`. (**Note**: This required changing `extends BaseJavaModule` to `extends ReactContextBaseJavaModule` to be able to use `getSystemService` which requires `Context` instance!
    * Added `isTV` constants to both `Platform.ios.js` (keeping the deprecated `isTVOS` as well) and `Platform.android.js`
    * Changed condition check on `Touchable.js` to use the newly added `isTV` flag to properly handle TV navigation events on Android as well
    * Added `LEANBACK_LAUNCHER` to `RNTester` `intent-filter` so that it is possible to launch it on Android TV devices.
    * See also a PR to `react-native-website` repo with updated docs for Android TV: facebook/react-native-website#59
    
     - [ ] Fix `TextInput` components handling by allowing them to be focused and making a proper navigation between them (and/or other components) possible. One thing to note here that the default behavior to immediately open software keyboard when focused on `TextInput` field will need to be adjusted on Android TV as well)
     - [x] Fix overlay permissions issue by changing the way redbox/dev menu are displayed (see: facebook#16596)
     - [ ] Adjust placement of TV-related files (e.g. the `TVEventHandler.js` file is placed inside `AppleTV` directory which is not accurate, since it does handle Android TV events as well)
    
    Previous discussion: software-mansion-labs#1
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAl  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [ANDROID] [FEATURE] [TV] - Added support for Android TV devices
    Closes facebook#16500
    
    Differential Revision: D6536847
    
    Pulled By: hramos
    
    fbshipit-source-id: 17bbb11e8583b97f195ced5fd9762f8902fb8a3d
    Krzysztof Ciombor authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    b7bb2e5 View commit details
    Browse the repository at this point in the history
  11. Add RCTJavaScriptWillStartExecutingNotification

    Summary:
    `RCTJavaScriptWillStartLoadingNotification` is being posted when starting the bridge, not when starting to execute JS code.
    
    Here, we add `RCTJavaScriptWillStartExecutingNotification`, and in post it before executing JS with `RCTCxxBridge`.
    
    Reviewed By: fromcelticpark
    
    Differential Revision: D7153659
    
    fbshipit-source-id: 902075308d54a47bef43b6f57edf2e624f621ceb
    davidaurelio authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    48c339d View commit details
    Browse the repository at this point in the history
  12. iOS: RCTSurface needs to re-register its root view on bridge reload

    Summary: When reloading JS during development, surface needs to make sure the root view gets re-registered before attempting to remount it. This fixes redbox on JS reload.
    
    Reviewed By: shergin
    
    Differential Revision: D7170416
    
    fbshipit-source-id: c84b999d2cdc35cb9e26feef2a1e1a7ce35cfa70
    fkgozali authored and facebook-github-bot committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    2e51fa5 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Add Fabric test for text nodes

    Reviewed By: mdvacca
    
    Differential Revision: D7165356
    
    fbshipit-source-id: ab5b019943d0d6f759bdb16ca646e34a2ef79e23
    ayc1 authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    e7b8341 View commit details
    Browse the repository at this point in the history
  2. Clean up FabricUIManagerViewHierarchyTest

    Reviewed By: mdvacca
    
    Differential Revision: D7165823
    
    fbshipit-source-id: e6d2a83bf9e089c67d69de6581d177bdf0d2ec4e
    ayc1 authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    6fc4163 View commit details
    Browse the repository at this point in the history
  3. check for GET and Head in send request

    Summary:
    React Native had an underlying problem connecting to Firestore (Google's latest database) from Android devices. You can follow the issue [here](firebase/firebase-js-sdk#283).
    The main problem was in NetworkingModule.java. Please refer to section 3 of 4.5.6 in whatwg.org's guideline https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
    
    In this [video](https://www.youtube.com/watch?v=tILagf46ys8), I am showing how the react native behaved before adding the new fix and how it worked after the new fix added.  The new fix starts at 50 seconds.
    
    [ANDROID] [BUGFIX] [FIRESTORE][XMLHttpRequest][ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java] - Fixes the connection to Firestore by following whatwg.org's XMLHttpRequest send() method
    Closes facebook#17940
    
    Differential Revision: D7173468
    
    Pulled By: hramos
    
    fbshipit-source-id: 354d36f03d611889073553b93a7c43c6d4363ff3
    samsafay authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    d52569c View commit details
    Browse the repository at this point in the history
  4. Allow Inspector to handle 2 renderers

    Summary: To avoid crashing when there are 2 different renderers, let the Inspector be a bit lenient.
    
    Reviewed By: yungsters
    
    Differential Revision: D7175338
    
    fbshipit-source-id: ee5f86252f090361e42b6e2a93ae56c4c83c8c53
    fkgozali authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    d7b5b2e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c129457 View commit details
    Browse the repository at this point in the history
  6. Type TextStyleProp

    Reviewed By: yungsters
    
    Differential Revision: D7176472
    
    fbshipit-source-id: 35f499bdac6c089d5f45884f6f11ea539c8b7085
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    321ba06 View commit details
    Browse the repository at this point in the history
  7. Merging tests for flattenStyle

    Reviewed By: yungsters
    
    Differential Revision: D7176652
    
    fbshipit-source-id: 25b6f2e4f8397ba6f07b2913775b91af90b45750
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    135637c View commit details
    Browse the repository at this point in the history
  8. Remove Unused Exports from StyleSheetTypes

    Summary: These types were barely used and unnecessary.
    
    Reviewed By: yungsters
    
    Differential Revision: D7177287
    
    fbshipit-source-id: 63cb6d3aae4889a92b2c23f0df864b5657e6e1ee
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    b58e377 View commit details
    Browse the repository at this point in the history
  9. Fixing bugs in link and unlink

    Summary:
    Android uses the name of the package, not the config, for the `isInstalled` check. Sending both parameters to `isInstalled` so we have a consistent API.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    A bug was uncovered in the react-native link command where Android would not unlink because the wrong parameters were being sent to `isInstalled`.
    
    Successfully linked and unlinked `react-native-fs` on Windows and Mac. Jest tests pass.
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [CLI][BUGFIX][local-cli/link/link.js] - Fix issue with `isInstalled` check for Android
    [CLI][BUGFIX][local-cli/link/unlink.js] - Fix issue with `isInstalled` check for Android
    [CLI][BUGFIX][local-cli/link/ios/common/unregisterNativeModule.js] - Fix references to unregister implementations.
    Closes facebook#18207
    
    Differential Revision: D7180885
    
    Pulled By: hramos
    
    fbshipit-source-id: 5f479cd9d7b1ebd8626b461e9dc1f22988e2c61f
    rozele authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    ec88489 View commit details
    Browse the repository at this point in the history
  10. iOS Surface: properly reset some internal states when JS reloads

    Summary:
    There are a few important states that didn't reset correctly when reloading JS:
    * the RCTSurfaceStage was stuck at all bits enabled, hence no further stage change happened (even though the state "reset" to `RCTSurfaceStageBridgeDidLoad`)
    * the RCTSurfaceView didn't get recreated, because the _view ivar was never cleared
    * similarly, the _touchHandler ivar attached to the _view was never re-setup --> all touches after JS reload were dropped before this diff
    
    Reviewed By: mmmulani
    
    Differential Revision: D7178038
    
    fbshipit-source-id: ba49bc205f8bf43842471b7ab748cef8549ea212
    fkgozali authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    cade297 View commit details
    Browse the repository at this point in the history
  11. Make StyleSheet.create type private

    Summary:
    This type is being used in many places where a much simpler type is often better. In a real pinch this type can still be accessed as so:
    
    ```
    function returnsStyleSheet(
    ): $Call<typeof StyleSheet.create, *> {
      return StyleSheet.create({
        root: {
          background: 'white',
        }
      })
    }
    
    returnsStyleSheet().foo // foo doesn't exist
    returnsStyleSheet().root // okay
    ```
    
    Reviewed By: yungsters
    
    Differential Revision: D7178524
    
    fbshipit-source-id: 3c0ed03486ca00f1e287261e402fd47807f1fc3d
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    ee26d9b View commit details
    Browse the repository at this point in the history
  12. Rename StyleProp to DangerouslyImpreciseStyleProp

    Summary:
    We want to rename these types to be more clear what they are actually for. I did this with a find and replace:
    
    ```
    import type {StyleProp} from 'StyleSheet';
    ```
    
    to
    
    ```
    import type {DangerouslyImpreciseStyleProp} from 'StyleSheet';
    ```
    
    and `StyleProp` to `DangerouslyImpreciseStyleProp`.
    
    Reviewed By: yungsters
    
    Differential Revision: D7178609
    
    fbshipit-source-id: 32952e0c3a8b6aceef306f1f3c18844feb18f1aa
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    49ffc9f View commit details
    Browse the repository at this point in the history
  13. StyleObj -> DangerouslyImpreciseStyleProp

    Summary:
    Migrating everything to import from StyleSheet instead of StyleSheetTypes.
    
    Search and replaced
    ```
    import type {StyleObj} from 'StyleSheetTypes';
    ```
    to
    ```
    import type {DangerouslyImpreciseStyleProp} from 'StyleSheet';
    ```
    
    and then replacing `StyleObj` with `DangerouslyImpreciseStyleProp` and fixing up the remaining flow errors by hand.
    
    Reviewed By: yungsters
    
    Differential Revision: D7184077
    
    fbshipit-source-id: b8dabb9d48038b5a997ab715687300bad57aa9d4
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    a3c07c9 View commit details
    Browse the repository at this point in the history
  14. Bump metro@0.29.0

    Reviewed By: BYK
    
    Differential Revision: D7181876
    
    fbshipit-source-id: a1b567303b8024b832bf43dd6be56ccebffaf39c
    rafeca authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    3c23645 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Move __StyleProp to StyleSheet

    Reviewed By: yungsters
    
    Differential Revision: D7185815
    
    fbshipit-source-id: 897ae37af3f03aa1408f020bcc7e61004d4dbc0d
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    cf89a2c View commit details
    Browse the repository at this point in the history
  2. Mark more ObjC methods called from RN as dynamic

    Reviewed By: kostiakoval
    
    Differential Revision: D7174480
    
    fbshipit-source-id: 38af8e6e94cb8cdf6aa551d9df1b3e16543387e5
    tgrlnc authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    23e0f86 View commit details
    Browse the repository at this point in the history
  3. iOS: create C++ <-> ObjC++ connector for FabricUIManager to do UI ope…

    …rations
    
    Reviewed By: shergin
    
    Differential Revision: D7162911
    
    fbshipit-source-id: 3e303020dafdccc51f52c3359a7054dc8a787978
    fkgozali authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    7bf3b20 View commit details
    Browse the repository at this point in the history
  4. Fix RefreshControl's dependency on AndroidSwipeRefreshLayout

    Reviewed By: mdvacca
    
    Differential Revision: D7185836
    
    fbshipit-source-id: 726e6e6792f1f3971c2f7de9bb83ff888815220d
    ayc1 authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    a162dc8 View commit details
    Browse the repository at this point in the history
  5. Initialize ReactChoreographer before creating the TimingModule

    Reviewed By: mdvacca
    
    Differential Revision: D7185838
    
    fbshipit-source-id: f775f5668ccff3b311c95a0bdd37a420ec64b7d4
    ayc1 authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    596bcb6 View commit details
    Browse the repository at this point in the history
  6. Don't assume the SourceCode native module exists

    Reviewed By: yungsters
    
    Differential Revision: D7185837
    
    fbshipit-source-id: e8efc22ac0af092dbc1fdf616b0b3f111390dd5d
    ayc1 authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    8cdc7d3 View commit details
    Browse the repository at this point in the history
  7. Add eslint-plugin-react-native Yarn package and enable no-inline-styl…

    …es rule for Marketplace
    
    Reviewed By: TheSavior
    
    Differential Revision: D7158098
    
    fbshipit-source-id: 52c92c5427d27278c8f82ffa5d61b7e9ebbf7824
    SnowCoderAlex authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    89757ed View commit details
    Browse the repository at this point in the history
  8. Convert constant with build flags to function

    Reviewed By: ttsugriy
    
    Differential Revision: D7184372
    
    fbshipit-source-id: c66f473ad15898532f24c6276898ab250e749744
    Jakub Grzmiel authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    5f497ca View commit details
    Browse the repository at this point in the history
  9. Remove usage of Internal StyleSheet type

    Summary: This type shouldn't be necessary from outside code. All callsites were able to be fixed by using the other types like TextStyleProp
    
    Reviewed By: yungsters
    
    Differential Revision: D7187551
    
    fbshipit-source-id: 34fb7fb5f5e72e6cfcb9748157cb5eb6ad3e1f46
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    d89517d View commit details
    Browse the repository at this point in the history
  10. Remove usage of Styles type

    Summary: This type was often used when (View|Text|Image)StyleProp should have been used instead. Since there were no valid usages of it in our codebase, we are not making it public anymore.
    
    Reviewed By: yungsters
    
    Differential Revision: D7188658
    
    fbshipit-source-id: 7112cc4a7da7b007b5c758a0890d2e0b8fe1797a
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    852084a View commit details
    Browse the repository at this point in the history
  11. Prettier

    Reviewed By: yungsters
    
    Differential Revision: D7188912
    
    fbshipit-source-id: 3466c542dc0fb1832b4545b1a307183efcd72b1d
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    5b32358 View commit details
    Browse the repository at this point in the history
  12. Rename Style to DangerouslyImpreciseStyle

    Reviewed By: yungsters
    
    Differential Revision: D7190268
    
    fbshipit-source-id: d652a95be7550d65cfbfc59f41d7bda92915bacf
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    4895c64 View commit details
    Browse the repository at this point in the history
  13. Update additional license headers

    Reviewed By: sophiebits
    
    Differential Revision: D7196607
    
    fbshipit-source-id: 9e6452f583b2b5616f5bb38f26f2ae33c14bb820
    hramos authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    f2ad77f View commit details
    Browse the repository at this point in the history
  14. Ignore yarn.lock and package-lock.json in oss

    Summary:
    Attn janicduplessis
    Closes facebook#18281
    
    Differential Revision: D7200858
    
    Pulled By: hramos
    
    fbshipit-source-id: 8566251255a12aba3a3f9d6af532c4f842a8c41e
    hramos authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    ecd3d95 View commit details
    Browse the repository at this point in the history
  15. Fix typing of View refs

    Reviewed By: olegbl
    
    Differential Revision: D7192405
    
    fbshipit-source-id: 9d9bce8202a5e8f44d92ef6d0afbf8f55e9ea95a
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    49396aa View commit details
    Browse the repository at this point in the history
  16. propTypes are optional for native components

    Summary:
    We plan to migrate native components like View, Text, and Image to be typed with Flow instead of propTypes so that we can better enforce our usages.
    
    This change makes it so that *if* propTypes are defined they must cover the native props. However, if they aren't specified, the validation doesn't occur.
    
    Eventually, the prop validation should occur via codegen that generates an interface the native component must implement from the flow types defined in JS.
    
    Reviewed By: yungsters
    
    Differential Revision: D7203649
    
    fbshipit-source-id: a8095aa46807ce03272e2962289e8f5705b422b9
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    dbdf43b View commit details
    Browse the repository at this point in the history
  17. AccessibilityLabel is optional

    Summary:
    We have a bunch of components internally that use accessibilityLabel in invalid ways.
    View was originally typed as any so invalid usages weren't caught. In order to fix these we have to move forward with getting back to flow having no errors. We are weakening these types to get there and we can tighten them again later.
    
    Reviewed By: yungsters
    
    Differential Revision: D7203260
    
    fbshipit-source-id: 2282eba14899c620de5b4b1c1b2670b157f2fc9e
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    214da52 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2018

  1. fabric/debug module and DebugStringConvertible class

    Summary:
    This is a very first diff in a series of undefined length implementing React Native Shadow Tree infra in C++.
    All Shadow Nodes, Props and etc. implements `DebugStringConvertible`.
    
    Authored by shergin
    
    Reviewed By: shergin
    
    Differential Revision: D7163868
    
    fbshipit-source-id: 9c001aa5bd0723f709a07b1833f512c51e3bec11
    fkgozali authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    34f8e7f View commit details
    Browse the repository at this point in the history
  2. fabric/core module and Sealable class

    Summary:
    `Sealable` class represents something which can be *sealed* (imperatively marked as immutable).
    
    Authored by shergin
    
    Reviewed By: shergin
    
    Differential Revision: D7174883
    
    fbshipit-source-id: 8b26ca5b1a5154953a099895778eab86228acc46
    fkgozali authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    3c86701 View commit details
    Browse the repository at this point in the history
  3. RN: Prettify Systrace

    Reviewed By: TheSavior
    
    Differential Revision: D7207468
    
    fbshipit-source-id: 05ae6e003ae3e55bc2d3a905f41c28f7041dd7f0
    yungsters authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    118521c View commit details
    Browse the repository at this point in the history
  4. RN: Delete Systrace for RelayClassic

    Reviewed By: TheSavior
    
    Differential Revision: D7207462
    
    fbshipit-source-id: 6dd5c5fd22c0a5a7d77331d6adf7b362c3d3e037
    yungsters authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a8c4b63 View commit details
    Browse the repository at this point in the history
  5. RN: Delete Systrace.swizzleJSON

    Reviewed By: TheSavior
    
    Differential Revision: D7207460
    
    fbshipit-source-id: 14b1174d6a5c75e1acba7272376d1c462bc13cb6
    yungsters authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    3e141cb View commit details
    Browse the repository at this point in the history
  6. Fix race condition when there're two flags next to each other

    Reviewed By: yungsters
    
    Differential Revision: D7194598
    
    fbshipit-source-id: a76328d63f649403de15503596a179c7baaf7dc3
    alexeylang authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    8803ab2 View commit details
    Browse the repository at this point in the history
  7. Make fetchSegment native hook name consistent with __ prefix

    Reviewed By: jeanlauliac
    
    Differential Revision: D7205472
    
    fbshipit-source-id: 4cef66539167ed47cf0ac8d3665c20114ffff375
    fromcelticpark authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    20fcf47 View commit details
    Browse the repository at this point in the history
  8. Clone ReactShadowNode when Yoga clones a YogaNode during layout

    Reviewed By: achen1
    
    Differential Revision: D7195840
    
    fbshipit-source-id: d596e3ada8fe48577b91295721d41c0afd33087f
    mdvacca authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a7558d5 View commit details
    Browse the repository at this point in the history
  9. Add extra debug information to ReactShadowNodes objects

    Reviewed By: achen1
    
    Differential Revision: D7195373
    
    fbshipit-source-id: 6611726c3e1f92f387e00e733b1b8909a3e9edc2
    mdvacca authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    e31781b View commit details
    Browse the repository at this point in the history
  10. Add "newProps" map into ReactShadowNode

    Reviewed By: achen1
    
    Differential Revision: D7205127
    
    fbshipit-source-id: 6c27070806de36cab7adf9c392a10c815aee90d4
    mdvacca authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c883d4e View commit details
    Browse the repository at this point in the history
  11. Fixing Assorted View Flow Types

    Reviewed By: yungsters
    
    Differential Revision: D7209495
    
    fbshipit-source-id: e4b247e947b3463ea1200298e6078c7485d636e7
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    2520c64 View commit details
    Browse the repository at this point in the history
  12. Making values optional in ViewPropTypes

    Reviewed By: yungsters
    
    Differential Revision: D7209560
    
    fbshipit-source-id: fd0c55c4f69648927380d12ad9a6b9bcb98047eb
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    f1316ca View commit details
    Browse the repository at this point in the history
  13. Add Sonar support to Oculus Twilight Android

    Reviewed By: alex1kom
    
    Differential Revision: D7177071
    
    fbshipit-source-id: 685d40e564d391d18592cedfcc12d8ac743a5331
    Caleb Meredith authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a48b4d5 View commit details
    Browse the repository at this point in the history
  14. Adding FlowFixMe when switching between Component and Ref

    Reviewed By: yungsters
    
    Differential Revision: D7215800
    
    fbshipit-source-id: 175f769a2b1fc67e72b10e113a96eb4167437ab0
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    25b8ec8 View commit details
    Browse the repository at this point in the history
  15. AndroidInfoModule now also returns Android ID

    Summary: Added Android ID as one of the constants returned by AndroidInfoModule
    
    Reviewed By: fkgozali
    
    Differential Revision: D7206029
    
    fbshipit-source-id: 110b33235d3023b4a4607d37acc3440cfe735cef
    L33tcodex0r authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    216c8ec View commit details
    Browse the repository at this point in the history
  16. Type VirtualizedList's ref

    Reviewed By: yungsters
    
    Differential Revision: D7215114
    
    fbshipit-source-id: 867a7b897f27d415269c11572708afeb570b4be0
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    b6b80f6 View commit details
    Browse the repository at this point in the history
  17. Mock ReactNative.NativeComponent native methods in jest

    Reviewed By: yungsters
    
    Differential Revision: D7218964
    
    fbshipit-source-id: f4b25a533b7e150c978863ff8411dc80937a4fed
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    3e9a371 View commit details
    Browse the repository at this point in the history
  18. Clear cache to resolve iOS, tvOS workflow

    Summary:
    tvOS and iOS workflows were flaky, apparently due to a stale cache that contained a problematic version of the Metro dependency. Thanks to motiz88 for identifying the potential cause of flakiness in react-native-community/releases#2 (comment).
    
    https://circleci.com/workflow-run/440180a2-e888-4f27-bec9-b8e5d9be6708
    
    [GENERAL] [MINOR] [CI] - Resolve iOS, tvOS failures in Circle
    Closes facebook#18304
    
    Differential Revision: D7220150
    
    Pulled By: hramos
    
    fbshipit-source-id: 0f5e68c779dfce44e6deb8b813a3ac9e25a2ab97
    hramos authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c9d7562 View commit details
    Browse the repository at this point in the history
  19. Tightening types for View and VirtualizedList

    Reviewed By: yungsters
    
    Differential Revision: D7215391
    
    fbshipit-source-id: fa144c0dc3fd897864403b589e943ea88e78a999
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    5035af8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. Bump metro@0.30.0

    Reviewed By: BYK
    
    Differential Revision: D7214924
    
    fbshipit-source-id: 4f50ec27e2dceb18e9ef82e741675df295235d74
    rafeca authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    274d6ce View commit details
    Browse the repository at this point in the history
  2. Add existing Android checks to Circle.

    Summary:
    Moving towards reusing existing scripts to ensure local and CI tests are kept in sync.
    Closes facebook#18307
    
    Differential Revision: D7222664
    
    Pulled By: hramos
    
    fbshipit-source-id: ecce91e32159c55b19c29eab69a6754642f02236
    hramos authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    1ff1e57 View commit details
    Browse the repository at this point in the history
  3. Migrating View to be a Flow Typed ES6 class

    Summary:
    The flow type for View using createReactClass was essentially `any`, allowing any Prop to be passed in, only pseudo enforced at run time via propTypes.
    
    This diff converts View away from createReactClass and instead uses ReactNative.NativeComponent. This was previously typed as any as well which didn't buy us much. This change converts View to be an ES6 React class component to ensure proptypechecking, and exposes the methods copied from NativeMethodsMixin.
    
    Reviewed By: yungsters
    
    Differential Revision: D5933888
    
    fbshipit-source-id: eae63b818203e0e86741f9f154ec9cf3498369e2
    elicwhite authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    26734a8 View commit details
    Browse the repository at this point in the history
  4. Upgrade to Flow v0.67

    Reviewed By: gabelevi
    
    Differential Revision: D7208080
    
    fbshipit-source-id: 81380aca39b7a74646a4a44af1e5571bc5629b77
    nmote authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    adabae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2018

  1. Fix Android Sanity Buck version check

    Summary:
    [GENERAL] [MINOR] [./scripts/validate-android-test-env.sh] - Fix buck version check
    Closes facebook#18311
    
    Differential Revision: D7227452
    
    Pulled By: hramos
    
    fbshipit-source-id: c7b32afc36821fbb2462317581ae32d3b257de03
    hramos authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    e057322 View commit details
    Browse the repository at this point in the history
  2. Move Text PropTypes to it's own file

    Reviewed By: fkgozali
    
    Differential Revision: D7226404
    
    fbshipit-source-id: b5637dee9a4f10daf0682e46f1ec8920ea03ae33
    elicwhite authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    cd8128b View commit details
    Browse the repository at this point in the history
  3. Fixing misuses of the Text type

    Reviewed By: fkgozali
    
    Differential Revision: D7227752
    
    fbshipit-source-id: 3577c86b416a7c04190063243839e98e2a80ec7f
    elicwhite authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    3fd82d3 View commit details
    Browse the repository at this point in the history
  4. RN: Remove DebugEnvironment from OSS

    Reviewed By: TheSavior
    
    Differential Revision: D7209266
    
    fbshipit-source-id: 9f9ce66121ff375e5a5d965d58f4137616407853
    yungsters authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    01fffa2 View commit details
    Browse the repository at this point in the history
  5. export CompositeAnimation type

    Differential Revision: D7216928
    
    fbshipit-source-id: 9e8c456c7e94ec3456061ad5c699c0eae30cbe5e
    zjj010104 authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    450e562 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Use -fdata-sections in mode/opt

    Differential Revision: D7194366
    
    fbshipit-source-id: 676f2db2e493230b8d9698941f003ec4e96f15ea
    amirlivneh authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    19dd9a2 View commit details
    Browse the repository at this point in the history
  2. Loosen Platform check to allow better code sharing for out-of-tree pl…

    …atforms
    
    Summary:
    Don't lock out other non-iOS platforms (e.g. Windows) with an overly
    specific check. This change allows this JS file to be re-used instead of copied and modified. There was one other instance of this pattern, but I'll submit it separate for easier cherry-picking.
    
    Tested Android and iOS playground on simulators.
    
     [GENERAL] [ENHANCEMENT] - some core ReactNative JS library files will be easier to re-use across RN platforms.
    Closes facebook#18308
    
    Differential Revision: D7230803
    
    Pulled By: hramos
    
    fbshipit-source-id: 11e03183535a7453cee00dc1e795c27f2fd2bf5d
    Matt Hargett authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    84affbd View commit details
    Browse the repository at this point in the history
  3. Fix tvOS react-native init release build (facebook#18288)

    Summary:
    Add correct dependencies and linker flags to the HelloWorld template Xcode project so that HelloWorld-tvOSTests builds correctly for release builds.  Fixes facebook#18288 .
    
    Tested with `react-native init --version=https://github.com/dlowder-salesforce/react-native#tvos-init-release-fix` .
    
    [IOS][BUGFIX][ local-cli/templates/ios/HelloWorld ]- fix release build for tvOS
    Closes facebook#18337
    
    Differential Revision: D7240376
    
    Pulled By: hramos
    
    fbshipit-source-id: a4ad219e7d6b06bd6928d55ed7398f8fc9352e72
    douglowder authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    3002c4e View commit details
    Browse the repository at this point in the history
  4. Don't truncate in the middle of an emoji

    Reviewed By: adiphos, mantong01
    
    Differential Revision: D7198155
    
    fbshipit-source-id: 360955de7ed686170a23b9883058e3137e17b277
    Vince0613 authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    9c8c597 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9c29faf View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2018

  1. React sync for revisions ab4280b...ad9544f

    Reviewed By: bvaughn
    
    Differential Revision: D7256390
    
    fbshipit-source-id: 9fe1324da93cb8f4a7f478e1037944774b9b95ff
    hramos authored and grabbou committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    85b690f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca8ce83 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b208272 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. fix ReadableNativeMap.toHashMap() for nested maps and arrays

    Summary:
    <!--
      Required: Write your motivation here.
      If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
    -->
    
    Commit facebook@7891805 broke the previous behavior of `ReadableNativeMap.toHashMap()` for nested maps and arrays. Previously, all nested `ReadableNativeMap`s and `ReadableNativeArray`s were recursively converted to `HashMap`s and `ArrayList`s, but this is lost when only `getLocalMap()` is returned.
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    
    Call `ReadableNativeMap.toHashMap()` on a map with values of type `ReadableNativeMap` and `ReadableNativeArray`. Verify the returned hash map has these converted to `HashMap` and `ArrayList`, respectively.
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [ANDROID] [BUGFIX] [ReadableNativeMap] - Fix toHashMap() for nested maps and arrays
    
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#18455
    
    Reviewed By: kathryngray
    
    Differential Revision: D7347344
    
    Pulled By: mdvacca
    
    fbshipit-source-id: af2bca9dec6c0cb8a7da099b6757434fcc3ac785
    esamelson authored and grabbou committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    8a6ab14 View commit details
    Browse the repository at this point in the history
  2. Fix blob response parsing for empty body on iOS

    Summary:
    We currently handle empty body poorly in the iOS blob implementation, this happens because of an early return that cause the blob response to not be processed by the blob module, resulting in an empty string as the body instead of a blob object. We also need to make sure to create an empty blob object when data is nil (empty body) as per the XMLHttpRequest spec. The Android implementation was already handling this properly.
    
    Fixes facebook#18223
    
    Send a HEAD request
    
    ```js
    fetch('https://apipre.monkimun.com/whoami', {
      body: null,
      method: 'HEAD',
      headers: {
        Accept: 'application/json',
        'Content-Type': 'application/json',
      },
    })
    ```
    
    [IOS][BUGFIX][Blob] - Fix blob response parsing for empty body
    Closes facebook#18547
    
    Differential Revision: D7415950
    
    Pulled By: hramos
    
    fbshipit-source-id: 56860532c6171255869f02a0960f55d155184a46
    janicduplessis authored and grabbou committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    093a78d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c70578a View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2018

  1. Pass invertStickyHeaders to ScrollView

    Summary:
    invertStickyHeaders was being set to "this.props.inverted" -- it should just inherit from the props of VirtualizedList instead, per discussion in facebook#18471
    
    Fixes facebook#18471
    
    Pass "invertStickyHeaders: false" to a SectionList (or FlatList), and expect that your sticky headers stick to the bottom of the ScrollView, instead of the top.
    
    none
    
    [ANDROID] [BUGFIX] [SectionList] - invertStickyHeaders can now be set from SectionList or FlatList.
    Closes facebook#18524
    
    Differential Revision: D7386163
    
    Pulled By: hramos
    
    fbshipit-source-id: 3b66dfca280e657303f69f98c5a8bc0df033f9f7
    dannycochran authored and grabbou committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    3d69b5c View commit details
    Browse the repository at this point in the history
  2. 4 Configuration menu
    Copy the full SHA
    2e38418 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. 2 Configuration menu
    Copy the full SHA
    589eae1 View commit details
    Browse the repository at this point in the history
  2. Fix runIOS CFBundleIdentifier

    grabbou committed Apr 5, 2018
    3 Configuration menu
    Copy the full SHA
    ab5db0c View commit details
    Browse the repository at this point in the history
  3. React sync for revisions 9d484ed...1c2876d

    Reviewed By: gaearon
    
    Differential Revision: D7500761
    
    fbshipit-source-id: 8dc1cda879942fc4990b23144a616039fdbe6dc0
    Brian Vaughn authored and grabbou committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    54f23f4 View commit details
    Browse the repository at this point in the history
  4. Revert "React sync for revisions 9d484ed...1c2876d"

    This reverts commit 54f23f4.
    grabbou committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    b1bddd7 View commit details
    Browse the repository at this point in the history
  5. React sync for revisions ad9544f...ced176e

    Reviewed By: sebmarkbage
    
    Differential Revision: D7281277
    
    fbshipit-source-id: 75a638114cf2a65a5c973dbdf218f6d3ba042cc4
    Brian Vaughn authored and grabbou committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    73ffa60 View commit details
    Browse the repository at this point in the history
  6. React sync for revisions ced176e...9d484ed

    Reviewed By: bvaughn
    
    Differential Revision: D7338640
    
    fbshipit-source-id: e2d75d2f1795fb3c37f193d15216951c707711d9
    hramos authored and grabbou committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    69c77d6 View commit details
    Browse the repository at this point in the history
  7. React sync for revisions 9d484ed...1c2876d

    Reviewed By: gaearon
    
    Differential Revision: D7500761
    
    fbshipit-source-id: 8dc1cda879942fc4990b23144a616039fdbe6dc0
    Brian Vaughn authored and grabbou committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    f7f0a22 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    44f19f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Revert "Fix: Added scroll Bounds check in scrollToOffset method in RC…

    …TScrollView on iOS"
    
    This reverts commit 16c9e5b.
    grabbou committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    c2c4f48 View commit details
    Browse the repository at this point in the history
  2. Fix deprecation warnings

    grabbou committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    7fdf9d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a716e32 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a05f851 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. exclude React/Fabric/ from core

    Summary:
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    Help us understand your motivation by explaining why you decided to make this change.
    
    <!--
      Required: Write your motivation here.
      If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
    -->
    
    React native does not build on iOS when using Podspec environment. I tried the solution proposed in facebook#18683 and got it to build.
    
    Fixes facebook#18683
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [IOS] [BUGFIX] [React.podspec] - Exclude `React/Fabric/*` from Core subspec
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes facebook#18688
    
    Differential Revision: D7505267
    
    Pulled By: hramos
    
    fbshipit-source-id: 8e7138ee966d08209a74193e418feaecceefb86a
    Gyran authored and grabbou committed Apr 17, 2018
    1 Configuration menu
    Copy the full SHA
    4fc2886 View commit details
    Browse the repository at this point in the history
  2. Revert "Remove Platform check from WebSocket module"

    Summary:
    This reverts commit b9be289.
    
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    Help us understand your motivation by explaining why you decided to make this change.
    
    <!--
      Required: Write your motivation here.
      If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
    -->
    
    Fix facebook#18696
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    
    Run Jest tests.
    Run WebSocket example from RNTester on Android.
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [CATEGORY] [TYPE] [LOCATION] - Message
    
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [ANDROID][BUGFIX][WebSocketModule] - revert change that regresses WebSocketModule
    Closes facebook#18733
    
    Differential Revision: D7548850
    
    Pulled By: hramos
    
    fbshipit-source-id: b8c79810c1cd6e5a30ec4118bd5ff8ad719f04b9
    rozele authored and grabbou committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    31a1b72 View commit details
    Browse the repository at this point in the history
  3. [0.55.3] Bump version numbers

    grabbou committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    2845a86 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2018

  1. Properly tear down the reachabilityRef in RCTNetInfo

    Summary: The pull request that added this (facebook#17397) simply forgot to remove the callback, which would cause crashes if the RCTNetInfo module was ever deallocated. While that usually doesn't happen in apps, it can if the user logs out and you need to wipe all the RCT modules (to remove user data, for instance).
    
    Reviewed By: PeteTheHeat
    
    Differential Revision: D7322999
    
    fbshipit-source-id: e49ec7311b39920f7b7743a5854c0dda1dbccc73
    Mehdi Mulani authored and grabbou committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    e187b07 View commit details
    Browse the repository at this point in the history
  2. fix use of C++ syntax in an header file

    Summary:
    All public header files can be included from Obj-C and Swift, except RCTSurfaceSizeMeasureMode.h which contains C++ code.
    
    Change is trivial and can be validated by review.
    
    None.
    
    [IOS][BUGFIX][{RCTSurfaceSizeMeasureMode.h}] - fix use of C++ syntax in an header file that could be included from Obj-C and Swift
    Closes facebook#18730
    
    Differential Revision: D7550290
    
    Pulled By: shergin
    
    fbshipit-source-id: 3835e2c57697a067ff94afdaeaca06bce132ef66
    gmondada authored and grabbou committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    f8091fa View commit details
    Browse the repository at this point in the history
  3. Switch equality check in BlobModule.java

    Summary:
    Switch the equality check to avoid crash on the first item. The check can be on a null object and return the correct result.
    
    Fixes facebook#18709
    
    Just a simple switch on equals, to make sure we're not bombing out by having a null scheme.
    
    No related PRs and does not require a document change.
    
    [ANDROID][BUGFIX][BlobModule] Switch equality check in BlobModule.java
    Closes facebook#18893
    
    Differential Revision: D7658036
    
    Pulled By: hramos
    
    fbshipit-source-id: db61b98dae178dbbb645070f7b0d73ab43d30541
    shockdesign authored and grabbou committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    5bb2e83 View commit details
    Browse the repository at this point in the history
  4. [0.55.4] Bump version numbers

    grabbou committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    370bcff View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Configuration menu
    Copy the full SHA
    f5bd491 View commit details
    Browse the repository at this point in the history