Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove enableHostSingletons feature flag #27583

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 25, 2023

The flag is enabled everywhere, I think we can remove it now.

@kassens kassens requested review from sebmarkbage and gnoff October 25, 2023 16:16
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 25, 2023
@react-sizebot
Copy link

Comparing: 51ffd35...2b53e76

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.04 kB 175.04 kB = 54.47 kB 54.47 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.17 kB 177.17 kB = 55.15 kB 55.15 kB
facebook-www/ReactDOM-prod.classic.js = 567.61 kB 567.61 kB = 99.94 kB 99.94 kB
facebook-www/ReactDOM-prod.modern.js = 551.47 kB 551.47 kB = 97.04 kB 97.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2b53e76

@kassens kassens merged commit 1a65d03 into facebook:main Nov 16, 2023
2 checks passed
@kassens kassens deleted the host-singletons-flag branch November 16, 2023 22:42
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
The flag is enabled everywhere, I think we can remove it now.

DiffTrain build for [1a65d03](1a65d03)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
The flag is enabled everywhere, I think we can remove it now.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
The flag is enabled everywhere, I think we can remove it now.

DiffTrain build for commit 1a65d03.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants