Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flags for expiration times #27821

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Add feature flags for expiration times #27821

merged 1 commit into from
Dec 11, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Dec 8, 2023

It seems worthwhile to me to run a test to experiment with different expiration times. This moves the expiration times for scheduler and reconciler into FeatureFlags for the facebook build. Non-facebook should not be affected by these changes.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 8, 2023
josephsavona
josephsavona approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. It's going to be really interesting to see the results from experimenting with this timeout.

@kassens kassens merged commit 0cdfef1 into facebook:main Dec 11, 2023
3 checks passed
@kassens kassens deleted the expiration-feature-flags branch December 11, 2023 14:58
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
@kassens
Add feature flags for expiration times (#27821)
9996001 
It seems worthwhile to me to run a test to experiment with different
expiration times. This moves the expiration times for scheduler and
reconciler into FeatureFlags for the facebook build. Non-facebook should
not be affected by these changes.

DiffTrain build for [0cdfef1](0cdfef1)
@ztanner ztanner mentioned this pull request Dec 15, 2023
Merged
ztanner added a commit to vercel/next.js that referenced this pull request Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74 
Updates React from 2c338b16f to 0cdfef19b.

### React upstream changes

- facebook/react#27821
- facebook/react#27820
- facebook/react#27818
- facebook/react#27819
- facebook/react#27817
- facebook/react#27703
- facebook/react#27796
- facebook/react#27811
- facebook/react#27804
- facebook/react#27807
- facebook/react#27805
- facebook/react#27792
- facebook/react#27788
- facebook/react#26852
- facebook/react#27790
- facebook/react#27786
- facebook/react#27785
- facebook/react#27783
- facebook/react#27784
- facebook/react#27769
- facebook/react#27766
- facebook/react#27701
- facebook/react#27732
- facebook/react#27740
- facebook/react#27767
- facebook/react#27768
- facebook/react#27765
- facebook/react#27759
- facebook/react#27579
- facebook/react#27709
- facebook/react#27734
- facebook/react#27739
- facebook/react#27717
- facebook/react#27583
- facebook/react#27713

Closes NEXT-1887
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@ztanner @agustints
Update React from 2c338b16f to 0cdfef19b (vercel#59666)
9620d19 
Updates React from 2c338b16f to 0cdfef19b.

### React upstream changes

- facebook/react#27821
- facebook/react#27820
- facebook/react#27818
- facebook/react#27819
- facebook/react#27817
- facebook/react#27703
- facebook/react#27796
- facebook/react#27811
- facebook/react#27804
- facebook/react#27807
- facebook/react#27805
- facebook/react#27792
- facebook/react#27788
- facebook/react#26852
- facebook/react#27790
- facebook/react#27786
- facebook/react#27785
- facebook/react#27783
- facebook/react#27784
- facebook/react#27769
- facebook/react#27766
- facebook/react#27701
- facebook/react#27732
- facebook/react#27740
- facebook/react#27767
- facebook/react#27768
- facebook/react#27765
- facebook/react#27759
- facebook/react#27579
- facebook/react#27709
- facebook/react#27734
- facebook/react#27739
- facebook/react#27717
- facebook/react#27583
- facebook/react#27713

Closes NEXT-1887
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@kassens @AndyPengc12
Add feature flags for expiration times (facebook#27821)
51425aa 
It seems worthwhile to me to run a test to experiment with different
expiration times. This moves the expiration times for scheduler and
reconciler into FeatureFlags for the facebook build. Non-facebook should
not be affected by these changes.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@kassens
Add feature flags for expiration times (#27821)
2ad853a 
It seems worthwhile to me to run a test to experiment with different
expiration times. This moves the expiration times for scheduler and
reconciler into FeatureFlags for the facebook build. Non-facebook should
not be affected by these changes.

DiffTrain build for commit 0cdfef1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kassens @josephsavona @facebook-github-bot