Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update act references in tests #27805

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Update act references in tests #27805

merged 1 commit into from
Dec 6, 2023
+10 −10

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Dec 6, 2023

As part of the process of removing the deprecated react-dom/test-utils package references to act from this module are replaced with references to unstable_act in react. It is likely that the unstable act implementation will be made stable. The test utils act is just a reexport of the unstable_act implementation in react itself.

@gnoff gnoff requested a review from acdlite December 6, 2023 18:03
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Dec 6, 2023
@react-sizebot
Copy link

react-sizebot commented Dec 6, 2023 •
edited
Loading

Comparing: aba93ac...8b36d2c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.75 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.39 kB
facebook-www/ReactDOM-prod.classic.js = 569.81 kB 569.81 kB = 100.29 kB 100.29 kB
facebook-www/ReactDOM-prod.modern.js = 553.67 kB 553.67 kB = 97.38 kB 97.38 kB
test_utils/ReactAllWarnings.js Deleted 67.17 kB 0.00 kB Deleted 16.35 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.17 kB 0.00 kB Deleted 16.35 kB 0.00 kB

Generated by 🚫 dangerJS against 8b36d2c

@kassens
Copy link
Member

kassens commented Dec 6, 2023

Watch out for the test failures, not sure what's going on there.

@gnoff gnoff merged commit 9cae442 into facebook:main Dec 6, 2023
36 checks passed
@gnoff gnoff deleted the update-to-act branch December 6, 2023 20:57
@hoxyq
Copy link
Contributor

hoxyq commented Dec 7, 2023 •
edited
Loading

This probably breaks backwards-compatibility tests for React DevTools x React 17:
https://app.circleci.com/pipelines/github/facebook/react/49065/workflows/efcc8f61-8ed4-4f33-b258-906e8221ed81/jobs/747336

Is unstable_act available in React 17?

@gnoff
Copy link
Collaborator Author

gnoff commented Dec 7, 2023

@hoxyq I don't think it is. However, how come it works for older Reacts? Is there some fork I need to do for 17 so it continues to use older APIs?

@hoxyq
Copy link
Contributor

hoxyq commented Dec 7, 2023 •
edited
Loading

@hoxyq I don't think it is. However, how come it works for older Reacts? Is there some fork I need to do for 17 so it continues to use older APIs?

Both failing tests have @reactVersion >= 16.9 annotation, for any version lower than 16.9, these tests will be skipped:

react/packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js

Line 190 in 9cdf8a9

// @reactVersion >= 16.9

react/packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js

Line 126 in 9cdf8a9

// @reactVersion >= 16.9

Just revert the changes for these 2 tests and it should be fine, I think

@hoxyq
Copy link
Contributor

hoxyq commented Dec 7, 2023 •
edited
Loading

@hoxyq I don't think it is. However, how come it works for older Reacts? Is there some fork I need to do for 17 so it continues to use older APIs?

Both failing tests have @reactVersion >= 16.9 annotation, for any version lower than 16.9, these tests will be skipped:

react/packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js

Line 190 in 9cdf8a9

// @reactVersion >= 16.9

react/packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js

Line 126 in 9cdf8a9

// @reactVersion >= 16.9

Just update the changes for these 2 tests and it should be fine, I think

Oh, you've updated the utils, so you probably need to have a fallback here, for older React versions:

react/packages/react-devtools-shared/src/__tests__/utils.js

Line 22 in b36ae8d

const actDOM = require('react').unstable_act;

Updating it to const actDOM = require('react').unstable_act || require('react-dom/test-utils').act; should do the trick.

@ztanner ztanner mentioned this pull request Dec 15, 2023
Merged
ztanner added a commit to vercel/next.js that referenced this pull request Dec 15, 2023
@ztanner
Update React from 2c338b16f to 0cdfef19b (#59666)
1fa7a74 
Updates React from 2c338b16f to 0cdfef19b.

### React upstream changes

- facebook/react#27821
- facebook/react#27820
- facebook/react#27818
- facebook/react#27819
- facebook/react#27817
- facebook/react#27703
- facebook/react#27796
- facebook/react#27811
- facebook/react#27804
- facebook/react#27807
- facebook/react#27805
- facebook/react#27792
- facebook/react#27788
- facebook/react#26852
- facebook/react#27790
- facebook/react#27786
- facebook/react#27785
- facebook/react#27783
- facebook/react#27784
- facebook/react#27769
- facebook/react#27766
- facebook/react#27701
- facebook/react#27732
- facebook/react#27740
- facebook/react#27767
- facebook/react#27768
- facebook/react#27765
- facebook/react#27759
- facebook/react#27579
- facebook/react#27709
- facebook/react#27734
- facebook/react#27739
- facebook/react#27717
- facebook/react#27583
- facebook/react#27713

Closes NEXT-1887
hoxyq added a commit that referenced this pull request Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
4e9961d 
#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
@hoxyq hoxyq mentioned this pull request Dec 17, 2023
Merged
hoxyq added a commit to hoxyq/react that referenced this pull request Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests
015399f 
facebook#27805 broke integration tests for React DevTools with React 17, these changes introduce a fallback for such case when `act` is not available in `react`, but available in `react-dom`, like before.
hoxyq added a commit that referenced this pull request Dec 17, 2023
@hoxyq
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
3e00e58 
#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
jerrydev0927 added a commit to jerrydev0927/react that referenced this pull request Jan 5, 2024
@jerrydev0927
fix[devtools/e2e]: add fallback for act in integration tests (#27842)
52e20fd 
facebook/react#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@ztanner @agustints
Update React from 2c338b16f to 0cdfef19b (vercel#59666)
9620d19 
Updates React from 2c338b16f to 0cdfef19b.

### React upstream changes

- facebook/react#27821
- facebook/react#27820
- facebook/react#27818
- facebook/react#27819
- facebook/react#27817
- facebook/react#27703
- facebook/react#27796
- facebook/react#27811
- facebook/react#27804
- facebook/react#27807
- facebook/react#27805
- facebook/react#27792
- facebook/react#27788
- facebook/react#26852
- facebook/react#27790
- facebook/react#27786
- facebook/react#27785
- facebook/react#27783
- facebook/react#27784
- facebook/react#27769
- facebook/react#27766
- facebook/react#27701
- facebook/react#27732
- facebook/react#27740
- facebook/react#27767
- facebook/react#27768
- facebook/react#27765
- facebook/react#27759
- facebook/react#27579
- facebook/react#27709
- facebook/react#27734
- facebook/react#27739
- facebook/react#27717
- facebook/react#27583
- facebook/react#27713

Closes NEXT-1887
@hoxyq hoxyq mentioned this pull request Feb 22, 2024
Merged
hoxyq added a commit that referenced this pull request Feb 22, 2024
@hoxyq
React DevTools 5.0.0 -> 5.0.1 (#28418)
288cf74 
Full list of changes (not a public CHANGELOG):

* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[#28417](#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[#28399](#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[#28408](#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[#28348](#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[#28320](#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[#28309](#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[#28318](#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[#28226](#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[#28297](#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[#28145](#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[#28296](#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[#28273](#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[#28233](#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[#28265](#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[#28246](#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28218](#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[#28254](#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[#28219](#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28216](#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[#28249](#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[#28241](#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[#28243](#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28236](#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[#28237](#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[#28242](#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[#28240](#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[#28239](#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[#28245](#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[#28244](#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[#28238](#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[#28235](#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[#28221](#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[#28215](#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[#28214](#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[#28213](#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[#28212](#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[#28211](#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28210](#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[#28186](#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[#28232](#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[#27982](#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[#28160](#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[#27871](#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[#27842](#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[#27804](#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[#27805](#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [#27790](#27790))
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
Update act references in tests (facebook#27805)
dde8a23 
As part of the process of removing the deprecated `react-dom/test-utils`
package references to `act` from this module are replaced with
references to `unstable_act` in `react`. It is likely that the unstable
act implementation will be made stable. The test utils act is just a
reexport of the unstable_act implementation in react itself.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq @AndyPengc12
fix[devtools/e2e]: add fallback for act in integration tests (faceboo…
c984c1b 
…k#27842)

facebook#27805 broke integration tests for
React DevTools with React 17, these changes introduce a fallback for
such case when `act` is not available in `react`, but available in
`react-dom`, like before.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq @AndyPengc12
React DevTools 5.0.0 -> 5.0.1 (facebook#28418)
58c3f5b 
Full list of changes (not a public CHANGELOG):

* feature[REMOVED][devtools]: turn off / hide location based component
filters ([hoxyq](https://github.com/hoxyq) in
[facebook#28417](facebook#28417))
* Add useSyncExternalStore and useTransition to getPrimitiveStackCache
([jamesbvaughan](https://github.com/jamesbvaughan) in
[facebook#28399](facebook#28399))
* chore[devtools]: use react-window from npm and bump
react-virtualized-auto-sizer to ^1.0.23
([hoxyq](https://github.com/hoxyq) in
[facebook#28408](facebook#28408))
* Pass ref as normal prop ([acdlite](https://github.com/acdlite) in
[facebook#28348](facebook#28348))
* Combine createElement and JSX modules
([acdlite](https://github.com/acdlite) in
[facebook#28320](facebook#28320))
* [Debug Tools] Always use includeHooksSource option
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#28309](facebook#28309))
* Revert "[Tests] Reset modules by default"
([acdlite](https://github.com/acdlite) in
[facebook#28318](facebook#28318))
* Switch <Context> to mean <Context.Provider>
([gaearon](https://github.com/gaearon) in
[facebook#28226](facebook#28226))
* [Debug Tools] Introspect Promises in use()
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#28297](facebook#28297))
* fix[devtools/useModalDismissSignal]: use getRootNode for shadow root
case support ([hoxyq](https://github.com/hoxyq) in
[facebook#28145](facebook#28145))
* fix: define IS_ACT_ENVIRONMENT global for tests with concurrent mode
and synchronous act ([hoxyq](https://github.com/hoxyq) in
[facebook#28296](facebook#28296))
* chore: gate legacy apis for react-devtools-shell
([hoxyq](https://github.com/hoxyq) in
[facebook#28273](facebook#28273))
* DevTools: Add support for use(Context)
([eps1lon](https://github.com/eps1lon) in
[facebook#28233](facebook#28233))
* Remove __self and __source location from elements
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#28265](facebook#28265))
* chore: use versioned render in inspectedElement test
([hoxyq](https://github.com/hoxyq) in
[facebook#28246](facebook#28246))
* chore: use versioned render in TimelineProfiler test and gate some for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[facebook#28218](facebook#28218))
* [Tests] Reset modules by default
([rickhanlonii](https://github.com/rickhanlonii) in
[facebook#28254](facebook#28254))
* chore: use versioned render in preprocessData test and gate some for …
([hoxyq](https://github.com/hoxyq) in
[facebook#28219](facebook#28219))
* chore: use versioned render in storeStressSync test and gate them for
legacy rendering ([hoxyq](https://github.com/hoxyq) in
[facebook#28216](facebook#28216))
* Patch devtools before running useMemo function in strict mode
([gsathya](https://github.com/gsathya) in
[facebook#28249](facebook#28249))
* chore: use versioned render in storeComponentFilters test
([hoxyq](https://github.com/hoxyq) in
[facebook#28241](facebook#28241))
* chore: use versioned render in profilerContext test
([hoxyq](https://github.com/hoxyq) in
[facebook#28243](facebook#28243))
* chore: use versioned render in profilingCommitTreeBuilder test and
gate some for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[facebook#28236](facebook#28236))
* chore: use versioned render in profilingHostRoot test and gate some
for legacy rendering ([hoxyq](https://github.com/hoxyq) in
[facebook#28237](facebook#28237))
* chore: use versioned render in profilingCache test
([hoxyq](https://github.com/hoxyq) in
[facebook#28242](facebook#28242))
* chore: use versioned render in ownersListContext test
([hoxyq](https://github.com/hoxyq) in
[facebook#28240](facebook#28240))
* chore: use versioned render in editing test
([hoxyq](https://github.com/hoxyq) in
[facebook#28239](facebook#28239))
* chore: use versioned render in treeContext test
([hoxyq](https://github.com/hoxyq) in
[facebook#28245](facebook#28245))
* chore: use versioned render in store test
([hoxyq](https://github.com/hoxyq) in
[facebook#28244](facebook#28244))
* chore: use versioned render in profilerStore test
([hoxyq](https://github.com/hoxyq) in
[facebook#28238](facebook#28238))
* chore: use versioned render in profilingCharts test
([hoxyq](https://github.com/hoxyq) in
[facebook#28235](facebook#28235))
* chore: use versioned render in profilerChangeDescriptions test
([hoxyq](https://github.com/hoxyq) in
[facebook#28221](facebook#28221))
* chore: use versioned render in storeOwners test
([hoxyq](https://github.com/hoxyq) in
[facebook#28215](facebook#28215))
* chore: use versioned render in componentStacks test
([hoxyq](https://github.com/hoxyq) in
[facebook#28214](facebook#28214))
* chore: use versioned render in console test
([hoxyq](https://github.com/hoxyq) in
[facebook#28213](facebook#28213))
* chore: use versioned render in useEditableValue test
([hoxyq](https://github.com/hoxyq) in
[facebook#28212](facebook#28212))
* chore: use versioned render in FastRefreshDevToolsIntegration test
([hoxyq](https://github.com/hoxyq) in
[facebook#28211](facebook#28211))
* chore: add versioned render implementation for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[facebook#28210](facebook#28210))
* chore: add single versioned implementation of act for DevTools tests
([hoxyq](https://github.com/hoxyq) in
[facebook#28186](facebook#28186))
* DevTools: Add support for useFormState
([eps1lon](https://github.com/eps1lon) in
[facebook#28232](facebook#28232))
* DevTools: Add support for useOptimistic Hook
([eps1lon](https://github.com/eps1lon) in
[facebook#27982](facebook#27982))
* Add stable React.act export ([acdlite](https://github.com/acdlite) in
[facebook#28160](facebook#28160))
* [flow] upgrade to 0.225.1 ([kassens](https://github.com/kassens) in
[facebook#27871](facebook#27871))
* fix[devtools/e2e]: add fallback for act in integration tests
([hoxyq](https://github.com/hoxyq) in
[facebook#27842](facebook#27842))
* Add stable concurrent option to react-test-renderer
([jackpope](https://github.com/jackpope) in
[facebook#27804](facebook#27804))
* Update act references in tests ([gnoff](https://github.com/gnoff) in
[facebook#27805](facebook#27805))
* Flow: make more objects exact ([kassens](https://github.com/kassens)
in [facebook#27790](facebook#27790))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gnoff
Update act references in tests (#27805)
8174454 
As part of the process of removing the deprecated `react-dom/test-utils`
package references to `act` from this module are replaced with
references to `unstable_act` in `react`. It is likely that the unstable
act implementation will be made stable. The test utils act is just a
reexport of the unstable_act implementation in react itself.

DiffTrain build for commit 9cae442.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gnoff @react-sizebot @kassens @hoxyq @facebook-github-bot