Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] remove unused deps coveralls and @actuallyworks/node-fetch #27792

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Dec 4, 2023

I do not see references to these modules. Unless there's some dynamic loading going on (hopefully we should see that in CI) these seem like they can be removed.

@kassens kassens requested review from noahlemen and jackpope December 4, 2023 23:48
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 4, 2023
Copy link
Member

@noahlemen noahlemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@kassens kassens merged commit aba93ac into facebook:main Dec 5, 2023
36 checks passed
@kassens kassens deleted the unused-deps branch December 5, 2023 19:15
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…cebook#27792)

I do not see references to these modules. Unless there's some dynamic
loading going on (hopefully we should see that in CI) these seem like
they can be removed.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…7792)

I do not see references to these modules. Unless there's some dynamic
loading going on (hopefully we should see that in CI) these seem like
they can be removed.

DiffTrain build for commit aba93ac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants