Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infinite update loop detection #28279

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Add infinite update loop detection #28279

merged 1 commit into from
Feb 9, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Feb 8, 2024

This is a partial redo of #26625. Since that was unlanded due to some detected breakages. This now includes a feature flag to be careful in rolling this out.

@kassens kassens requested a review from acdlite February 8, 2024 16:20
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 8, 2024
@kassens kassens force-pushed the infinite-loop-rebase branch 2 times, most recently from 657d670 to 5e3c8d5 Compare February 8, 2024 20:16
@react-sizebot
Copy link

react-sizebot commented Feb 8, 2024 •
edited
Loading

Comparing: 03d6f7c...61ac209

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.10% 176.64 kB 176.82 kB +0.18% 55.02 kB 55.12 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.10% 178.63 kB 178.81 kB +0.18% 55.60 kB 55.69 kB
facebook-www/ReactDOM-prod.classic.js +0.28% 591.73 kB 593.39 kB +0.24% 104.44 kB 104.69 kB
facebook-www/ReactDOM-prod.modern.js +0.29% 575.51 kB 577.17 kB +0.24% 101.53 kB 101.78 kB
test_utils/ReactAllWarnings.js Deleted 67.02 kB 0.00 kB Deleted 16.42 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-art/cjs/react-art.production.js +0.48% 598.20 kB 601.08 kB +0.52% 133.79 kB 134.49 kB
oss-stable/react-art/cjs/react-art.production.js +0.48% 598.23 kB 601.11 kB +0.52% 133.82 kB 134.51 kB
oss-experimental/react-art/cjs/react-art.production.js +0.48% 605.24 kB 608.12 kB +0.51% 135.42 kB 136.11 kB
facebook-www/ReactART-prod.modern.js +0.45% 350.99 kB 352.57 kB +0.38% 59.49 kB 59.71 kB
facebook-www/ReactART-prod.classic.js +0.44% 361.95 kB 363.53 kB +0.39% 61.45 kB 61.70 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js +0.42% 690.12 kB 693.03 kB +0.45% 150.77 kB 151.46 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js +0.42% 690.14 kB 693.05 kB +0.45% 150.80 kB 151.49 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js +0.42% 697.15 kB 700.07 kB +0.45% 152.31 kB 152.99 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js +0.40% 731.32 kB 734.23 kB +0.44% 158.12 kB 158.82 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js +0.40% 731.34 kB 734.26 kB +0.44% 158.15 kB 158.85 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js +0.39% 738.36 kB 741.27 kB +0.44% 159.71 kB 160.41 kB
facebook-www/ReactART-dev.modern.js +0.35% 1,048.62 kB 1,052.33 kB +0.41% 206.46 kB 207.30 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.35% 845.10 kB 848.07 kB +0.38% 184.99 kB 185.70 kB
oss-stable/react-art/cjs/react-art.development.js +0.35% 845.13 kB 848.09 kB +0.38% 185.02 kB 185.73 kB
facebook-www/ReactART-dev.classic.js +0.35% 1,061.22 kB 1,064.93 kB +0.40% 208.87 kB 209.70 kB
oss-experimental/react-art/cjs/react-art.development.js +0.35% 854.45 kB 857.41 kB +0.40% 186.69 kB 187.42 kB
oss-stable-semver/react-art/umd/react-art.development.js +0.32% 961.60 kB 964.66 kB +0.33% 204.13 kB 204.81 kB
oss-stable/react-art/umd/react-art.development.js +0.32% 961.63 kB 964.69 kB +0.33% 204.16 kB 204.83 kB
oss-experimental/react-art/umd/react-art.development.js +0.32% 971.43 kB 974.49 kB +0.34% 205.87 kB 206.56 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.31% 945.30 kB 948.26 kB +0.34% 203.56 kB 204.25 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.31% 945.32 kB 948.29 kB +0.34% 203.59 kB 204.28 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.31% 954.64 kB 957.60 kB +0.33% 205.28 kB 205.96 kB
oss-stable-semver/react-dom/cjs/react-dom.production.js +0.31% 949.76 kB 952.68 kB +0.33% 212.92 kB 213.62 kB
oss-stable/react-dom/cjs/react-dom.production.js +0.31% 949.79 kB 952.70 kB +0.33% 212.95 kB 213.65 kB
oss-experimental/react-dom/cjs/react-dom.production.js +0.30% 957.46 kB 960.37 kB +0.32% 214.58 kB 215.26 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js +0.30% 975.43 kB 978.35 kB +0.31% 219.07 kB 219.74 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.js +0.29% 991.56 kB 994.47 kB +0.31% 220.41 kB 221.10 kB
oss-stable/react-dom/cjs/react-dom.profiling.js +0.29% 991.58 kB 994.50 kB +0.31% 220.44 kB 221.13 kB
oss-experimental/react-dom/cjs/react-dom.profiling.js +0.29% 999.25 kB 1,002.16 kB +0.31% 222.12 kB 222.81 kB
facebook-www/ReactDOM-prod.modern.js +0.29% 575.51 kB 577.17 kB +0.24% 101.53 kB 101.78 kB
facebook-www/ReactDOM-prod.classic.js +0.28% 591.73 kB 593.39 kB +0.24% 104.44 kB 104.69 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.28% 591.89 kB 593.55 kB +0.23% 105.65 kB 105.89 kB
facebook-www/ReactDOM-profiling.modern.js +0.27% 605.88 kB 607.54 kB +0.24% 106.01 kB 106.26 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.27% 606.51 kB 608.17 kB +0.23% 108.13 kB 108.38 kB
facebook-www/ReactDOM-profiling.classic.js +0.27% 622.17 kB 623.82 kB +0.24% 108.97 kB 109.23 kB
react-native/implementations/ReactFabric-prod.js +0.27% 322.11 kB 322.96 kB +0.20% 56.82 kB 56.94 kB
react-native/implementations/ReactFabric-prod.fb.js +0.26% 328.10 kB 328.96 kB +0.21% 58.13 kB 58.25 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.26% 331.31 kB 332.17 kB +0.18% 58.50 kB 58.61 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.25% 335.57 kB 336.43 kB +0.19% 59.47 kB 59.58 kB
react-native/implementations/ReactFabric-profiling.js +0.24% 340.86 kB 341.67 kB +0.17% 59.88 kB 59.98 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.23% 350.75 kB 351.56 kB +0.16% 61.68 kB 61.78 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.23% 355.34 kB 356.16 kB +0.20% 62.33 kB 62.46 kB
facebook-www/ReactDOM-dev.modern.js +0.23% 1,633.07 kB 1,636.78 kB +0.24% 325.34 kB 326.12 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.22% 362.83 kB 363.64 kB +0.17% 63.71 kB 63.82 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.22% 1,654.59 kB 1,658.31 kB +0.24% 329.91 kB 330.70 kB
facebook-www/ReactDOM-dev.classic.js +0.22% 1,664.66 kB 1,668.37 kB +0.24% 331.02 kB 331.81 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js +0.22% 1,337.93 kB 1,340.89 kB +0.24% 296.00 kB 296.70 kB
oss-stable/react-dom/cjs/react-dom.development.js +0.22% 1,337.96 kB 1,340.92 kB +0.24% 296.03 kB 296.73 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.22% 1,686.24 kB 1,689.95 kB +0.24% 335.58 kB 336.38 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.22% 1,351.03 kB 1,354.00 kB +0.23% 298.49 kB 299.18 kB
oss-stable-semver/react-dom/umd/react-dom.development.js +0.22% 1,402.18 kB 1,405.24 kB +0.22% 299.07 kB 299.74 kB
oss-stable/react-dom/umd/react-dom.development.js +0.22% 1,402.21 kB 1,405.27 kB +0.22% 299.10 kB 299.76 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.22% 1,368.89 kB 1,371.85 kB +0.23% 302.78 kB 303.47 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.22% 1,415.94 kB 1,419.00 kB +0.22% 301.56 kB 302.23 kB
test_utils/ReactAllWarnings.js Deleted 67.02 kB 0.00 kB Deleted 16.42 kB 0.00 kB

Generated by 🚫 dangerJS against 61ac209

@kassens
Add infinite update loop detection
61ac209 
This is a partial redo of facebook#26625. Since that was unlanded due to some detected breakages. This now includes a feature flag to be careful in rolling this out.
@kassens kassens force-pushed the infinite-loop-rebase branch from 5e3c8d5 to 61ac209 Compare February 9, 2024 15:03
@kassens kassens requested a review from noahlemen February 9, 2024 15:03
@kassens kassens merged commit d8c1fa6 into facebook:main Feb 9, 2024
36 checks passed
@kassens kassens deleted the infinite-loop-rebase branch February 9, 2024 16:15
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
@kassens
Add infinite update loop detection (#28279)
e0e832e 
This is a partial redo of #26625.
Since that was unlanded due to some detected breakages. This now
includes a feature flag to be careful in rolling this out.

DiffTrain build for [d8c1fa6](d8c1fa6)
This was referenced Feb 20, 2024
Closed
Merged
huozhi added a commit to vercel/next.js that referenced this pull request Feb 23, 2024
@huozhi
Upgrade vendored react (#62326)
e5d604f 
### React upstream changes

- facebook/react#28333
- facebook/react#28334
- facebook/react#28378
- facebook/react#28377
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269

Closes NEXT-2542


Disable ppr test for strict mode for now, @acdlite will check it and
we'll sync again
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@kassens @AndyPengc12
Add infinite update loop detection (facebook#28279)
17223cb 
This is a partial redo of facebook#26625.
Since that was unlanded due to some detected breakages. This now
includes a feature flag to be careful in rolling this out.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@kassens
Add infinite update loop detection (#28279)
55213cc 
This is a partial redo of #26625.
Since that was unlanded due to some detected breakages. This now
includes a feature flag to be careful in rolling this out.

DiffTrain build for commit d8c1fa6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@noahlemen noahlemen Awaiting requested review from noahlemen

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @acdlite @facebook-github-bot