Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump vendored react versions #62302

Closed
wants to merge 4 commits into from
Closed

Bump vendored react versions #62302

wants to merge 4 commits into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 20, 2024 •
edited by padmaia
Loading

React upstream changes

Closes NEXT-2542

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 20, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 20, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-a515d753b-20240220 environment +4 17.9 MB react-bot
npm/react-dom@18.3.0-canary-a515d753b-20240220 environment +4 14.4 MB react-bot
npm/react-server-dom-turbopack@0.0.0-experimental-a515d753b-20240220 Transitive: environment +8 8.07 MB react-bot
npm/react-server-dom-turbopack@18.3.0-canary-a515d753b-20240220 Transitive: environment +8 7.87 MB react-bot
npm/react-server-dom-webpack@0.0.0-experimental-a515d753b-20240220 Transitive: environment, eval, filesystem, network, shell, unsafe +86 26.9 MB react-bot
npm/react-server-dom-webpack@18.3.0-canary-a515d753b-20240220 Transitive: environment, eval, filesystem, network, shell, unsafe +86 26.7 MB react-bot
npm/react@0.0.0-experimental-a515d753b-20240220 environment +2 680 kB react-bot
npm/react@18.3.0-canary-a515d753b-20240220 environment +2 650 kB react-bot
npm/scheduler@0.0.0-experimental-a515d753b-20240220 environment +2 235 kB react-bot
npm/scheduler@0.24.0-canary-a515d753b-20240220 environment +2 235 kB react-bot

🚮 Removed packages: npm/react-dom@0.0.0-experimental-ba5e6a832-20240208, npm/react-dom@18.3.0-canary-ba5e6a832-20240208, npm/react-server-dom-turbopack@0.0.0-experimental-ba5e6a832-20240208, npm/react-server-dom-turbopack@18.3.0-canary-ba5e6a832-20240208, npm/react-server-dom-webpack@0.0.0-experimental-ba5e6a832-20240208, npm/react-server-dom-webpack@18.3.0-canary-ba5e6a832-20240208, npm/react@0.0.0-experimental-ba5e6a832-20240208, npm/react@18.3.0-canary-ba5e6a832-20240208, npm/scheduler@0.0.0-experimental-ba5e6a832-20240208, npm/scheduler@0.24.0-canary-ba5e6a832-20240208

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 20, 2024 •
edited
Loading

Failing test suites

Commit: 58ef5c4

pnpm test-dev test/development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts (PPR)

  • Strict Mode enabled by default > should work using browser
Expand output

● Strict Mode enabled by default › should work using browser

expect(received).toBe(expected) // Object.is equality

Expected: 2
Received: 1

  15 |         (log) => log.source === 'log' && log.message.match(/logged \d times/)
  16 |       )
> 17 |       expect(userLogs.length).toBe(2)
     |                               ^
  18 |       userLogs.forEach((log, i) => {
  19 |         expect(log.message).toBe(`logged ${i + 1} times`)
  20 |       })

  at Object.toBe (development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts:17:31)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts (PPR)

  • app dir - navigation > query string > useParams identity between renders > should be stable in app
Expand output

● app dir - navigation › query string › useParams identity between renders › should be stable in app

expect(received).toHaveLength(expected)

Expected length: 2
Received length: 1
Received array:  [{"message": "params changed", "source": "log"}]

  102 |               expect(
  103 |                 logs.filter(({ message }) => message === 'params changed')
> 104 |               ).toHaveLength(waitForNEffects)
      |                 ^
  105 |
  106 |               return logs.length
  107 |             })

  at toHaveLength (e2e/app-dir/navigation/navigation.test.ts:104:17)
  at retry (lib/next-test-utils.ts:724:14)
  at e2e/app-dir/navigation/navigation.test.ts:99:32

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 20, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
buildDuration 20.5s 20.4s N/A
buildDurationCached 8.8s 8.8s N/A
nodeModulesSize 196 MB 197 MB ⚠️ +743 kB
nextStartRea..uration (ms) 406ms 409ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.7 kB ⚠️ +127 B
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 101 kB 101 kB ⚠️ +127 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js upgrade-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js upgrade-react Change
_app-HASH.js gzip 196 B 196 B ✓
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B ✓
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 931 B 931 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js upgrade-react Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js upgrade-react Change
index.html gzip 529 B 528 B N/A
link.html gzip 540 B 541 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
edge-ssr.js gzip 94.8 kB 94.8 kB N/A
page.js gzip 152 kB 152 kB ⚠️ +356 B
Overall change 152 kB 152 kB ⚠️ +356 B
Middleware size
vercel/next.js canary vercel/next.js upgrade-react Change
middleware-b..fest.js gzip 627 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 44.9 kB 44.9 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB ✓
Overall change 2.1 kB 2.1 kB ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
app-page-exp...dev.js gzip 167 kB 170 kB ⚠️ +2.89 kB
app-page-exp..prod.js gzip 96.2 kB 96.5 kB ⚠️ +267 B
app-page-tur..prod.js gzip 97.9 kB 98.3 kB ⚠️ +324 B
app-page-tur..prod.js gzip 92.4 kB 92.8 kB ⚠️ +395 B
app-page.run...dev.js gzip 136 kB 151 kB ⚠️ +14.8 kB
app-page.run..prod.js gzip 90.9 kB 91.3 kB ⚠️ +336 B
app-route-ex...dev.js gzip 22.1 kB 21.9 kB N/A
app-route-ex..prod.js gzip 14.9 kB 15 kB N/A
app-route-tu..prod.js gzip 14.9 kB 15 kB N/A
app-route-tu..prod.js gzip 14.7 kB 14.7 kB N/A
app-route.ru...dev.js gzip 21.8 kB 21.6 kB N/A
app-route.ru..prod.js gzip 14.7 kB 14.7 kB N/A
pages-api-tu..prod.js gzip 9.49 kB 9.49 kB ✓
pages-api.ru...dev.js gzip 9.76 kB 9.76 kB ✓
pages-api.ru..prod.js gzip 9.48 kB 9.48 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.3 kB 50.3 kB ✓
Overall change 827 kB 846 kB ⚠️ +19 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js upgrade-react Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 104 kB 104 kB ⚠️ +458 B
Overall change 104 kB 104 kB ⚠️ +458 B
Diff details
Diff for page.js

Diff too large to display

Diff for 1068-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 58ef5c4

@huozhi huozhi marked this pull request as ready for review February 20, 2024 22:36
@huozhi
Copy link
Member Author

huozhi commented Feb 21, 2024

The tests seem to be passed locally..

@huozhi huozhi closed this Feb 21, 2024
@huozhi huozhi deleted the upgrade-react branch February 21, 2024 14:14
@github-actions github-actions bot added the locked label Mar 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked type: next type: react-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @unstubbable