Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-JSX propTypes checks #28326

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Remove non-JSX propTypes checks #28326

merged 1 commit into from
Feb 16, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 14, 2024

Removes all propTypes validation called from outside the JSX factories. Haven't touched JSX.

Tests that verify related behavior are stripped down to the non-propTypes logic.

@react-sizebot
Copy link

Comparing: adadb81...b4437a8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.83 kB 176.83 kB = 55.11 kB 55.11 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.83 kB 178.83 kB = 55.69 kB 55.69 kB
facebook-www/ReactDOM-prod.classic.js = 592.18 kB 592.18 kB = 104.43 kB 104.43 kB
facebook-www/ReactDOM-prod.modern.js = 575.46 kB 575.46 kB = 101.43 kB 101.43 kB
oss-experimental/react-server/cjs/react-server.development.js = 209.63 kB 204.92 kB = 48.72 kB 47.64 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 198.17 kB 193.46 kB = 46.80 kB 45.70 kB
oss-stable/react-server/cjs/react-server.development.js = 198.17 kB 193.46 kB = 46.80 kB 45.70 kB
test_utils/ReactAllWarnings.js Deleted 66.26 kB 0.00 kB Deleted 16.32 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,376.19 kB 1,367.90 kB = 304.20 kB 302.38 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,692.09 kB 1,681.87 kB = 336.18 kB 334.11 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,423.61 kB 1,414.94 kB = 302.96 kB 301.06 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,358.34 kB 1,350.05 kB = 299.92 kB 298.11 kB
facebook-www/ReactDOM-dev.classic.js = 1,670.51 kB 1,660.29 kB = 331.63 kB 329.56 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,660.84 kB 1,650.62 kB = 330.53 kB 328.58 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,406.88 kB 1,398.21 kB = 299.78 kB 297.86 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,406.85 kB 1,398.18 kB = 299.75 kB 297.83 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,342.39 kB 1,334.10 kB = 296.77 kB 294.93 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,342.36 kB 1,334.07 kB = 296.74 kB 294.90 kB
facebook-www/ReactDOM-dev.modern.js = 1,639.31 kB 1,629.10 kB = 325.98 kB 324.04 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 961.94 kB 953.65 kB = 206.48 kB 204.61 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 949.76 kB 941.47 kB = 204.10 kB 202.19 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 949.73 kB 941.44 kB = 204.07 kB 202.16 kB
oss-experimental/react-art/umd/react-art.development.js = 979.09 kB 970.42 kB = 207.23 kB 205.34 kB
oss-stable/react-art/umd/react-art.development.js = 966.30 kB 957.63 kB = 204.77 kB 202.90 kB
oss-stable-semver/react-art/umd/react-art.development.js = 966.27 kB 957.60 kB = 204.74 kB 202.88 kB
facebook-www/ReactART-dev.classic.js = 1,068.05 kB 1,057.84 kB = 209.68 kB 207.58 kB
oss-experimental/react-art/cjs/react-art.development.js = 861.75 kB 853.46 kB = 187.97 kB 186.09 kB
facebook-www/ReactART-dev.modern.js = 1,055.85 kB 1,045.64 kB = 207.29 kB 205.18 kB
oss-stable/react-art/cjs/react-art.development.js = 849.56 kB 841.27 kB = 185.59 kB 183.73 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 849.54 kB 841.25 kB = 185.57 kB 183.70 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 1,022.65 kB 1,012.57 kB = 205.94 kB 203.94 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 870.48 kB 861.81 kB = 183.99 kB 182.12 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 831.33 kB 823.04 kB = 182.06 kB 180.20 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 869.18 kB 860.51 kB = 183.75 kB 181.87 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js = 869.15 kB 860.48 kB = 183.72 kB 181.84 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 830.07 kB 821.78 kB = 181.81 kB 179.94 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 830.04 kB 821.75 kB = 181.78 kB 179.91 kB
react-native/implementations/ReactFabric-dev.fb.js = 1,008.04 kB 997.96 kB = 202.24 kB 200.20 kB
react-native/implementations/ReactNativeRenderer-dev.js = 1,002.55 kB 992.46 kB = 202.67 kB 200.69 kB
react-native/implementations/ReactFabric-dev.js = 986.26 kB 976.18 kB = 198.53 kB 196.58 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js = 463.92 kB 459.09 kB = 99.22 kB 98.10 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 443.94 kB 439.32 kB = 98.35 kB 97.24 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 443.36 kB 438.74 kB = 98.21 kB 97.11 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 441.79 kB 437.17 kB = 97.43 kB 96.32 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 436.34 kB 431.72 kB = 97.57 kB 96.41 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js = 454.64 kB 449.81 kB = 98.05 kB 96.91 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 434.49 kB 429.86 kB = 97.10 kB 95.95 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 942.05 kB 931.96 kB = 188.06 kB 186.08 kB
facebook-www/ReactTestRenderer-dev.classic.js = 951.99 kB 941.78 kB = 189.79 kB 187.67 kB
facebook-www/ReactTestRenderer-dev.modern.js = 951.99 kB 941.77 kB = 189.79 kB 187.67 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 428.18 kB 423.56 kB = 95.14 kB 94.01 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 422.25 kB 417.63 kB = 95.24 kB 94.11 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 422.23 kB 417.60 kB = 95.22 kB 94.08 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js = 439.97 kB 435.14 kB = 95.75 kB 94.60 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js = 439.94 kB 435.11 kB = 95.73 kB 94.58 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js = 439.49 kB 434.66 kB = 95.94 kB 94.82 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js = 439.47 kB 434.64 kB = 95.91 kB 94.80 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js = 420.52 kB 415.90 kB = 95.09 kB 93.96 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js = 420.50 kB 415.87 kB = 95.07 kB 93.93 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js = 420.40 kB 415.77 kB = 94.77 kB 93.64 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js = 420.37 kB 415.75 kB = 94.75 kB 93.62 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js = 419.94 kB 415.31 kB = 94.95 kB 93.83 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js = 419.91 kB 415.29 kB = 94.93 kB 93.80 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js = 418.90 kB 414.28 kB = 93.90 kB 92.76 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js = 418.87 kB 414.25 kB = 93.87 kB 92.75 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js = 414.09 kB 409.47 kB = 92.81 kB 91.70 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js = 414.07 kB 409.44 kB = 92.79 kB 91.67 kB
facebook-www/ReactDOMServer-dev.classic.js = 491.32 kB 485.58 kB = 99.86 kB 98.60 kB
oss-experimental/react-server/cjs/react-server.development.js = 209.63 kB 204.92 kB = 48.72 kB 47.64 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 198.17 kB 193.46 kB = 46.80 kB 45.70 kB
oss-stable/react-server/cjs/react-server.development.js = 198.17 kB 193.46 kB = 46.80 kB 45.70 kB
test_utils/ReactAllWarnings.js Deleted 66.26 kB 0.00 kB Deleted 16.32 kB 0.00 kB

Generated by 🚫 dangerJS against b4437a8

@gaearon gaearon mentioned this pull request Feb 14, 2024
Merged
@gaearon gaearon merged commit fea900e into main Feb 16, 2024
36 checks passed
@gaearon gaearon deleted the rm-more-proptypes branch February 16, 2024 00:35
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@gaearon
Remove non-JSX propTypes checks (#28326)
b19c9fe 
Removes all `propTypes` validation called from outside the JSX
factories. Haven't touched JSX.

Tests that verify related behavior are stripped down to the
non-`propTypes` logic.

DiffTrain build for [fea900e](fea900e)
This was referenced Feb 20, 2024
Closed
Merged
huozhi added a commit to vercel/next.js that referenced this pull request Feb 23, 2024
@huozhi
Upgrade vendored react (#62326)
e5d604f 
### React upstream changes

- facebook/react#28333
- facebook/react#28334
- facebook/react#28378
- facebook/react#28377
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269

Closes NEXT-2542


Disable ppr test for strict mode for now, @acdlite will check it and
we'll sync again
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gaearon @AndyPengc12
Remove non-JSX propTypes checks (facebook#28326)
1e18858 
Removes all `propTypes` validation called from outside the JSX
factories. Haven't touched JSX.

Tests that verify related behavior are stripped down to the
non-`propTypes` logic.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gaearon
Remove non-JSX propTypes checks (#28326)
1fd3b1a 
Removes all `propTypes` validation called from outside the JSX
factories. Haven't touched JSX.

Tests that verify related behavior are stripped down to the
non-`propTypes` logic.

DiffTrain build for commit fea900e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @react-sizebot @kassens @facebook-github-bot