Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Better error message if you pass a function as a child to a client component #28367

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[Flight] Better error message if you pass a function as a child to a client component #28367

merged 1 commit into from
Feb 19, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Similar to #28362 but if you pass it to a client component.

@sebmarkbage sebmarkbage requested review from gnoff and acdlite February 18, 2024 03:49
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 18, 2024
@react-sizebot
Copy link

react-sizebot commented Feb 18, 2024 •
edited
Loading

Comparing: 65a0e2b...e97e030

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.01 kB 177.01 kB = 55.17 kB 55.17 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.00 kB 179.00 kB = 55.74 kB 55.74 kB
facebook-www/ReactDOM-prod.classic.js = 592.58 kB 592.58 kB = 104.54 kB 104.54 kB
facebook-www/ReactDOM-prod.modern.js = 575.87 kB 575.87 kB = 101.55 kB 101.55 kB
test_utils/ReactAllWarnings.js Deleted 66.90 kB 0.00 kB Deleted 16.40 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.98% 70.39 kB 71.09 kB +0.91% 16.80 kB 16.96 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.98% 70.39 kB 71.09 kB +0.91% 16.80 kB 16.96 kB
facebook-www/ReactFlightDOMServer-dev.modern.js +0.97% 88.63 kB 89.49 kB +0.94% 18.84 kB 19.02 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.87% 80.09 kB 80.78 kB +0.83% 18.78 kB 18.93 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.66% 104.69 kB 105.38 kB +0.61% 24.60 kB 24.75 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.66% 104.69 kB 105.38 kB +0.61% 24.60 kB 24.75 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.min.js +0.64% 16.15 kB 16.26 kB +0.89% 5.98 kB 6.04 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js +0.64% 16.15 kB 16.26 kB +0.89% 5.98 kB 6.04 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.64% 107.71 kB 108.40 kB +0.60% 25.61 kB 25.76 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.64% 107.71 kB 108.40 kB +0.60% 25.61 kB 25.76 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.64% 108.41 kB 109.10 kB +0.59% 25.81 kB 25.96 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.64% 108.41 kB 109.10 kB +0.59% 25.81 kB 25.96 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.63% 110.16 kB 110.85 kB +0.54% 26.28 kB 26.42 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.63% 110.16 kB 110.85 kB +0.54% 26.28 kB 26.42 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.63% 110.34 kB 111.03 kB +0.59% 26.31 kB 26.46 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.63% 110.34 kB 111.03 kB +0.59% 26.31 kB 26.46 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.63% 110.84 kB 111.54 kB +0.57% 25.98 kB 26.12 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.63% 110.84 kB 111.54 kB +0.57% 25.98 kB 26.12 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js +0.62% 113.72 kB 114.42 kB +0.58% 25.94 kB 26.09 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js +0.62% 113.72 kB 114.42 kB +0.58% 25.94 kB 26.09 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.61% 113.13 kB 113.83 kB +0.55% 26.54 kB 26.68 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.61% 113.13 kB 113.83 kB +0.55% 26.54 kB 26.68 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.61% 113.49 kB 114.18 kB +0.55% 26.81 kB 26.96 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.61% 113.49 kB 114.18 kB +0.55% 26.81 kB 26.96 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.61% 116.29 kB 116.99 kB +0.58% 26.60 kB 26.75 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.61% 116.29 kB 116.99 kB +0.58% 26.60 kB 26.75 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.60% 115.27 kB 115.96 kB +0.60% 26.86 kB 27.02 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.60% 115.77 kB 116.46 kB +0.54% 27.43 kB 27.57 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.60% 115.77 kB 116.46 kB +0.54% 27.43 kB 27.57 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.59% 118.08 kB 118.78 kB +0.56% 27.87 kB 28.02 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.58% 119.46 kB 120.15 kB +0.54% 28.28 kB 28.44 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.57% 120.53 kB 121.22 kB +0.54% 28.53 kB 28.69 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.57% 121.39 kB 122.08 kB +0.52% 28.79 kB 28.94 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.57% 121.42 kB 122.11 kB +0.57% 28.26 kB 28.42 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.development.js +0.57% 124.55 kB 125.25 kB +0.53% 28.18 kB 28.33 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js +0.56% 18.55 kB 18.66 kB +0.75% 6.64 kB 6.69 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.56% 123.71 kB 124.40 kB +0.55% 28.83 kB 28.99 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.56% 124.06 kB 124.76 kB +0.53% 29.12 kB 29.27 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.development.js +0.55% 127.12 kB 127.82 kB +0.50% 28.84 kB 28.99 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.55% 126.35 kB 127.04 kB +0.52% 29.73 kB 29.89 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.41% 25.27 kB 25.38 kB +0.61% 8.82 kB 8.87 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.41% 25.27 kB 25.38 kB +0.61% 8.82 kB 8.87 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.39% 26.51 kB 26.61 kB +0.51% 9.02 kB 9.07 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.39% 26.51 kB 26.61 kB +0.51% 9.02 kB 9.07 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.39% 26.62 kB 26.72 kB +0.55% 9.11 kB 9.16 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.39% 26.62 kB 26.72 kB +0.55% 9.11 kB 9.16 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.39% 27.00 kB 27.10 kB +0.49% 9.17 kB 9.22 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.39% 27.00 kB 27.10 kB +0.49% 9.17 kB 9.22 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.38% 27.03 kB 27.13 kB +0.50% 9.15 kB 9.20 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.38% 27.03 kB 27.13 kB +0.50% 9.15 kB 9.20 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.38% 27.13 kB 27.23 kB +0.54% 9.25 kB 9.30 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.38% 27.13 kB 27.23 kB +0.54% 9.25 kB 9.30 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.38% 27.41 kB 27.51 kB +0.47% 9.27 kB 9.31 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.38% 27.41 kB 27.51 kB +0.47% 9.27 kB 9.31 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.38% 27.71 kB 27.82 kB +0.56% 9.48 kB 9.53 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.37% 27.81 kB 27.92 kB +0.46% 9.47 kB 9.52 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.37% 27.81 kB 27.92 kB +0.46% 9.47 kB 9.52 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.37% 28.31 kB 28.41 kB +0.46% 9.62 kB 9.66 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.37% 28.31 kB 28.41 kB +0.46% 9.62 kB 9.66 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.37% 28.38 kB 28.49 kB +0.47% 9.62 kB 9.66 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.37% 28.38 kB 28.49 kB +0.47% 9.62 kB 9.66 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.36% 28.89 kB 28.99 kB +0.45% 9.77 kB 9.82 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.36% 28.89 kB 28.99 kB +0.45% 9.77 kB 9.82 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.36% 29.01 kB 29.11 kB +0.48% 9.69 kB 9.74 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.36% 29.12 kB 29.22 kB +0.50% 9.79 kB 9.84 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.35% 29.50 kB 29.60 kB +0.47% 9.85 kB 9.89 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.35% 29.53 kB 29.63 kB +0.49% 9.82 kB 9.87 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.35% 29.63 kB 29.73 kB +0.49% 9.94 kB 9.99 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.35% 29.91 kB 30.01 kB +0.46% 9.95 kB 9.99 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.34% 30.25 kB 30.36 kB +0.46% 10.13 kB 10.18 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.34% 30.75 kB 30.85 kB +0.45% 10.28 kB 10.32 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.34% 30.83 kB 30.93 kB +0.43% 10.28 kB 10.32 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.33% 31.33 kB 31.44 kB +0.44% 10.43 kB 10.48 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.js +0.30% 57.80 kB 57.97 kB +0.34% 14.15 kB 14.19 kB
oss-stable/react-server/cjs/react-server-flight.production.js +0.30% 57.80 kB 57.97 kB +0.34% 14.15 kB 14.19 kB
oss-experimental/react-server/cjs/react-server-flight.production.js +0.26% 67.47 kB 67.65 kB +0.31% 16.12 kB 16.17 kB
facebook-www/ReactFlightDOMServer-prod.modern.js +0.25% 38.60 kB 38.69 kB +0.33% 8.80 kB 8.82 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.21% 54.23 kB 54.34 kB +0.28% 13.04 kB 13.07 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.21% 54.23 kB 54.34 kB +0.28% 13.04 kB 13.07 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.21% 54.43 kB 54.54 kB +0.27% 13.10 kB 13.14 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.21% 54.43 kB 54.54 kB +0.27% 13.10 kB 13.14 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +0.20% 55.84 kB 55.95 kB +0.23% 13.72 kB 13.75 kB
oss-stable/react-client/cjs/react-client-flight.development.js +0.20% 55.84 kB 55.95 kB +0.23% 13.72 kB 13.75 kB
test_utils/ReactAllWarnings.js Deleted 66.90 kB 0.00 kB Deleted 16.40 kB 0.00 kB

Generated by 🚫 dangerJS against e97e030

@sebmarkbage sebmarkbage force-pushed the invalidchilderrorflight branch 3 times, most recently from b5a07ec to a89e5ed Compare February 18, 2024 17:31
@sebmarkbage sebmarkbage force-pushed the invalidchilderrorflight branch 2 times, most recently from b76b4fb to 36e67a6 Compare February 19, 2024 17:29
@sebmarkbage sebmarkbage force-pushed the invalidchilderrorflight branch from 36e67a6 to e97e030 Compare February 19, 2024 17:30
@sebmarkbage sebmarkbage merged commit 2e84e16 into facebook:main Feb 19, 2024
35 of 36 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 19, 2024
@sebmarkbage
[Flight] Better error message if you pass a function as a child to a …
3ff23f9 
…client component (#28367)

Similar to #28362 but if you pass it to a client component.

DiffTrain build for [2e84e16](2e84e16)
@sebmarkbage sebmarkbage mentioned this pull request Feb 19, 2024
Merged
This was referenced Feb 20, 2024
Closed
Merged
huozhi added a commit to vercel/next.js that referenced this pull request Feb 23, 2024
@huozhi
Upgrade vendored react (#62326)
e5d604f 
### React upstream changes

- facebook/react#28333
- facebook/react#28334
- facebook/react#28378
- facebook/react#28377
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269

Closes NEXT-2542


Disable ppr test for strict mode for now, @acdlite will check it and
we'll sync again
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @AndyPengc12
[Flight] Better error message if you pass a function as a child to a …
086cfc2 
…client component (facebook#28367)

Similar to facebook#28362 but if you pass it to a client component.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sebmarkbage
[Flight] Better error message if you pass a function as a child to a …
469809a 
…client component (#28367)

Similar to #28362 but if you pass it to a client component.

DiffTrain build for commit 2e84e16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @acdlite @facebook-github-bot