Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15-next #7000

Closed
wants to merge 81 commits into from
Closed

15-next #7000

wants to merge 81 commits into from

Conversation

zpao
Copy link
Member

@zpao zpao commented Jun 8, 2016

not for merge

This is mostly a trial run of everything that would go into the next v15.* release using the tool I'm building (more on that later). There is no manual curation here and the tool isn't complete, but I can say confidently that this would be a minor release.

Actual plan for releasing this:

  • triple check that all the PRs that should be here are, will require another triage pass, will possibly re-run entire process.
  • revert part of [Fiber] Child Reconciler + New Coroutines Primitive #6859 (for the valid element check)
  • close this PR without merging, instead push 15-dev branch (or maybe call it 15-next to match the milestone)
  • update milestone for all cherry-picked PRs to ensure we don't get mixed up with other things that might get merged targeted for another version
  • bump the version
  • ship as 15.2.0-rc.1 (or alpha?)
    (this part is interesting - if we picked up more changes we would only change the prerelease part of the version, even if it's a semver-bump-required change)
  • make sure tests pass

jimfb and others added 30 commits June 8, 2016 11:34
Don't wrap drag events in IE/Edge in dev builds
(cherry picked from commit 2e8f28c)
Fix the warning condition in ReactDebugTool and ReactDOMDebugTool
(cherry picked from commit 7dbc95f)
(cherry picked from commit aeda846)
Update Jest’s grunt task.
(cherry picked from commit 6440115)
That crept in in c1e3f7e.
(cherry picked from commit 4f01b4b)
…top of server-generated markup. (facebook#6668)

(cherry picked from commit 256753b)
This just configures flow to be checked and fixes our existing
Flow typed files.

Possible enhancements:

Export .js.flow declarations from the build. Unclear whether this
will be a supported workflow in the future or not, so let's wait
on that.

We should fail builds and CI on Flow errors.

Ideally we should lint for Flow style guides (like no space before
colon).
(cherry picked from commit 771d938)
…warning (facebook#6398)

* New approach for 6062 fix : Show source line number on unknown property warning

* WIP: ReactDebugToolEventForwarderDevTool

* Update event signature to debugID

* Trigger events in ReactDOMComponent

* Renamed to onMountDOMComponent; passing in element directly

* Added debugID; updated simple test

* Added test for multi-div JSX to ref exact line

* Added test for composite component

(cherry picked from commit 7cf61db)
_isOwnerNecessary was unused.
(cherry picked from commit e01bf78)
Best practice or whatever.
(cherry picked from commit 700b714)
Add new primitive PropType `Symbol`
(cherry picked from commit 7bf96c0)
The new flow somehow found these on my machine but nowhere else
and not previously.
(cherry picked from commit 069f809)
This is an outline for the new reconciler infrastructure.

I created a noop renderer to have something to get started from.

I split the reconciler folder into old and new, as well as shared.
I put shouldUpdateReactComponent in shared as an example of a
utility that can easily be shared between both. I plan on breaking
out more utilities like these.
(cherry picked from commit cf15788)
For clarity.

I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils.
(cherry picked from commit ba9b985)
added isProfiling() to ReactDebugTool and isRunning() to PerfTools
(cherry picked from commit 5569d1d)
Fix remaining onNativeOperation => onHostOperation rename
(cherry picked from commit 74cce27)
…6765)

Being able to get the source for your parent components seems useful, and ReactComponentTreeDevtool is best poised to be able to do that.

I'm also not sure it makes sense to have separate DOM-specific `onMountDOMComponent` and `onUpdateDOMComponent` events, so I removed them for now. Even if we want them, their timing seemed sort of arbitrary.

I also made it so DOM devtools can listen to non-DOM events too. Willing to change that if people think it's ugly though.
(cherry picked from commit 03f4ba2)
gaearon and others added 25 commits June 8, 2016 11:34
Update to Jest 12.1.1 and Jasmine 2
(cherry picked from commit c0ecde6)
This brings createElement() fix from facebook#6855 to cloneElement().
(cherry picked from commit e822cbd)
Fix issues introduced by createElement() warning
(cherry picked from commit 2d74280)
Added own property check when deleting listeners.
(cherry picked from commit ca5a0da)
…ebook#6896)

* Stop passing null as second argument to document.createElement()

* rewrap check for props.is to make it more readable

(cherry picked from commit 2636155)
[Fiber] Child Reconciler + New Coroutines Primitive
(cherry picked from commit 0f4a4df)
Don't warn when style value is '0'
(cherry picked from commit 5c6f9d3)
[Fiber] Transfer everything from Element onto the Fiber and use Tag instead of Stage
(cherry picked from commit 7de2375)
[Fiber] Simple test assertions
(cherry picked from commit dc5686a)
…-html (facebook#6862)

* Replacing the implementation of escapeTextContentForBrowser with escape-html for performance

* Addressing @spicyj's code review comment here: facebook#6862 (comment) . Pulled the code of escape-html in to react and changed the encoding of single quote to &#x27.

* Addressing code review comment facebook#6862 (comment) to make code more inlinable for v8. Thanks, @spicyj.

(cherry picked from commit d6e7058)
Upgrade Flow
(cherry picked from commit d3b36d5)
Firefox doesn't like these and throws.
(cherry picked from commit 3c3c30a)
…ebook#6982)

* Workaround IE lacking innerHTML on SVG elements

* Add tests for setInnerHTML

* Correctly check if node has innerHTML property

* Ensure tests for setInnerHTML actually tests both codepaths

* Provide mock element for setInnerHTML tests

* Only use SVG setInnerHTML workaround for SVG elements

(cherry picked from commit 99d8524)
@keyz
Copy link
Contributor

keyz commented Jun 8, 2016

Just a quick note: #6990 added a new invariant message after #6882, so we'd need to update the error json for this release.

@zpao
Copy link
Member Author

zpao commented Jun 15, 2016

Pushed the 15-dev branch and working through the last couple things so closing this out.

@zpao zpao closed this Jun 15, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.