Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale bot #2825

Closed
wants to merge 28 commits into from
Closed

Add stale bot #2825

wants to merge 28 commits into from

Conversation

AGMETEOR
Copy link
Contributor

What does this change

Introduces a stale bot that marks issues and PRs as stale after some time

What issue does it fix

Closes #2796

Notes for the reviewer

This implementation uses https://github.com/actions/stale .
We need to discuss certain things, like the text for the stale labels, after how long to mark as stale, close or leave PRs and issues open once they go stale?

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@AGMETEOR AGMETEOR marked this pull request as ready for review July 14, 2023 14:32
Allan Guwatudde added 5 commits July 15, 2023 11:44
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
.github/workflows/stale-bot.yaml Outdated Show resolved Hide resolved
steps:
- uses: actions/stale@v8
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if getporter has this but using this, this token would have to be set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @troy0820 thanks for the review. I took this from another yaml file in this project

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Not sure if it's set. Is it possible to confirm if it's indeed set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^ was gonna suggest that it be this

Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <guwats10@gmail.com>
@schristoff
Copy link
Member

Let's set up some rules around closing issues, and we'll follow how the k8s stale bot does things.
Looking at this comment from the bot
Let's go ahead and take their lead on the timelines they set, as well as labels, and I like having the bot comment on the timelines. So.. let's just take the whole thing lol.

Bot should comment basically the same thing as the comment. I'll copy the comment so it's easier to see here:

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed
You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close

/lifecycle stale

(we can't don't have their triage for help or sigs so I removed those two bottom lines) replace kubernetes with porter and we should be g2g

@schristoff
Copy link
Member

Heya! Just wanted to check in and see if there's any assistance I can provide to get this merged! Thank you again for all your work.

@AGMETEOR
Copy link
Contributor Author

AGMETEOR commented Aug 1, 2023

Hi @schristoff just haven’t been feeling well. Will finish this off before this week ends.

@schristoff
Copy link
Member

No rush of course, your health comes first (and work, family, all those other things!). Feel better soon!

@AGMETEOR
Copy link
Contributor Author

AGMETEOR commented Aug 7, 2023

Heya! Just wanted to check in and see if there's any assistance I can provide to get this merged! Thank you again for all your work.

Just made some changes. I used the actions/stale workflow to compose together steps to handle the requirements for this bot. Now, I need to find a way to test it.

@troy0820
Copy link
Member

troy0820 commented Aug 7, 2023

@AGMETEOR Your DCO isn't set up again. Can you run mage SetupDCO or go run mage.go SetupDCO to fix that?

@AGMETEOR AGMETEOR force-pushed the add-stale-bot branch 9 times, most recently from a982db0 to bd3168e Compare August 9, 2023 22:28
Allan Guwatudde added 2 commits August 10, 2023 01:36
Signed-off-by: Allan Guwatudde <allan@Allans-MBP.domain.name>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>

Signed-off-by: Allan Guwatudde <allan@Allans-MBP.domain.name>
itsaviral2609 and others added 15 commits August 10, 2023 01:36
This PR fixes the 'Understand the difference between imperative commands and desired state'

Fixes: getporter#2820

Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* added .exe extension

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
fix link name and update deps

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
…ike `porter param show` (getporter#2824)

* change printer for displayParam to display with list showing values like param show

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Arhell <arhell333@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
added bundle name to command

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* update hugo to v0.115.4

Signed-off-by: Arhell <arhell333@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* feat: Generating changelog.md using github actions!

This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published!

fixes: getporter#2797
Signed-off-by: Aviral Singh <itsaviral.2609@gmail.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* added draft clarification for STATE and STATUS

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
bug: fix jq url in image

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
* update all the things

Co-authored-by: Troy Connor  <troy0820@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
Co-authored-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
update OWNERS.md to include troy0820 as a maintainer

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
…2855)

* (feat) Fix Unit Tests to pass on Windows

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>

---------

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
@troy0820 troy0820 added enhancement New code incoming! self care 💅 Little things that help the project and our community #self-care-friday project hygiene 🛠️ Project operational issues and back-office tasks labels Aug 10, 2023
@AGMETEOR
Copy link
Contributor Author

Got sidetracked a bit. But I am back working on this week

Allan Guwatudde added 2 commits August 21, 2023 23:46
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
…tale-bot

Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
@schristoff
Copy link
Member

After many discussions, here's what we've decided on:

  1. An auto-labeler
  2. Creating issue response templates
  3. Creating a triage.md and setting healthy and reasonable expectations on when we will triage.

I'm closing this for now and I'm going to be opening a triaging issue :)

@schristoff schristoff closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New code incoming! project hygiene 🛠️ Project operational issues and back-office tasks self care 💅 Little things that help the project and our community #self-care-friday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add stalebot to help with PRs/Issues
6 participants