Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for 8.16.0 #12831

Merged
merged 22 commits into from
Jul 9, 2024
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 9, 2024

No description provided.

github-actions bot and others added 18 commits July 5, 2024 09:18
[Gitflow] Merge master into develop
Adds a react 17 test app so we can hopefully catch breaking react 17, as
we did recently
(#12608) with
#12204 and
#12740.
Another day, another try to fix this!

Now it failed like this
https://github.com/getsentry/sentry-javascript/actions/runs/9804811101/job/27073251966,
hopefully this change fixes this... we'll see!
…#12761)

Today, it is not (easily) possible to use custom config for the OTEL
HttpInstrumentation. We depend on our own integration for various
things, so overwriting this will lead to lots of problems.

With this PR, you can now pass some config through directly, in an
"allowlisted" way, + there is an escape hatch to add arbitrary other
config:

```js
Sentry.init({
  integrations: [
    Sentry.httpIntegration({ instrumentation: {
      // these three are "vetted"
      requestHook: (span, req) => span.setAttribute('custom', req.method),
      responseHook: (span, res) => span.setAttribute('custom', res.method),
      applyCustomAttributesOnSpan: (span, req, res) => span.setAttribute('custom', req.method),
      // escape hatch: Can add arbitrary other config that is passed through
      _experimentalConfig: {
        serverName: 'xxx'
      }
    })
  ]
});
```

Closes #12672
… compatibility changes in dependencies (#12793)

This PR fixes our broken Remix v1 @ Node 16 integration test. Over the
weekend, the following transitive dependencies received minor and patch
releases which removed support for EOL Node versions.

- `glob` (isaacs/node-glob#596)
- `lru-cache` (isaacs/node-lru-cache#340)
- `jackspeack` (isaacs/jackspeak#13)

IMO this, despite the dropped versions being EOL, is a breaking change
and a major inconvenience for a lot of users. I added comments/opened
issues with the request to revert the Node version drops and do it in a
major version instead. We're by far not the only affected ones. As our
tests show, at least everyone using Remix@1 on Node 16 will be broken by
this.

To fix, I added dependency resolutions, mostly scoped to specific
packages that depend on one of the three packages. Global overrides for
`glob` and `lru-cache` did not work because we have multiple
dependencies depending on different major versions of said packages.
Enable running E2E tests on PRs opened from forked
repositories. Previously we excluded these because some E2E tests
required secrets which are not available in the forks, causing e2e test
runs to always fail. Now that we separated these tests from the e2e
tests that don't require secrets
(#12259) we should be
good to re-enable the required e2e tests for external PRs.
…12784)

This broke the `Add a screenshot` button on the user feedback, see
#12713

This has been explicitly removed in favor of injecting `h` in
#12535 but at that
point it seems to be too late to do.

Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.

So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.

Related to #12535
This is more a safety thing that we do not swallow this accidentally in
the future, that I noticed while looking through stuff.
I noticed that we were not actually enabling auto session tracking
correctly in node, because we did not check on the correct `options`
object 😬
@lforst lforst changed the base branch from develop to master July 9, 2024 13:28
@lforst lforst requested a review from a team as a code owner July 9, 2024 13:28
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
This does two things:

1. Pass the author association to the step - we do not use it right now,
but it will be logged at least, allowing us to debug this.
2. Include a reference to the merged PR in the PR body.
Reports errors thrown in nitro. Tests will be added when adding the E2E
test application.

closes #12795
@lforst lforst changed the base branch from master to develop July 9, 2024 13:47
Preparing `@sentry/nuxt` for a release (experimental)

Merge after this PR:
#12796
@lforst lforst changed the base branch from develop to master July 9, 2024 14:13
@lforst lforst merged commit 0ffd1ff into master Jul 9, 2024
29 of 30 checks passed
@lforst lforst deleted the prepare-release/8.16.0 branch July 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants