Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(changelog): Update changelog for 8.16.0 #12831

Merged
merged 22 commits into from
Jul 9, 2024
Merged

Commits on Jul 5, 2024

  1. Merge pull request #12780 from getsentry/master

    [Gitflow] Merge master into develop
    github-actions[bot] committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    552fc2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15230f1 View commit details
    Browse the repository at this point in the history
  3. chore(e2e): Add react-17 e2e test app (#12778)

    Adds a react 17 test app so we can hopefully catch breaking react 17, as
    we did recently
    (#12608) with
    #12204 and
    #12740.
    andreiborza committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f4e7203 View commit details
    Browse the repository at this point in the history
  4. ci: Fix permissions for external contributors PRs (for real?) (#12776)

    Another day, another try to fix this!
    
    Now it failed like this
    https://github.com/getsentry/sentry-javascript/actions/runs/9804811101/job/27073251966,
    hopefully this change fixes this... we'll see!
    mydea committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    55a5cef View commit details
    Browse the repository at this point in the history
  5. feat(node): Allow to pass instrumentation config to httpIntegration (

    …#12761)
    
    Today, it is not (easily) possible to use custom config for the OTEL
    HttpInstrumentation. We depend on our own integration for various
    things, so overwriting this will lead to lots of problems.
    
    With this PR, you can now pass some config through directly, in an
    "allowlisted" way, + there is an escape hatch to add arbitrary other
    config:
    
    ```js
    Sentry.init({
      integrations: [
        Sentry.httpIntegration({ instrumentation: {
          // these three are "vetted"
          requestHook: (span, req) => span.setAttribute('custom', req.method),
          responseHook: (span, res) => span.setAttribute('custom', res.method),
          applyCustomAttributesOnSpan: (span, req, res) => span.setAttribute('custom', req.method),
          // escape hatch: Can add arbitrary other config that is passed through
          _experimentalConfig: {
            serverName: 'xxx'
          }
        })
      ]
    });
    ```
    
    Closes #12672
    mydea committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a2dcb28 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ecc95e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. test(remix): Add dependency resolution overrides to fix breaking Node…

    … compatibility changes in dependencies (#12793)
    
    This PR fixes our broken Remix v1 @ Node 16 integration test. Over the
    weekend, the following transitive dependencies received minor and patch
    releases which removed support for EOL Node versions.
    
    - `glob` (isaacs/node-glob#596)
    - `lru-cache` (isaacs/node-lru-cache#340)
    - `jackspeack` (isaacs/jackspeak#13)
    
    IMO this, despite the dropped versions being EOL, is a breaking change
    and a major inconvenience for a lot of users. I added comments/opened
    issues with the request to revert the Node version drops and do it in a
    major version instead. We're by far not the only affected ones. As our
    tests show, at least everyone using Remix@1 on Node 16 will be broken by
    this.
    
    To fix, I added dependency resolutions, mostly scoped to specific
    packages that depend on one of the three packages. Global overrides for
    `glob` and `lru-cache` did not work because we have multiple
    dependencies depending on different major versions of said packages.
    Lms24 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d6cd5ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c54a79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e3ae56 View commit details
    Browse the repository at this point in the history
  4. test(e2e): Run required E2E tests on PRs from forks (#12791)

    Enable running E2E tests on PRs opened from forked
    repositories. Previously we excluded these because some E2E tests
    required secrets which are not available in the forks, causing e2e test
    runs to always fail. Now that we separated these tests from the e2e
    tests that don't require secrets
    (#12259) we should be
    good to re-enable the required e2e tests for external PRs.
    Lms24 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    aded253 View commit details
    Browse the repository at this point in the history
  5. fix(feedback): Add missing h import in ScreenshotEditor (#12713) (#…

    …12784)
    
    This broke the `Add a screenshot` button on the user feedback, see
    #12713
    
    This has been explicitly removed in favor of injecting `h` in
    #12535 but at that
    point it seems to be too late to do.
    
    Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
    andreiborza and ryan953 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3883517 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. ref(feedback): Let CropCorner inherit the existing h prop (#12814)

    I noticed this after
    #12784, but the
    `<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
    So of course it wasn't getting access to the `h` ref that is passed in.
    That variable is what the `<div>` gets transpiled into -> it becomes
    `h.createElement('div')`.
    
    So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
    we can pass `h` in and hopefully not have the extra `import .. from
    'preact';` in the 2nd bundle.
    
    Related to #12535
    ryan953 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    aefbfaa View commit details
    Browse the repository at this point in the history
  2. ref(otel): Ensure we never swallow args for ContextManager (#12798)

    This is more a safety thing that we do not swallow this accidentally in
    the future, that I noticed while looking through stuff.
    mydea committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    07c1360 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f590fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    25db805 View commit details
    Browse the repository at this point in the history
  5. fix(node): Ensure autoSessionTracking is enabled by default (#12790)

    I noticed that we were not actually enabling auto session tracking
    correctly in node, because we did not check on the correct `options`
    object 😬
    mydea committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9b5cf26 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    580e6a4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a5ea680 View commit details
    Browse the repository at this point in the history
  8. ci: Small adaptions to external contributor workflow (#12828)

    This does two things:
    
    1. Pass the author association to the step - we do not use it right now,
    but it will be logged at least, allowing us to debug this.
    2. Include a reference to the merged PR in the PR body.
    mydea committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0952ec4 View commit details
    Browse the repository at this point in the history
  9. feat(nuxt): Add server error hook (#12796)

    Reports errors thrown in nitro. Tests will be added when adding the E2E
    test application.
    
    closes #12795
    s1gr1d committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    47e1b7e View commit details
    Browse the repository at this point in the history
  10. build(nuxt): Add nuxt to craft (#12821)

    Preparing `@sentry/nuxt` for a release (experimental)
    
    Merge after this PR:
    #12796
    s1gr1d committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6da0728 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d9c6dd2 View commit details
    Browse the repository at this point in the history