dockerfile: Split dependencies stage #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the build slightly quicker, by having a stage which is cached if our dependencies haven't changed.
Currently, the workloads controller has a hard dependency on `DirectoryRoleBinding`s, as provided by the RBAC controller, in order to create consoles. If you try to do this, without having the RBAC controller installed, then the reconcile loop gets stuck, as the rolebinding to access the console can't be provisioned. This is a bit presumptuous; it should be possible to run consoles without DRBs, e.g. if you just want to reference plain `User` kinds in `additionalAttachSubjects`. This change adds a flag, which makes the usage of `DirectoryRoleBinding` optional. The flag defaults to true, meaning that this isn't a breaking change. We intended to use this in conjunction with [Google Groups for RBAC][0] as an alternative. [0]: https://cloud.google.com/kubernetes-engine/docs/how-to/google-groups-rbac
Resolve this error: ``` panic: interface conversion: runtime.Object is *v1.Status, not *unstructured.Unstructured ``` There was an assumption of the object type that didn't hold true. If a watch `ERROR` event type is received, then it should be cast to a `v1.Status` instead. To avoid this, skip the event if it's of this type. This is likely fine for this case, as per the comment. Also add some extra error handling. https://github.com/kubernetes/apimachinery/blob/fd8daa85285e31da9771dbe372a66dfa20e78489/pkg/watch/watch.go#L43-L70
This will include the large change mentioned here: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0 While here, also change the module path, as this looks to be the proper way of doing things.
Make this compile again, as some options have been moved around.
This brings in the new k8s 1.28.0 fields values.
We're using k8s v1.28 APIs, so let's go to the latest available Kind image, to run a 1.27 cluster.
Our app was being deployed before `cert-manager` was fully up and running, leading to theatre pods stuck in a `ContainerCreating` state, due to a missing secret volume.
Update controller-runtime to v0.16.3
|
Opened this with the wrong source branch, so it now looks quite broken. Can't change the branch so closing, will reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the build slightly quicker, by having a stage which is cached if our dependencies haven't changed.