Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: Split dependencies stage #323

Closed
wants to merge 17 commits into from

Commits on Aug 29, 2023

  1. dockerfile: Split dependencies stage

    Make the build slightly quicker, by having a stage which is cached if
    our dependencies haven't changed.
    benwh committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    82d6c21 View commit details
    Browse the repository at this point in the history
  2. consoles: Make DirectoryRoleBinding optional

    Currently, the workloads controller has a hard dependency on
    `DirectoryRoleBinding`s, as provided by the RBAC controller, in order to
    create consoles. If you try to do this, without having the RBAC
    controller installed, then the reconcile loop gets stuck, as the
    rolebinding to access the console can't be provisioned.
    
    This is a bit presumptuous; it should be possible to run consoles
    without DRBs, e.g. if you just want to reference plain `User` kinds in
    `additionalAttachSubjects`.
    
    This change adds a flag, which makes the usage of `DirectoryRoleBinding`
    optional. The flag defaults to true, meaning that this isn't a breaking
    change.
    
    We intended to use this in conjunction with [Google Groups for RBAC][0]
    as an alternative.
    
    [0]: https://cloud.google.com/kubernetes-engine/docs/how-to/google-groups-rbac
    benwh committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    87666ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    17097a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. v4.3.0

    benwh committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5616c33 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Fix panic in waitForConsole

    Resolve this error:
    ```
    panic: interface conversion: runtime.Object is *v1.Status, not *unstructured.Unstructured
    ```
    
    There was an assumption of the object type that didn't hold true. If a
    watch `ERROR` event type is received, then it should be cast to a `v1.Status`
    instead.
    
    To avoid this, skip the event if it's of this type. This is likely fine
    for this case, as per the comment.
    
    Also add some extra error handling.
    
    https://github.com/kubernetes/apimachinery/blob/fd8daa85285e31da9771dbe372a66dfa20e78489/pkg/watch/watch.go#L43-L70
    benwh committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    afd42a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62fe86a View commit details
    Browse the repository at this point in the history
  3. v4.3.1

    benwh committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    26dbade View commit details
    Browse the repository at this point in the history
  4. v3 -> v4

    Make the package version match the tagged version.
    benwh committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ed76aa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Update controller-runtime to v0.16.3

    This will include the large change mentioned here: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0
    
    While here, also change the module path, as this looks to be the proper
    way of doing things.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    4fa0ddf View commit details
    Browse the repository at this point in the history
  2. Update controllers for new controller-runtime APIs

    Make this compile again, as some options have been moved around.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    de88551 View commit details
    Browse the repository at this point in the history
  3. Regenerate manifests

    This brings in the new k8s 1.28.0 fields values.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7969e20 View commit details
    Browse the repository at this point in the history
  4. Update kind version

    We're using k8s v1.28 APIs, so let's go to the latest available Kind
    image, to run a 1.27 cluster.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2e7963f View commit details
    Browse the repository at this point in the history
  5. Fix race condition in acceptance tests

    Our app was being deployed before `cert-manager` was fully up and
    running, leading to theatre pods stuck in a `ContainerCreating` state,
    due to a missing secret volume.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b384c1c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aeda687 View commit details
    Browse the repository at this point in the history
  7. v5.0.0

    Bump the major version, as we've upgraded many things, and may have lost
    compatibility with older clusters.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ee83746 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #4 from incident-io/upgrade-controller-runtime

    Update controller-runtime to v0.16.3
    benwh authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    27f49dc View commit details
    Browse the repository at this point in the history
  9. v5.0.1

    Fixup go.mod versioning issues.
    benwh committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    20c0698 View commit details
    Browse the repository at this point in the history