Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Compatibility Reflection Probe Limitations #9839

Closed
wants to merge 79 commits into from

Conversation

551E5
Copy link

@551E5 551E5 commented Aug 26, 2024

Including intended limitations for using Reflection Probes with the compatibility renderer (88056).

russellsanborn and others added 30 commits July 6, 2024 08:41
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
…stem.rst

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
`AnimationNode`'s inherited classes are `Resource`, `RefCounted`, and `Object`.

I assume it meant to say "derived classes", or something along the lines of
"and all classes which inherit it".
…ure-docs-gdextension-system

Fix project structure diagram in gdextension docs system docs
…on-manual

Fix glTF capitalization in manual
Add commas before "but" throughout documentation
…nced-postprocessing

Fix compile error in advanced_postprocessing.rst
In "avoidance_priority" property description, changed "important npcs characters" to "important non playable characters". The term "npc", means "non playable character", so to say "non playable characters characters" seems like an error.
Corrected grammar on line 141
Fixing issues/9775
AThousandShips and others added 17 commits August 23, 2024 19:02
…mization-csharp

Add C# example to CPU optimization
Co-authored-by: Raul Santos <raulsntos@gmail.com>
…el-multiplayer-csharp

Add C# examples to High-level Multiplayer documentation
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
…nd-loading-csharp

Add C# examples to Background loading
…-movies-csharp

Add C# example to Creating movies
…s-examples-csharp

Add C# examples to Using Viewports documentation
…ruction

Add link to `godot-proposals` in the issue template
…550cb

classref: Sync with current master branch (e3550cb)
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
…videos-csharp

Add C# example to Playing videos
…s.rst autoloads_versus_internal_nodes.rst

remove 'a' from "share a variables"
Remove article before plural noun in autoloads_versus_internal_nodes.rst
Fix grammar in one sentence
Add reference to mentioned node
Update animations text in data_preferences.rst
@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Aug 27, 2024
@mhilbrunner mhilbrunner changed the base branch from 4.3 to master August 27, 2024 04:27
@mhilbrunner mhilbrunner changed the base branch from master to 4.3 August 27, 2024 04:27
@mhilbrunner
Copy link
Member

Heya! Thanks for contributing. Note for the future: PRs that apply to future versions too should always go against the master branch, and will be cherrypicked to previous release docs (4.3 in this case) by the documentation team.

@skyace65
Copy link
Contributor

skyace65 commented Sep 7, 2024

Tried changing the base branch, didn't work, going to make a new PR to salvage this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.