Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(bigtable)!: remove deprecated InstanceAdmin IAM functions #8652

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Apr 1, 2022

The bigtable part of #5929

I think the storage part will require some minor test updates, so I am going to break the task up into three PRs.

  1. Bigtable
  2. Storage
  3. Common

I will not remove the future breaking change note in the CHANGELOG until step 3.


This change is Reviewable

@dbolduc dbolduc requested a review from a team as a code owner April 1, 2022 16:34
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a33bcb3aabfc86b89e1d4dd5711a1d5dd1c71c47

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #8652 (a33bcb3) into main (55b8ab0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8652      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files        1462     1462              
  Lines      124461   124357     -104     
==========================================
- Hits       116291   116212      -79     
+ Misses       8170     8145      -25     
Impacted Files Coverage Δ
google/cloud/bigtable/instance_admin.cc 100.00% <ø> (+2.64%) ⬆️
google/cloud/bigtable/instance_admin.h 100.00% <ø> (ø)
google/cloud/bigtable/instance_admin_test.cc 98.58% <ø> (-0.12%) ⬇️
.../bigtable/tests/instance_admin_integration_test.cc 98.86% <ø> (-0.08%) ⬇️
google/cloud/bigtable/version.h 100.00% <ø> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
google/cloud/iam_bindings.h 95.00% <0.00%> (-0.66%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
...oud/storage/tests/object_media_integration_test.cc 100.00% <0.00%> (+1.17%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 99.00% <0.00%> (+1.24%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b8ab0...a33bcb3. Read the comment docs.

@dbolduc dbolduc enabled auto-merge (squash) April 1, 2022 17:01
@dbolduc dbolduc merged commit e84a574 into googleapis:main Apr 1, 2022
@dbolduc dbolduc deleted the bigtable-remove-iam-wrappers branch April 2, 2022 18:35
devbww added a commit to devbww/google-cloud-cpp that referenced this pull request May 4, 2022
`GOOGLE_CLOUD_CPP_BIGTABLE_IAM_DEPRECATED` disappeared in googleapis#8652.
`GOOGLE_CLOUD_CPP_IAM_DEPRECATED` disappeared in googleapis#8667.
devbww added a commit that referenced this pull request May 4, 2022
`GOOGLE_CLOUD_CPP_BIGTABLE_IAM_DEPRECATED` disappeared in #8652.
`GOOGLE_CLOUD_CPP_IAM_DEPRECATED` disappeared in #8667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants